From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: richardcochran@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, xiaoning.wang@nxp.com, Frank.Li@nxp.com,
yangbo.lu@nxp.com, christophe.leroy@csgroup.eu,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH net-next 1/3] ptp: add debugfs interfaces to loop back the periodic output signal
Date: Thu, 4 Sep 2025 16:30:11 +0300 [thread overview]
Message-ID: <20250904133011.asqvsucdmuktazc4@skbuf> (raw)
In-Reply-To: <20250903083749.1388583-2-wei.fang@nxp.com> <20250903083749.1388583-2-wei.fang@nxp.com>
On Wed, Sep 03, 2025 at 04:37:47PM +0800, Wei Fang wrote:
> + buf[len] = '\0';
> + cnt = sscanf(buf, "%u %d", &index, &enable);
> + if (cnt != 2)
> + return -EINVAL;
> +
> + if (index >= ops->n_per_lp)
> + return -EINVAL;
> +
> + err = ops->perout_loopback(ops, index, enable ? 1 : 0);
Why not just reject other 'enable' values than 1 or 0? You make it
impossible for other values like '2' to be used in the future, if they
are currently treated the same as '1'.
Also, signed 'enable' doesn't make much sense.
> + if (err)
> + return err;
> +
> + return count;
> +}
next prev parent reply other threads:[~2025-09-04 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 8:37 [PATCH net-next 0/3] ptp: add pulse signal loopback support for debugging Wei Fang
2025-09-03 8:37 ` [PATCH net-next 1/3] ptp: add debugfs interfaces to loop back the periodic output signal Wei Fang
2025-09-04 13:30 ` Vladimir Oltean [this message]
2025-09-05 2:25 ` Wei Fang
2025-09-03 8:37 ` [PATCH net-next 2/3] ptp: netc: add the periodic output signal loopback support Wei Fang
2025-09-04 13:31 ` Vladimir Oltean
2025-09-03 8:37 ` [PATCH net-next 3/3] ptp: qoriq: covert to use generic interfaces to set loopback mode Wei Fang
2025-09-04 13:35 ` Vladimir Oltean
2025-09-03 13:41 ` [PATCH net-next 0/3] ptp: add pulse signal loopback support for debugging Richard Cochran
2025-09-03 15:11 ` Vladimir Oltean
2025-09-04 1:55 ` Wei Fang
2025-09-04 13:05 ` Richard Cochran
2025-09-04 13:37 ` Jakub Kicinski
2025-09-05 2:18 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904133011.asqvsucdmuktazc4@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox