Re: [PATCH v3 16/33] arm64: dts: ti: k3-am62-pocketbeagle2: Add missing cfg for TI IPC Firmware

Dhruva Gole
2025-09-08T12:50:59Z

On Sep 05, 2025 at 10:48:29 +0530, Beleswar Padhi wrote:
> The wkup_r5fss0_core0_memory_region is used to store the text/data
> sections of the Device Manager (DM) firmware itself and is necessary for
> platform boot. Whereas the wkup_r5fss0_core0_dma_memory_region is used
> for allocating the Virtio buffers needed for IPC with the DM core which
> could be optional. The labels were incorrectly used in the
> k3-am62-pocketbeagle2.dts file. Correct the firmware memory region label
>
> Currently, only mailbox node is enabled with FIFO assignment for a
> single M4F remote core. Add the missing carveouts for WKUP R5F remote
> processor, and enable that by associating to the above carveout and
> mailbox. This config aligns with other AM62 boards and can be
> refactored out later.
>
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
> Cc: Robert Nelson <robertcnelson@gmail.com>
> Requesting for review/test of this patch
>
> v3: Changelog:
> 1. None
>
> Link to v2:
> https://lore.kernel.org/all/20250823160901.2177841-17-b-padhi@ti.com/
>
> v2: Changelog:
> 1. Re-ordered patch from [PATCH 19/33] to [PATCH v2 16/33].
>
> Link to v1:
> https://lore.kernel.org/all/20250814223839.3256046-20-b-padhi@ti.com/
>
> .../boot/dts/ti/k3-am62-pocketbeagle2.dts | 24 ++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts b/arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts
> index 2eee5f638e0f..729901b2ca10 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dts
> @@ -78,7 +78,13 @@ secure_ddr: optee@9e800000 {
> no-map;
> };
>
> - wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9db00000 {
> + wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9da00000 {

As long as Francesco's comments [1] are addressed,
include my R-by in the next rev:
Reviewed-by: Dhruva Gole <d-gole@ti.com>

[1] https://lore.kernel.org/all/20250821060629.GB7503@francesco-nb

--
Best regards,
Dhruva Gole
Texas Instruments Incorporated