Re: [net-next v19 5/7] net: mtip: Add mtip_switch_{rx|tx} functions to the L2 switch driver

Jakub Kicinski
2025-08-27T19:46:04Z

On Mon, 25 Aug 2025 00:07:34 +0200 Lukasz Majewski wrote:
> static void mtip_switch_tx(struct net_device *dev)
> {
> + struct mtip_ndev_priv *priv = netdev_priv(dev);
> + struct switch_enet_private *fep = priv->fep;
> + unsigned short status;
> + struct sk_buff *skb;
> + struct cbd_t *bdp;

> + } else {
> + dev->stats.tx_packets++;
> + }
> +
> + if (status & BD_ENET_TX_READY)
> + dev_err(&fep->pdev->dev,
> + "Enet xmit interrupt and TX_READY.\n");

per-pkt print, needs rl

> + /* Free the sk buffer associated with this last transmit */
> + dev_consume_skb_irq(skb);

why _irq()? this now runs from NAPI, so it's in BH. Just stick
to dev_comsume_skb_any(), it's the safest choice..