From: Peng Fan <peng.fan@nxp.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Frank Li <frank.li@nxp.com>,
Haibo Chen <haibo.chen@nxp.com>
Cc: linux-can@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Peng Fan <peng.fan@nxp.com>, Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v6 4/9] phy: phy-can-transceiver: Drop the gpio desc check
Date: Tue, 09 Sep 2025 13:40:14 +0800 [thread overview]
Message-ID: <20250909-can-v6-4-1cc30715224c@nxp.com> (raw)
In-Reply-To: <20250909-can-v6-0-1cc30715224c@nxp.com>
gpiod_set_value_cansleep has an internal check on gpio_desc using
'VALIDATE_DESC(desc)', the check before invoking gpiod_set_value_cansleep
could be removed.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/phy/phy-can-transceiver.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
index f06b1df76ada023f432dce892c3346f45397ab54..b7d75a78d9242e2003660a87d2d4c9f784aea523 100644
--- a/drivers/phy/phy-can-transceiver.c
+++ b/drivers/phy/phy-can-transceiver.c
@@ -46,10 +46,8 @@ static int can_transceiver_phy_power_on(struct phy *phy)
return ret;
}
}
- if (can_transceiver_phy->standby_gpio)
- gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
- if (can_transceiver_phy->enable_gpio)
- gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
+ gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
+ gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
return 0;
}
@@ -59,10 +57,8 @@ static int can_transceiver_phy_power_off(struct phy *phy)
{
struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
- if (can_transceiver_phy->standby_gpio)
- gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
- if (can_transceiver_phy->enable_gpio)
- gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
+ gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
+ gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
if (can_transceiver_phy->priv->mux_state)
mux_state_deselect(can_transceiver_phy->priv->mux_state);
--
2.37.1
next prev parent reply other threads:[~2025-09-09 6:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 5:40 [PATCH v6 0/9] phy: phy-can-transceiver: Support TJA1048/TJA1051 Peng Fan
2025-09-09 5:40 ` [PATCH v6 1/9] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048 Peng Fan
2025-09-10 2:33 ` Rob Herring (Arm)
2025-09-09 5:40 ` [PATCH v6 2/9] phy: phy-can-transceiver: Introduce can_transceiver_priv Peng Fan
2025-09-19 19:08 ` Marc Kleine-Budde
2025-09-20 4:37 ` Vincent Mailhol
2025-09-09 5:40 ` [PATCH v6 3/9] phy: phy-can-transceiver: Add dual channel support for TJA1048 Peng Fan
2025-09-19 19:11 ` Marc Kleine-Budde
2025-09-09 5:40 ` Peng Fan [this message]
2025-09-09 5:40 ` [PATCH v6 5/9] phy: phy-can-transceiver: Propagate return value of gpiod_set_value_cansleep Peng Fan
2025-09-19 19:18 ` Marc Kleine-Budde
2025-09-22 4:44 ` Peng Fan
2025-09-09 5:40 ` [PATCH v6 6/9] phy: phy-can-transceiver: Add support for TJA105{1,7} Peng Fan
2025-09-09 5:40 ` [PATCH v6 7/9] arm64: dts: imx95-15x15-evk: Use phys to replace xceiver-supply Peng Fan
2025-09-09 5:40 ` [PATCH v6 8/9] arm64: dts: imx8mp-evk: " Peng Fan
2025-09-09 5:40 ` [PATCH v6 9/9] arm64: dts: imx93-11x11-evk: " Peng Fan
2025-09-18 13:35 ` [PATCH v6 0/9] phy: phy-can-transceiver: Support TJA1048/TJA1051 Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909-can-v6-4-1cc30715224c@nxp.com \
--to=peng.fan@nxp.com \
--cc=a-govindraju@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).