From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C73ECA0FED for ; Tue, 9 Sep 2025 20:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qXkZDlewNbpZE3ToHx+mrYQQMpRfmrNqK/A3pAEXsfU=; b=rN7VIZUIK5BXagx9ykkma9XdHR /mEnwaoNvRGMWt+0bjX3douauWYaaCp1VBQKQqPQslDs8I/9UsUZZt5HOsjMukgt0W5y0Ema8GtdG kivYQ2orSs2oC9CiIznpuhEKRhWLlGmNyL8yfgDQgKHs0Tlyg8Ee8fm3Q8bd5KUYg6v6gUbFCecCD HSICnGtklwFmAuHw0FLamStwQe3RUqBfhCfMth/q2RhkrKKfivoZaSvoPAL7tNcjgH+4Dsa1+h2Iy JzNhnVYYLOPBM+qh77yOyaR52nJ1TP8TJyk7xjgpMDr0lFlndBwB4tO++OnYO1hEOgxBswfyv8FIV pelCaoMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw52e-0000000A4UF-1CH6; Tue, 09 Sep 2025 20:34:16 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw52d-0000000A4TB-0gEn for linux-arm-kernel@lists.infradead.org; Tue, 09 Sep 2025 20:34:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6FE16601F8; Tue, 9 Sep 2025 20:34:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1A85C4CEF4; Tue, 9 Sep 2025 20:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757450054; bh=76+8+D7pi06bGKU9um3GrMq4oi6bCmK0qMW+HC6+J8E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LDJsVozvEFFgKrIMZU6AfkGVSyvQMLiAistgt63IlJZri0e+FJnJE2wR9diGm/2PP 7t9moEgjqM/QzWnawuAuY+uJFPDfJpaFWkDizIXz+5F+vRlBc4oG1tFjjIBQbLSuxX KuvGokd0EoGnYiV3721Xmf2zfvB2fUZLQVabyz+EnSj15SlEalLJSOtTZq94iavTjH dyiNsuGhlR2WN3p4fPQ20iFwMT8AXdmpqB5WkcZeSXt8uINiLr+UmA89nVBuoRyjYP SnZOXNjXUU/DrFtaRuxl4BoQYW+XCRBNo8nXEQleBBl5Q9gpNbbN02kGmN5FFl5O/A Ike58XrZFL2Dg== From: Andreas Kemnade Date: Tue, 09 Sep 2025 22:33:03 +0200 Subject: [PATCH v2 2/3] regulator: sy7636a: add gpios and input regulator MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250909-sy7636-rsrc-v2-2-cfd9f44fd259@kernel.org> References: <20250909-sy7636-rsrc-v2-0-cfd9f44fd259@kernel.org> In-Reply-To: <20250909-sy7636-rsrc-v2-0-cfd9f44fd259@kernel.org> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alistair Francis , Liam Girdwood , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Andreas Kemnade X-Mailer: b4 0.15-dev-50721 X-Developer-Signature: v=1; a=openpgp-sha256; l=2146; i=akemnade@kernel.org; h=from:subject:message-id; bh=76+8+D7pi06bGKU9um3GrMq4oi6bCmK0qMW+HC6+J8E=; b=owGbwMvMwCEm/rzkS6lq2x3G02pJDBkH+q3iZAOMuydkCGxm3dd1nfVIqMk0YZ8+GZO0B4yTs h06f6zvKGVhEONgkBVTZPllreD2SeVZbvDUCHuYOaxMIEMYuDgFYCJbxRn++2+7bBjfpNxg9DX/ ccLzmFk6kqkOZaUJRQ51n5JO3Xy0i5Fhj8vZOX+YmE5m1gtkbzS/6Ovhbb434mrhh3e7U3Y5Pv3 DAAA= X-Developer-Key: i=akemnade@kernel.org; a=openpgp; fpr=EEC0DB858E66C0DA70620AC07DBD6AC74DE29324 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Initialize input regulator and gpios to proper values to have things basically working as well as in the case when these things are hardwired. Signed-off-by: Andreas Kemnade --- drivers/regulator/sy7636a-regulator.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c index 27e3d939b7bb9..551647bc10520 100644 --- a/drivers/regulator/sy7636a-regulator.c +++ b/drivers/regulator/sy7636a-regulator.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -19,6 +20,8 @@ struct sy7636a_data { struct regmap *regmap; struct gpio_desc *pgood_gpio; + struct gpio_desc *en_gpio; + struct gpio_desc *vcom_en_gpio; }; static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev) @@ -98,6 +101,30 @@ static int sy7636a_regulator_probe(struct platform_device *pdev) data->regmap = regmap; data->pgood_gpio = gdp; + ret = devm_regulator_get_enable_optional(&pdev->dev, "vin"); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "failed to get vin regulator\n"); + + data->en_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", + GPIOD_OUT_HIGH); + if (IS_ERR(data->en_gpio)) + return dev_err_probe(&pdev->dev, + PTR_ERR(data->en_gpio), + "failed to get en gpio\n"); + + /* Let VCOM just follow the default power on sequence */ + data->vcom_en_gpio = devm_gpiod_get_optional(&pdev->dev, + "vcom-en", GPIOD_OUT_LOW); + if (IS_ERR(data->vcom_en_gpio)) + return dev_err_probe(&pdev->dev, + PTR_ERR(data->vcom_en_gpio), + "failed to get vcom-en gpio\n"); + + /* if chip was not enabled, give it time to wake up */ + if (data->en_gpio) + usleep_range(2500, 4000); + platform_set_drvdata(pdev, data); ret = regmap_write(regmap, SY7636A_REG_POWER_ON_DELAY_TIME, 0x0); -- 2.39.5