From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1387ACA101F for ; Wed, 10 Sep 2025 08:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/L/ZiHIMyXmxKkiSLCWK4pWAdvwcf6C/7sfjkt+r2Zs=; b=0xEoLOkqdE11m8qdgAseBayWi8 dkQKvzeKA9YOZCpVb+M2gS5lJG675Wc7XAXh3APwo7yLVAVFshOaY661jrVCYY8U2ec1gIInZicAC sPJ57OYrWBeIgI98oN8r2WHcvwyXJdjAOXOCGWjwv+F59k2Lfa8QHOtsrN8C8Dw0Xfs4Ck6Ktl+lx qXeVU7jKg5NLRk5zA5znVOKQACHcHUE63a5MtWsMjTSUS6n6p6fJGiYM1UUJ3kgKsdAdf2KnztHmT 96ejp4dJbOYMk7v+v8OSv+rtMjcC1rKgpOPsxlbKCDfpxXuDhzdcRTPWuW7kXUw4TOhebkQCvvvc4 jAme0NfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwG41-0000000Cs4Q-3Msl; Wed, 10 Sep 2025 08:20:25 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwG3z-0000000Cs3f-0vcf for linux-arm-kernel@lists.infradead.org; Wed, 10 Sep 2025 08:20:24 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-b0419ea6241so70732866b.3 for ; Wed, 10 Sep 2025 01:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757492421; x=1758097221; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/L/ZiHIMyXmxKkiSLCWK4pWAdvwcf6C/7sfjkt+r2Zs=; b=k7QDAykrqpEZ+kuWThsDvjjlqLDEvtl3pfgdH7GB0/89gH3Ey75EeTRUecl8Yo2hT7 AHEt2EHCU5ctdBy3WNFBXpmHHcHIdyQ9IvdI7h8huqY7ptePG0UV0yeOWtkdSBR6hJDO UMfaH53UY4BQbzMHVlYzjEiF8SQgkP/xp8uBvetG/WyChggrIYMz1YH4QZoWYWYNlYnP cxgUtR0JYpn1kcLuNC28bTwwzKd1mQuhNo9mxlLwtPilHsUct5VPGRtdoFuJ7TfHt0IO lQmnV/5K+cOC49m9XADfLpyhOjO90RUQQ7UV7oEzByyydUrV/BfqYYLMdE6URQ4YwHUD HJ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757492421; x=1758097221; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/L/ZiHIMyXmxKkiSLCWK4pWAdvwcf6C/7sfjkt+r2Zs=; b=J5hCEFwyMMZ+nJ/48sUQeaKan604dxaWGzfh+NP/n/biEmyoQPt/TKN+PmIMMZLL9e AivDWbxHx5lfg34FVx76Mr7v7j/AUBNDszeJCfeOLGeJxvH63alAXL+fVsBCt35VNmIl UE5AJU0DIGdjdEraI2rgY2sOEWxST+tM3lkVdWt1/lxMiBoRJtRwVfkfFeKR5UMFYrCo jeQWJhL8KUiaFgrogF1PBqY8kSrO3csLFweJQdjoWfj1bQL2MUpZROCTGsReokIDciFf ve/s1oQlHW3m1OLM17TnS6VVFVbRFSR5d10yo4tFPSs6JlHiSBfevNhbF/01lCU/n/iV EV5A== X-Forwarded-Encrypted: i=1; AJvYcCVu6+fSOmgR+GbSMJjc2W8X9M5PKEZ/B1T/G/zS5bvSDPeS5oT1CGBJccTpXV+KHt8VRj+dRU6rwgwjQXazKTcs@lists.infradead.org X-Gm-Message-State: AOJu0YzXfConArO6EWNM4WdtUZVx9vFH+cwTO6JCwjRCetcNmTJprkgS m+4MzD+PaUkHzL6z7H6sTo6Uyo5vmsf9LYcYc5sszmNRn0nH4oE2Z1DX X-Gm-Gg: ASbGncubxfm1fL9mPl7AHTMPDJy4dy1RVPksalkKCE1TS4rwK6tWvxnmidJcHeic0Yo OXXzhczUMfR3p/8FXMO3KWecpAcPSkNrrkBBzkMcnhdPIsYqI2oqV8lvBKYbF3ysCvXoLi09ABL 515UYCc1shzHkHr72YO0We6xKpe/+m9nu8/H7yZKs6sUTu0VTrZq5IFgwQ8ruyAL+w9GW4r31w9 ei6heo10fzBmgJ3r4KCBQG8yG8AwKrm7W1VbxK21lO4cuqU5ByO+PyFiysF/3LnJS2CVTx3DNGS 49CLRN7miHk0++9PUGYvo1818B6d2TI4N67HnPWMNdhCrNDux4YRqV7XzLPTVHbZ8HXSoeqHd4X kBI+vko12+mGT1A6Yl8peT5IBJw== X-Google-Smtp-Source: AGHT+IEZ6Y8m9czCHfXyGir/VeA90+bvrcMtK66llF0DDBp7AdUVUAE+7FZ2p8xLZJOlSOvaso7zZw== X-Received: by 2002:a17:907:9718:b0:afe:b131:1820 with SMTP id a640c23a62f3a-b04b155985emr758644266b.6.1757492420788; Wed, 10 Sep 2025 01:20:20 -0700 (PDT) Received: from skbuf ([2a02:2f04:d005:3b00:6669:35e7:fc93:9b1c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07833ffa91sm122826066b.91.2025.09.10.01.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 01:20:20 -0700 (PDT) Date: Wed, 10 Sep 2025 11:20:17 +0300 From: Vladimir Oltean To: Christian Marangi Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Heiner Kallweit , Russell King , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Simon Horman , Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v16 10/10] net: dsa: tag_mtk: add comments about Airoha usage of this TAG Message-ID: <20250910082017.hjlq3664xvg5qjub@skbuf> References: <20250909004343.18790-1-ansuelsmth@gmail.com> <20250909004343.18790-1-ansuelsmth@gmail.com> <20250909004343.18790-11-ansuelsmth@gmail.com> <20250909004343.18790-11-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250909004343.18790-11-ansuelsmth@gmail.com> <20250909004343.18790-11-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250910_012023_275816_E122083C X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 09, 2025 at 02:43:41AM +0200, Christian Marangi wrote: > Add comments about difference between Airoha AN8855 and Mediatek tag > bitmap. > > Airoha AN88555 doesn't support controlling SA learning and Leaky VLAN Is there an extra 5 in AN88555? > from tag. Although these bits are not used (and even not defined for > Leaky VLAN), it's worth to add comments for these difference to prevent > any kind of regression in the future if ever these bits will be used. > > Signed-off-by: Christian Marangi > --- > net/dsa/tag_mtk.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/dsa/tag_mtk.c b/net/dsa/tag_mtk.c > index b670e3c53e91..ac3f956abe39 100644 > --- a/net/dsa/tag_mtk.c > +++ b/net/dsa/tag_mtk.c > @@ -18,6 +18,9 @@ > #define MTK_HDR_XMIT_TAGGED_TPID_88A8 2 > #define MTK_HDR_RECV_SOURCE_PORT_MASK GENMASK(2, 0) > #define MTK_HDR_XMIT_DP_BIT_MASK GENMASK(5, 0) > +/* AN8855 doesn't support SA_DIS and Leaky VLAN > + * control in tag as these bits doesn't exist. > + */ I think it would be good to present the AN8855 tag using a different string, so that libpcap knows it shouldn't decode these bits. The code can be reused for now. > #define MTK_HDR_XMIT_SA_DIS BIT(6) > > static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb, > -- > 2.51.0 >