Re: [PATCH v2 2/2] perf vendor events arm64 AmpereOne: Fix typos in metrics' descriptions

James Clark
2025-09-11T08:27:00Z

On 10/09/2025 8:52 pm, Ilkka Koskinen wrote:
> While fixing a typo in "l1d_cache_access_prefetches" in AmpereOneX,
> a few other typos were found in metrics' descriptions too. While AmpereOne
> doesn't have the metric, it did have the typos in the descriptions.
>
> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> ---
> .../pmu-events/arch/arm64/ampere/ampereone/metrics.json | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json
> index afcdad58ef89..324104438e78 100644
> --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json
> @@ -113,7 +113,7 @@
> {
> "MetricName": "load_store_spec_rate",
> "MetricExpr": "((LDST_SPEC / INST_SPEC) * 100)",
> - "BriefDescription": "The rate of load or store instructions speculatively executed to overall instructions speclatively executed",
> + "BriefDescription": "The rate of load or store instructions speculatively executed to overall instructions speculatively executed",
> "MetricGroup": "Operation_Mix",
> "ScaleUnit": "1percent of operations"
> },
> @@ -132,7 +132,7 @@
> {
> "MetricName": "pc_write_spec_rate",
> "MetricExpr": "((PC_WRITE_SPEC / INST_SPEC) * 100)",
> - "BriefDescription": "The rate of software change of the PC speculatively executed to overall instructions speclatively executed",
> + "BriefDescription": "The rate of software change of the PC speculatively executed to overall instructions speculatively executed",
> "MetricGroup": "Operation_Mix",
> "ScaleUnit": "1percent of operations"
> },
> @@ -195,14 +195,14 @@
> {
> "MetricName": "stall_frontend_cache_rate",
> "MetricExpr": "((STALL_FRONTEND_CACHE / CPU_CYCLES) * 100)",
> - "BriefDescription": "Proportion of cycles stalled and no ops delivered from frontend and cache miss",
> + "BriefDescription": "Proportion of cycles stalled and no operations delivered from frontend and cache miss",
> "MetricGroup": "Stall",
> "ScaleUnit": "1percent of cycles"
> },
> {
> "MetricName": "stall_frontend_tlb_rate",
> "MetricExpr": "((STALL_FRONTEND_TLB / CPU_CYCLES) * 100)",
> - "BriefDescription": "Proportion of cycles stalled and no ops delivered from frontend and TLB miss",
> + "BriefDescription": "Proportion of cycles stalled and no operations delivered from frontend and TLB miss",
> "MetricGroup": "Stall",
> "ScaleUnit": "1percent of cycles"
> },

Reviewed-by: James Clark <james.clark@linaro.org>