Re: [PATCH v2 1/3] dt-bindings: mfd: sy7636a: Add missing gpio pins and supply

[Andreas Kemnade <andreas@kemnade.info>]

Am Wed, 10 Sep 2025 11:45:35 -0400
schrieb Frank Li <Frank.li@nxp.com>:

> On Tue, Sep 09, 2025 at 10:33:02PM +0200, Andreas Kemnade wrote:
> > To be able to fully describe how the SY7636A is connected to the system,
> > add properties for the EN and VCOM_EN pins. To squeeze out every bit
> > of unused current, in many devices it is possible to power off the
> > complete chip. Add an input regulator to allow that.
> >
> > Signed-off-by: Andreas Kemnade <akemnade@kernel.org>
> > ---
> >  .../devicetree/bindings/mfd/silergy,sy7636a.yaml         | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
> > index ee0be32ac0204..054b97dd0c5c7 100644
> > --- a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
> > @@ -32,6 +32,22 @@ properties:
> >        Specifying the power good GPIOs.
> >      maxItems: 1
> >
> > +  enable-gpios:
> > +    description:
> > +      If EN pin is not hardwired, specify it here to have it set up.  
> 
> Need descript function of enabel-gpios, you can ref data sheet sy7636a.
> 
> "enable-gpios" is good self documented by property name, needn't
> description at all.
> 
What you are saying is contradictory. I would prefer to have a mapping
crystal clear visible between properties and pins. That is why I want
that description. I remember I have got the datasheet from the company
site with registration without acknowledging any terms. But I do not
find that site.

> > +    maxItems: 1
> > +
> > +  vcom-en-gpios:
> > +    description:
> > +      If VCOM_EN pin is not hardwired, specify it here to have it set up.
> > +    maxItems: 1
> > +
> > +  vin-supply:
> > +    description:
> > +      Supply for the chip. Some vendor kernels and devicetrees declare this
> > +      as a GPIO named "pwrall" which does not exist in the datasheet,
> > +      disabling it makes the chip disappear on the bus.
> > +  
> 
> The same here, descript function. such as power supply for whole chip.

I think it is useful what I am writing here. DT maintainers are
apparently fine with it, since it has earned a Reviewed-By.

Regards,
Andreas