* [PATCH] gpio: nomadik: fix the debugfs helper stub
@ 2025-09-15 9:10 Bartosz Golaszewski
2025-09-15 13:27 ` Linus Walleij
2025-09-17 8:56 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-09-15 9:10 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-arm-kernel, linux-gpio, linux-kernel, Bartosz Golaszewski,
kernel test robot
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Commit ddeb66d2cb10 ("gpio: nomadik: don't print out global GPIO numbers
in debugfs callbacks") failed to also update the stub of the debugfs
helper for !CONFIG_DEBUG_FS. Fix the resulting build failure.
Fixes: ddeb66d2cb10 ("gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509132232.12viPUPB-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
include/linux/gpio/gpio-nomadik.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/gpio/gpio-nomadik.h b/include/linux/gpio/gpio-nomadik.h
index 7ba53b499e16..592a774a53cd 100644
--- a/include/linux/gpio/gpio-nomadik.h
+++ b/include/linux/gpio/gpio-nomadik.h
@@ -268,8 +268,7 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev,
static inline void nmk_gpio_dbg_show_one(struct seq_file *s,
struct pinctrl_dev *pctldev,
struct gpio_chip *chip,
- unsigned int offset,
- unsigned int gpio)
+ unsigned int offset)
{
}
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: nomadik: fix the debugfs helper stub
2025-09-15 9:10 [PATCH] gpio: nomadik: fix the debugfs helper stub Bartosz Golaszewski
@ 2025-09-15 13:27 ` Linus Walleij
2025-09-17 8:56 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2025-09-15 13:27 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linux-arm-kernel, linux-gpio, linux-kernel, Bartosz Golaszewski,
kernel test robot
On Mon, Sep 15, 2025 at 11:10 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Commit ddeb66d2cb10 ("gpio: nomadik: don't print out global GPIO numbers
> in debugfs callbacks") failed to also update the stub of the debugfs
> helper for !CONFIG_DEBUG_FS. Fix the resulting build failure.
>
> Fixes: ddeb66d2cb10 ("gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509132232.12viPUPB-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: nomadik: fix the debugfs helper stub
2025-09-15 9:10 [PATCH] gpio: nomadik: fix the debugfs helper stub Bartosz Golaszewski
2025-09-15 13:27 ` Linus Walleij
@ 2025-09-17 8:56 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-09-17 8:56 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Bartosz Golaszewski, linux-arm-kernel, linux-gpio, linux-kernel,
kernel test robot
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Mon, 15 Sep 2025 11:10:07 +0200, Bartosz Golaszewski wrote:
> Commit ddeb66d2cb10 ("gpio: nomadik: don't print out global GPIO numbers
> in debugfs callbacks") failed to also update the stub of the debugfs
> helper for !CONFIG_DEBUG_FS. Fix the resulting build failure.
>
>
Applied, thanks!
[1/1] gpio: nomadik: fix the debugfs helper stub
https://git.kernel.org/brgl/linux/c/0b1619c38600fc06c73b1f59c64af0b7df08fc2c
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-17 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-15 9:10 [PATCH] gpio: nomadik: fix the debugfs helper stub Bartosz Golaszewski
2025-09-15 13:27 ` Linus Walleij
2025-09-17 8:56 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).