From: Conor Dooley <conor@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, Steen.Hegelund@microchip.com,
daniel.machon@microchip.com, UNGLinuxDriver@microchip.com,
lars.povlsen@microchip.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, luka.perkov@sartura.hr,
benjamin.ryzman@canonical.com
Subject: Re: [PATCH 2/2] reset: sparx5: add LAN969x support
Date: Wed, 17 Sep 2025 18:37:46 +0100 [thread overview]
Message-ID: <20250917-backfield-saint-98ade84229e5@spud> (raw)
In-Reply-To: <20250917111323.60781-2-robert.marko@sartura.hr>
[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]
On Wed, Sep 17, 2025 at 01:12:36PM +0200, Robert Marko wrote:
> LAN969x uses the same reset configuration as LAN966x so lets add support
> for it as well.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> drivers/reset/Kconfig | 2 +-
> drivers/reset/reset-microchip-sparx5.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 78b7078478d4..35cb84d1de4e 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -170,7 +170,7 @@ config RESET_LPC18XX
>
> config RESET_MCHP_SPARX5
> tristate "Microchip Sparx5 reset driver"
> - depends on ARCH_SPARX5 || SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
> + depends on ARCH_SPARX5 || ARCH_LAN969X ||SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
^ missing space here.
> default y if SPARX5_SWITCH
> select MFD_SYSCON
> help
> diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset-microchip-sparx5.c
> index 6d3e75b33260..28ad8f1298a0 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -198,6 +198,9 @@ static const struct of_device_id mchp_sparx5_reset_of_match[] = {
> }, {
> .compatible = "microchip,lan966x-switch-reset",
> .data = &reset_props_lan966x,
> + }, {
> + .compatible = "microchip,lan969x-switch-reset",
> + .data = &reset_props_lan966x,
These are identically handled, a fallback compatible will suffice.
> },
> { }
> };
> --
> 2.51.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-09-17 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 11:12 [PATCH 1/2] dt-bindings: reset: microchip: Add LAN969x support Robert Marko
2025-09-17 11:12 ` [PATCH 2/2] reset: sparx5: add " Robert Marko
2025-09-17 17:37 ` Conor Dooley [this message]
2025-09-18 8:24 ` Daniel Machon
2025-09-17 17:38 ` [PATCH 1/2] dt-bindings: reset: microchip: Add " Conor Dooley
2025-09-18 11:45 ` Robert Marko
2025-09-18 15:15 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917-backfield-saint-98ade84229e5@spud \
--to=conor@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=benjamin.ryzman@canonical.com \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=p.zabel@pengutronix.de \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox