From: Vladimir Oltean <olteanv@gmail.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Simon Horman <horms@kernel.org>,
"Chester A. Unal" <chester.a.unal@arinc9.com>,
Daniel Golle <daniel@makrotopia.org>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v18 4/8] net: dsa: tag_mtk: add Airoha variant usage of this TAG
Date: Wed, 17 Sep 2025 13:03:53 +0300 [thread overview]
Message-ID: <20250917100353.dbjeh5eibkqdpz75@skbuf> (raw)
In-Reply-To: <68ca827c.050a0220.11f9b4.a3f0@mx.google.com>
On Wed, Sep 17, 2025 at 11:42:13AM +0200, Christian Marangi wrote:
> On Wed, Sep 17, 2025 at 12:35:41PM +0300, Vladimir Oltean wrote:
> > Unless the few tens of bytes saved matter on OpenWRT, I think this is
> > overkill (and you went too far with my previous suggestion).
> > Two Kconfig options are unnecessary from a maintainance point of view
> > (and config NET_DSA_AN8855 isn't even selecting the correct one!).
> > I suggest you register both tag drivers as part of CONFIG_NET_DSA_TAG_MTK,
> > at least until the differences increase to justify a new option.
> >
>
> Ok, was following the pattern done by the other. Will drop the
> additional kconfig.
tag_ocelot.c is another example which registers 2 taggers under the same
Kconfig option.
next prev parent reply other threads:[~2025-09-17 10:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 10:45 [net-next PATCH v18 0/8] net: dsa: Add Airoha AN8855 support Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 1/8] dt-bindings: net: dsa: Document support for Airoha AN8855 DSA Switch Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 2/8] dt-bindings: net: Document support for AN8855 Switch Internal PHY Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 3/8] dt-bindings: mfd: Document support for Airoha AN8855 Switch SoC Christian Marangi
2025-09-15 17:01 ` Rob Herring (Arm)
2025-09-15 20:19 ` Rob Herring
2025-09-15 23:53 ` Christian Marangi
2025-09-17 10:37 ` Vladimir Oltean
2025-09-15 10:45 ` [net-next PATCH v18 4/8] net: dsa: tag_mtk: add Airoha variant usage of this TAG Christian Marangi
2025-09-17 9:35 ` Vladimir Oltean
2025-09-17 9:42 ` Christian Marangi
2025-09-17 10:03 ` Vladimir Oltean [this message]
2025-09-15 10:45 ` [net-next PATCH v18 6/8] mfd: an8855: Add support for Airoha AN8855 Switch MFD Christian Marangi
2025-09-17 9:46 ` Vladimir Oltean
2025-09-17 10:11 ` Vladimir Oltean
2025-09-15 10:45 ` [net-next PATCH v18 7/8] net: phy: Add Airoha AN8855 Internal Switch Gigabit PHY Christian Marangi
2025-09-15 10:45 ` [net-next PATCH v18 8/8] MAINTAINERS: add myself as maintainer for AN8855 Christian Marangi
2025-09-17 9:28 ` [net-next PATCH v18 0/8] net: dsa: Add Airoha AN8855 support Vladimir Oltean
2025-09-17 9:40 ` Christian Marangi
2025-09-17 10:10 ` Vladimir Oltean
[not found] ` <20250915104545.1742-6-ansuelsmth@gmail.com>
2025-09-17 10:43 ` [net-next PATCH v18 5/8] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917100353.dbjeh5eibkqdpz75@skbuf \
--to=olteanv@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=chester.a.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox