From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AC99CA0EE8 for ; Wed, 17 Sep 2025 10:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3Yyh8Hkqs7GqsXIM+okxGaGUnlxOgHFmx9rSotm4MB8=; b=384Y6C864FAF2Jwzw8le/Mzrmp sOJbwOEHL4crD4b5xj/u/ZM9/gYIM6WiECCNWGZImliG/l/BDtG/4ncbRF1eEPFmIR3nKaEvKd76i nsdKZ0J21SVIMutdMoiV6tO+H0xy4j6qbloTUjKRQ3mxyctS3XXDDxe1T5VIWXHtnW1wxW/ZsquQx AQ5o5eAhk6zwPBHpsd/HC/aHBVPjqR34KYESEAFFg0+uKAa2qI6RaF/CAh/KPl3YTPR3XaPZP1tra qX8s7VvOBVTcPDcEFo2nZZCAOwWViK1qT0gmPDncsxYwlsnPizpJTAG0vIThuG/U7EOhClufa2i1O 04j6hOdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uypdN-0000000B1d9-1yrp; Wed, 17 Sep 2025 10:43:33 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uypdK-0000000B1cN-3B7L for linux-arm-kernel@lists.infradead.org; Wed, 17 Sep 2025 10:43:31 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-b04260d72bfso115213466b.3 for ; Wed, 17 Sep 2025 03:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758105809; x=1758710609; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3Yyh8Hkqs7GqsXIM+okxGaGUnlxOgHFmx9rSotm4MB8=; b=jhw1PoeBza1b8+1CdUUhkCl8zf0ricbyVBEiYShek5PbblAhxnZldOKMSSku6W/jJO IzMbmE54LLvSugkClGBe/XM2lARFSBTI724oPLUWhheECkwrZUzXDXRdZ/frTd4Z/xQ1 bFuXvypN0WMWX+RgbyTDzvVB4KmuWk55p5O4Nr7SsDVWs2PzFI3ki4MPB2ee7uz6YvxA G2VcG2K6Jevh0TH8Kn+C6aIlY3tnMKjjLteSgiN5QLEEJf7+gNgoZUORuyzd1uTLqiWN P/sSr3qrOxs0oISOHmv8VcLfwEJEPoubZuvx95hMhn9hFvmQMEA/7cnDcqUtXCWO2n1x DNCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758105809; x=1758710609; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3Yyh8Hkqs7GqsXIM+okxGaGUnlxOgHFmx9rSotm4MB8=; b=GmUClf1fPAs7V4lmbAGprvo8eLPQOpNAN7Wgetwdkz+1+v6MCTk7L1K/4oCswCqZLx eyrMTf7be3ium7YbO3B8kVISArI/e00IDUHlCXJZklv+1ryx3ODWkU2hzAosqexDYJ+c K85ytyz8aS79rAFxbEUhzgvYM/6QJpG0v0ElhWCpGzaScR0B/OBgRavD/h4sl10BncKy wtiEjNVLdYeulK/fZ6eH0DhDg9P7bwKkbIe4QGLSJJfDaXudzGsVFZceI0yNUBm4SLw7 0eBPA+VsMdL6btHpL7+0b00oKwWUAiNnBy5/D2bQZlDQfwKHR1earju9JttEqIbS2NtC tM9A== X-Forwarded-Encrypted: i=1; AJvYcCWDLiDs9yaW03T5bLp+7Gn4laoApe5mo5Yg61AKurpyksjelmaBlOBwCO7Xa3m1Pss6btM6GhJaj4IuUm+cxWeO@lists.infradead.org X-Gm-Message-State: AOJu0Yz/GP8/Y5pb9iBzmDZF46zx/0WTo+wKW5jeCK/+/B8cGkv0y6iq 21IbwgU9wwh4TN6mHnYDmEg9tPMNxcptKsztG3Z9c3jIdXFYLssapaEG X-Gm-Gg: ASbGncsDqEnK0Eo4csPhMfPxTqKdiuuK34VvYoTsJ6YSQSNEWT5WE0AVb7y+zXRonKR G9amophrTNWUMsL4cvf/gSb9yxlatwKfVgZB3x+HbStc0NO+597SDH8IJn5s1P09U5J976LwC+z Gj+D4Z2A5hTYvdSvWl/6xjSgdiZIjy7NCSTFJwodnSzypz2MH3GzHrB3/mMJT70+DvxrTMwWUAQ mqHgily3qsV+EvE7XzU3JgKh8u0PQQ8mG3qOQHvTuqLpV3xrVHeHc6FmH79Bo2xnfVuc8PIY3fE lfAU0sBHCpLaszVbB9zoAWxm2jCppIt/TDVh8Xpy7AVqVB9I5F2N/B/RP/N3UEfGlIZ1CGzqZh3 nF8mC/rU/1iROSaA= X-Google-Smtp-Source: AGHT+IF0bGu8coGo8S13flYMunWY6PoCzFUDuD7l8SY41Vuc7seAVPH3vRAusBx3pRQ3RA9KkKbEpA== X-Received: by 2002:a17:907:7e93:b0:b04:669f:e70f with SMTP id a640c23a62f3a-b1bb7f2a4f5mr112464766b.2.1758105808719; Wed, 17 Sep 2025 03:43:28 -0700 (PDT) Received: from skbuf ([2a02:2f04:d005:3b00:8bcc:b603:fee7:a273]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07c6110c27sm1132722066b.66.2025.09.17.03.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 03:43:28 -0700 (PDT) Date: Wed, 17 Sep 2025 13:43:25 +0300 From: Vladimir Oltean To: Christian Marangi Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , Simon Horman , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v18 5/8] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver Message-ID: <20250917104325.j5je2jtachee7thw@skbuf> References: <20250915104545.1742-1-ansuelsmth@gmail.com> <20250915104545.1742-6-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250915104545.1742-6-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250917_034330_846376_FE369ED8 X-CRM114-Status: GOOD ( 18.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 15, 2025 at 12:45:41PM +0200, Christian Marangi wrote: > +static const struct an8855_mib_desc an8855_mib[] = { > + MIB_DESC(1, AN8855_PORT_MIB_TX_DROP, "TxDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_TX_CRC_ERR, "TxCrcErr"), > + MIB_DESC(1, AN8855_PORT_MIB_TX_COLLISION, "TxCollision"), > + MIB_DESC(1, AN8855_PORT_MIB_TX_OVERSIZE_DROP, "TxOversizeDrop"), > + MIB_DESC(2, AN8855_PORT_MIB_TX_BAD_PKT_BYTES, "TxBadPktBytes"), > + MIB_DESC(1, AN8855_PORT_MIB_RX_DROP, "RxDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_RX_FILTERING, "RxFiltering"), > + MIB_DESC(1, AN8855_PORT_MIB_RX_CRC_ERR, "RxCrcErr"), > + MIB_DESC(1, AN8855_PORT_MIB_RX_CTRL_DROP, "RxCtrlDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_RX_INGRESS_DROP, "RxIngressDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_RX_ARL_DROP, "RxArlDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_FLOW_CONTROL_DROP, "FlowControlDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_WRED_DROP, "WredDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_MIRROR_DROP, "MirrorDrop"), > + MIB_DESC(2, AN8855_PORT_MIB_RX_BAD_PKT_BYTES, "RxBadPktBytes"), > + MIB_DESC(1, AN8855_PORT_MIB_RXS_FLOW_SAMPLING_PKT_DROP, "RxsFlowSamplingPktDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_RXS_FLOW_TOTAL_PKT_DROP, "RxsFlowTotalPktDrop"), > + MIB_DESC(1, AN8855_PORT_MIB_PORT_CONTROL_DROP, "PortControlDrop"), > +}; > + > +static int > +an8855_mib_init(struct an8855_priv *priv) > +{ > + int ret; > + > + ret = regmap_write(priv->regmap, AN8855_MIB_CCR, > + AN8855_CCR_MIB_ENABLE); > + if (ret) > + return ret; > + > + return regmap_write(priv->regmap, AN8855_MIB_CCR, > + AN8855_CCR_MIB_ACTIVATE); > +} > + > +static void an8855_get_strings(struct dsa_switch *ds, int port, > + u32 stringset, uint8_t *data) > +{ > + int i; > + > + if (stringset != ETH_SS_STATS) > + return; > + > + for (i = 0; i < ARRAY_SIZE(an8855_mib); i++) > + ethtool_puts(&data, an8855_mib[i].name); Same feedback as for yt921x. For new drivers we want in unstructured ethtool -S only those statistics which are not exposed through standard variants (to force the adoption of the new interfaces). > +} > + > +static void an8855_read_port_stats(struct an8855_priv *priv, int port, > + u32 offset, u8 size, uint64_t *data) > +{ > + u32 val, reg = AN8855_PORT_MIB_COUNTER(port) + offset; > + > + regmap_read(priv->regmap, reg, &val); > + *data = val; > + > + if (size == 2) { > + regmap_read(priv->regmap, reg + 4, &val); > + *data |= (u64)val << 32; > + } > +} > + > +static void an8855_get_ethtool_stats(struct dsa_switch *ds, int port, > + uint64_t *data) > +{ > + struct an8855_priv *priv = ds->priv; > + const struct an8855_mib_desc *mib; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(an8855_mib); i++) { > + mib = &an8855_mib[i]; > + > + an8855_read_port_stats(priv, port, mib->offset, mib->size, > + data + i); > + } > +} > + > +static int an8855_get_sset_count(struct dsa_switch *ds, int port, > + int sset) > +{ > + if (sset != ETH_SS_STATS) > + return 0; > + > + return ARRAY_SIZE(an8855_mib); > +} > + > +static void an8855_get_eth_mac_stats(struct dsa_switch *ds, int port, > + struct ethtool_eth_mac_stats *mac_stats) > +{ > + struct an8855_priv *priv = ds->priv; > + > + /* MIB counter doesn't provide a FramesTransmittedOK but instead > + * provide stats for Unicast, Broadcast and Multicast frames separately. > + * To simulate a global frame counter, read Unicast and addition Multicast > + * and Broadcast later > + */ > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_UNICAST, 1, > + &mac_stats->FramesTransmittedOK); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_SINGLE_COLLISION, 1, > + &mac_stats->SingleCollisionFrames); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_MULTIPLE_COLLISION, 1, > + &mac_stats->MultipleCollisionFrames); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_UNICAST, 1, > + &mac_stats->FramesReceivedOK); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_BYTES, 2, > + &mac_stats->OctetsTransmittedOK); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_ALIGN_ERR, 1, > + &mac_stats->AlignmentErrors); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_DEFERRED, 1, > + &mac_stats->FramesWithDeferredXmissions); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_LATE_COLLISION, 1, > + &mac_stats->LateCollisions); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_EXCESSIVE_COLLISION, 1, > + &mac_stats->FramesAbortedDueToXSColls); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_BYTES, 2, > + &mac_stats->OctetsReceivedOK); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_MULTICAST, 1, > + &mac_stats->MulticastFramesXmittedOK); > + mac_stats->FramesTransmittedOK += mac_stats->MulticastFramesXmittedOK; > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_BROADCAST, 1, > + &mac_stats->BroadcastFramesXmittedOK); > + mac_stats->FramesTransmittedOK += mac_stats->BroadcastFramesXmittedOK; > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_MULTICAST, 1, > + &mac_stats->MulticastFramesReceivedOK); > + mac_stats->FramesReceivedOK += mac_stats->MulticastFramesReceivedOK; > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_BROADCAST, 1, > + &mac_stats->BroadcastFramesReceivedOK); > + mac_stats->FramesReceivedOK += mac_stats->BroadcastFramesReceivedOK; > +} > + > +static const struct ethtool_rmon_hist_range an8855_rmon_ranges[] = { > + { 0, 64 }, > + { 65, 127 }, > + { 128, 255 }, > + { 256, 511 }, > + { 512, 1023 }, > + { 1024, 1518 }, > + { 1519, AN8855_MAX_MTU }, > + {} > +}; > + > +static void an8855_get_rmon_stats(struct dsa_switch *ds, int port, > + struct ethtool_rmon_stats *rmon_stats, > + const struct ethtool_rmon_hist_range **ranges) > +{ > + struct an8855_priv *priv = ds->priv; > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_UNDER_SIZE_ERR, 1, > + &rmon_stats->undersize_pkts); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_OVER_SZ_ERR, 1, > + &rmon_stats->oversize_pkts); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_FRAG_ERR, 1, > + &rmon_stats->fragments); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_JABBER_ERR, 1, > + &rmon_stats->jabbers); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PKT_SZ_64, 1, > + &rmon_stats->hist[0]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PKT_SZ_65_TO_127, 1, > + &rmon_stats->hist[1]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PKT_SZ_128_TO_255, 1, > + &rmon_stats->hist[2]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PKT_SZ_256_TO_511, 1, > + &rmon_stats->hist[3]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PKT_SZ_512_TO_1023, 1, > + &rmon_stats->hist[4]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PKT_SZ_1024_TO_1518, 1, > + &rmon_stats->hist[5]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PKT_SZ_1519_TO_MAX, 1, > + &rmon_stats->hist[6]); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PKT_SZ_64, 1, > + &rmon_stats->hist_tx[0]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PKT_SZ_65_TO_127, 1, > + &rmon_stats->hist_tx[1]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PKT_SZ_128_TO_255, 1, > + &rmon_stats->hist_tx[2]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PKT_SZ_256_TO_511, 1, > + &rmon_stats->hist_tx[3]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PKT_SZ_512_TO_1023, 1, > + &rmon_stats->hist_tx[4]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PKT_SZ_1024_TO_1518, 1, > + &rmon_stats->hist_tx[5]); > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PKT_SZ_1519_TO_MAX, 1, > + &rmon_stats->hist_tx[6]); > + > + *ranges = an8855_rmon_ranges; > +} > + > +static void an8855_get_eth_ctrl_stats(struct dsa_switch *ds, int port, > + struct ethtool_eth_ctrl_stats *ctrl_stats) > +{ > + struct an8855_priv *priv = ds->priv; > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_TX_PAUSE, 1, > + &ctrl_stats->MACControlFramesTransmitted); > + > + an8855_read_port_stats(priv, port, AN8855_PORT_MIB_RX_PAUSE, 1, > + &ctrl_stats->MACControlFramesReceived); > +}