From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E11CCAC59A for ; Fri, 19 Sep 2025 15:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kVkUIo4dQVT4SOntZ8cZ5+tgvO9vk9zBQavLp3x8Y90=; b=Z0Y74Cdmk9ZmifDTlKmSSJn5jq ld+TY/JDm66e1obhlADIf5Q15PQAaWIgVbnGONXUvVYxVlAomVREx5HPieFzm+tU/LZ1jHUkSYshN bNsHBAggQn2jOxwzJ6qQUwny88Agb4VIhhY4z2AmAcsFPEXilaP71csZ2U9fuCV2r4iJtSVhGGqNR 72CTb4ncTyzD9nJN1hNdyapr1f7P6R9Rh6s0MjKFcBfhEMuHSX6DfaDmk0LMaWx6tKEHDgGM7wToa 0SdgZ/gtHdnCXRrbqygarbgmPPDg9uoySIK6V9HaAhYX7SBRVXbj3nbBaVoQ/LfzcK6y27+VBlrlE tDZ/WvZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uzcjN-00000003H6h-1WZ8; Fri, 19 Sep 2025 15:09:01 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uzcjK-00000003H4n-0fuF for linux-arm-kernel@lists.infradead.org; Fri, 19 Sep 2025 15:09:00 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 855471A0F07; Fri, 19 Sep 2025 15:08:52 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 55895606A8; Fri, 19 Sep 2025 15:08:52 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C38A0102F1D79; Fri, 19 Sep 2025 17:08:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1758294530; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=kVkUIo4dQVT4SOntZ8cZ5+tgvO9vk9zBQavLp3x8Y90=; b=U826dbrfoYbVfNFx4Z8CHR+MxQoqEzgV6pb0s//raOyvHWb+CQ0/CKQ/dvTw3eNBDb9BPb YXZdxuRY6vu3bawS6Tje2jgmpPLMKsT2HtUB/94Pm6vym/Dk6voLAxKbxJ99iDghwh67TQ 8NBtm1FzWB9pywWDF1xjX5IQFCA13ZXh+ost/xZ51KAXR2V3X44lQNmgFJJexbXTwG7ACf McDDbYEbyeudr/9TpAMH8iXWVGDFn2dSle/rGdtMiRcZdDI9+xSyG45ewNpQlB/MxyB4d1 zTQFL5Q1gGkaGrJ27v+uP1jKiK8KBld0WRlbQ6IAyT9U3oRWGv6aT32Z5MxPag== Date: Fri, 19 Sep 2025 17:08:24 +0200 From: Luca Ceresoli To: Shengjiu Wang Cc: Maxime Ripard , Shengjiu Wang , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, lumag@kernel.org, dianders@chromium.org, cristian.ciocaltea@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, victor.liu@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, devicetree@vger.kernel.org, l.stach@pengutronix.de, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org Subject: Re: [PATCH v5 4/7] drm/bridge: dw-hdmi: Add API dw_hdmi_set_sample_iec958() for iec958 format Message-ID: <20250919170824.63df1d6e@booty> In-Reply-To: References: <20250821073131.2550798-1-shengjiu.wang@nxp.com> <20250821073131.2550798-5-shengjiu.wang@nxp.com> <20250901185208.394cd162@booty> <20250909-omniscient-honeybee-of-development-adca8a@houat> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250919_080858_326283_4CAAE078 X-CRM114-Status: GOOD ( 25.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shengjiu, On Fri, 19 Sep 2025 11:43:05 +0800 Shengjiu Wang wrote: > Hi Luca >=20 > On Wed, Sep 10, 2025 at 6:29=E2=80=AFPM Shengjiu Wang wrote: > > > > Hi > > > > On Tue, Sep 9, 2025 at 2:39=E2=80=AFPM Maxime Ripard wrote: =20 > > > > > > Hi, > > > > > > On Wed, Sep 03, 2025 at 06:41:05PM +0800, Shengjiu Wang wrote: =20 > > > > On Tue, Sep 2, 2025 at 12:52=E2=80=AFAM Luca Ceresoli wrote: =20 > > > > > > > > > > Hello Shengjiu, > > > > > > > > > > On Thu, 21 Aug 2025 15:31:28 +0800 > > > > > Shengjiu Wang wrote: > > > > > =20 > > > > > > Add API dw_hdmi_set_sample_iec958() for IEC958 format because a= udio device > > > > > > driver needs IEC958 information to configure this specific sett= ing. > > > > > > > > > > > > Signed-off-by: Shengjiu Wang > > > > > > Acked-by: Liu Ying =20 > > > > > > > > > > [...] > > > > > =20 > > > > > > +void dw_hdmi_set_sample_iec958(struct dw_hdmi *hdmi, unsigned = int iec958) > > > > > > +{ > > > > > > + mutex_lock(&hdmi->audio_mutex); > > > > > > + hdmi->sample_iec958 =3D iec958; > > > > > > + mutex_unlock(&hdmi->audio_mutex); > > > > > > +} =20 > > > > > > > > > > Apologies for jumping in the discussion as late as in v5, but I n= oticed > > > > > this patch and I was wondering whether this mutex_lock/unlock() is > > > > > really needed, as you're copying an int. =20 > > > > > > > > Thanks for your comments. > > > > > > > > Seems it is not necessary to add mutex here. I just follow the code= as > > > > other similar functions. I will send a new version to update it. = =20 > > > > > > Let's not be smart about it. Next thing you know, someone will add > > > another field in there that would absolutely require a mutex and now > > > you're not race free anymore. > > > > > > Unless there's a real concern, the mutex must stay. > > > =20 > > > > Ok, thanks for comments. Then Patch v6 need to be dropped. > > > > Is there any other comments for this Patch v5? > > If no, can this series be accepted? > > =20 >=20 > Can we have a conclusion that keeps the mutex as Maxime's comments? If Maxime wants the mutex to be kept, it's fine. Luca --=20 Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com