From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B2CCCAC592 for ; Mon, 22 Sep 2025 17:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jx43FQt04RRWWbJPKAwMaQfiDNcLhpTBUoXKCajpCo8=; b=AmcWV8WhBA5PbygkLueuwOh/pp ONqVS7mL4rG7bOPy9D4TgcQQ0nr2gNCx4LqUPHV5CsWFNaR4M4KDCA8ZDqLw0AM0NIvRXuyt2eyqs N74g+4+1Wyzy1HJnr/SPqIPt3lq9nuEUqwsEKfNzd/s0Ee4MnRnIzCyMORcXKl0HkMWKE8jOTLeAY 5/JnFBY+LtYc+ito4duIhqhxUrLA9I8Jn88ViXUL+JpWWWTrNI6aiYaLQTPYEAXAbjuSptUHWSAG5 z5/seA1f6TzWeFFaNK24mnNqk+A+kQg9i2GQYYIT0QtHtmrEu7vdVLayR058rbatcdUJs+dLffI40 YSPTp+3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0k4Y-0000000B4bI-25P2; Mon, 22 Sep 2025 17:11:30 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0k4W-0000000B4aU-3L0k; Mon, 22 Sep 2025 17:11:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1041C44390; Mon, 22 Sep 2025 17:11:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD1D2C4CEF0; Mon, 22 Sep 2025 17:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758561087; bh=bkrPLPzrm50ZFvPyvUr+rRE9QdrzUX2GlPLdWhgO5e0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FE3mFOqUGfy67eZHcQhnavXPi3/2dG8CNj1tgOSxuZ97CpKreeWOJ5ZbrY7VTvgpb NNID9ISM8lVMxAhQZHkjEzBkQuraUA6Pziu6wipkcxycimPRRzbKtksTzgsnqZem8s Ksw6LNlNhxB3xPTYIv3laKK/fhJ7ZRi1Likdd8F3K92Cce8IJEMVw3HqJ0aAs+hYQa fCU48b2AneunAhJpC4t2GxwkYf1WJz1KqaT27bUi4FODvrvMaB33R59sV9wyJvMSnu /Qllvjmp/7NwPewSdPk3rwuuae1YivBD1ltZdAazwrH6UQ/g5qVPyOnRNLndI1+C++ vYiGtaMDKb8rw== Date: Mon, 22 Sep 2025 12:11:26 -0500 From: Rob Herring To: Michael Riesch Cc: Mehdi Djait , Maxime Chevallier , =?iso-8859-1?Q?Th=E9o?= Lebrun , Thomas Petazzoni , Gerald Loacker , Bryan O'Donoghue , Markus Elfring , Laurent Pinchart , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Philipp Zabel , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bryan O'Donoghue Subject: Re: [PATCH v11 05/17] media: dt-bindings: add rockchip rk3568 mipi csi-2 receiver Message-ID: <20250922171126.GA480461-robh@kernel.org> References: <20240220-rk3568-vicap-v11-0-af0eada54e5d@collabora.com> <20240220-rk3568-vicap-v11-5-af0eada54e5d@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220-rk3568-vicap-v11-5-af0eada54e5d@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250922_101128_869303_0AD4BAF8 X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 17, 2025 at 05:38:45PM +0200, Michael Riesch wrote: > Add documentation for the Rockchip RK3568 MIPI CSI-2 Receiver. > > Signed-off-by: Michael Riesch > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Michael Riesch > --- > .../bindings/media/rockchip,rk3568-mipi-csi.yaml | 144 +++++++++++++++++++++ > MAINTAINERS | 6 + > 2 files changed, 150 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml > new file mode 100644 > index 000000000000..8cbab93b4b85 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip,rk3568-mipi-csi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip RK3568 MIPI CSI-2 Receiver > + > +maintainers: > + - Michael Riesch > + > +description: > + The Rockchip RK3568 MIPI CSI-2 Receiver is a CSI-2 bridge with one input port > + and one output port. It receives the data with the help of an external > + MIPI PHY (C-PHY or D-PHY) and passes it to the Rockchip RK3568 Video Capture > + (VICAP) block. > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - rockchip,rk3588-mipi-csi > + - const: rockchip,rk3568-mipi-csi > + - const: rockchip,rk3568-mipi-csi > + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: Interrupt that signals changes in CSI2HOST_ERR1. > + - description: Interrupt that signals changes in CSI2HOST_ERR2. > + > + interrupt-names: > + items: > + - const: irq1 > + - const: irq2 Names that are just the index are not useful. Drop. With that, Reviewed-by: Rob Herring (Arm) > + > + clocks: > + maxItems: 1 > + > + phys: > + maxItems: 1 > + description: MIPI C-PHY or D-PHY. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Input port node. Connect to e.g., a MIPI CSI-2 image sensor. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-type: > + enum: [1, 4] > + > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + required: > + - bus-type > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Output port connected to a RK3568 VICAP port. > + > + required: > + - port@0 > + - port@1 > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - phys > + - ports > + - power-domains > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + > + soc { > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + csi: csi@fdfb0000 { > + compatible = "rockchip,rk3568-mipi-csi"; > + reg = <0x0 0xfdfb0000 0x0 0x10000>; > + interrupts = , > + ; > + interrupt-names = "irq1", "irq2"; > + clocks = <&cru PCLK_CSI2HOST1>; > + phys = <&csi_dphy>; > + power-domains = <&power RK3568_PD_VI>; > + resets = <&cru SRST_P_CSI2HOST1>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + csi_in: port@0 { > + reg = <0>; > + > + csi_input: endpoint { > + bus-type = ; > + data-lanes = <1 2 3 4>; > + remote-endpoint = <&imx415_output>; > + }; > + }; > + > + csi_out: port@1 { > + reg = <1>; > + > + csi_output: endpoint { > + remote-endpoint = <&vicap_mipi_input>; > + }; > + }; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 4c39b9fd80bb..2ac4b7a5b255 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -21797,6 +21797,12 @@ F: Documentation/userspace-api/media/v4l/metafmt-rkisp1.rst > F: drivers/media/platform/rockchip/rkisp1 > F: include/uapi/linux/rkisp1-config.h > > +ROCKCHIP MIPI CSI-2 RECEIVER DRIVER > +M: Michael Riesch > +L: linux-media@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml > + > ROCKCHIP RK3568 RANDOM NUMBER GENERATOR SUPPORT > M: Daniel Golle > M: Aurelien Jarno > > -- > 2.39.5 >