From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DCA2CAC5AA for ; Tue, 23 Sep 2025 03:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JTbZNARJlq5F/K4GK85V8hZbFf1ZA+2uVnmlvwf1j9M=; b=1LWKlzzSJAM4UDpHgy58zdVnkr 9rOKUg0JloV6Q/2fUMSz8HQ5zVoa6cH5NQhoTMd3yxmtJqE/ULk8eky/RAEYipzwkvfBxP75DceCJ Edo0qgOm/rdR6lyQR6RP5j3vGyaAQo9n8+IULIvBSV5LBkbuYnLB47UX7CkvzE6FHwmdK2REGPVWO mrC2SCrM72DOwJ5z5v93xBQ/zByCIUVgrGskvIgW3blyh43c79rUgvGO64FKEzm4bRx0fBEXbaC4L IaAic9+7O5g1xFSgtsdsUJ3OvriGBJW097XILMSl9Zd/Q60bGDnHB9vt1vOoWnuAfioKIu2rB9nLl s3L9U6ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0tYw-0000000CDkN-2MuI; Tue, 23 Sep 2025 03:19:30 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0tYu-0000000CDiq-1RA1 for linux-arm-kernel@lists.infradead.org; Tue, 23 Sep 2025 03:19:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j9LQQ8cnZiy0vIZTuQHEmHaqMFUYIig1e+qi3DQJm7QyczojkcIISiXUH7Dh/l7Pat9XQDwRDab7nuTSSaLEXXF+cFnYMP7sdveBNvxCckFl//ETPARh0XxOM2GAt4w8Q3rNGcYMhml8nxOmjArA3sod+0pYZblMkbh/MJqTrBKdQm5O4vj/MppW1D+sSVxW2sxYhzUn3ZSFd72bjyXgR+p2MzpJmeWyPwvIxFX+vF1oOOuC6MloIuZ4HcJYDUO0aTfzPyKI6SUziFpy6J3+5Iygnxybju6wyXK5vDXSIHMTUpYXNFTg0C4GTKgdqFY15rQzDxdfHsNoZSZ7DPxbgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JTbZNARJlq5F/K4GK85V8hZbFf1ZA+2uVnmlvwf1j9M=; b=ETNVlZEUINHVMJQfWdV96s3IbDauSJ0zHnnwFeOGZ/0KfSYVhT6MSNDZci0v1qaPXoM2b9/1457nKR4NGSvCErl6FtYzTq0ESOB2OdQqu1CLG6wovLJaJj/xBMmUr0gG8azheIjmtXxutEhhJwcL1bhFTc+nF1toDgaz/lY1mAHlc0rdDMpoKTaWun8eomfPsAuuVQO4bEnCVu5dQvvUSwRZ6qa3NZR0v4DwznqJaipp0gTyWUnvcQxQTyJHy7lRkoSqRzPNML3blyMJSqDNH0yuDaYBBXseD07eCCJgqeIGF2RK2UXrSBqytyzYNBxe6pivxifAz5X2e1OXF92XXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JTbZNARJlq5F/K4GK85V8hZbFf1ZA+2uVnmlvwf1j9M=; b=jTyMkDfyMNpvHufrqQSw4pHThTJ9wB/Q9fySC9UPKfgJMuZcFd3Ag7D1BGBY+nDFClQv8gWxG83rOgfOLvi51RcZJ48xf9+VnrW/cx/FF0bDn3lITbFnPDXEIGs2Lbi5cpOOcXqdHi0Mk82z2kQtE8g7PuKPRdDaRtS5vbZqLid/8hVL+xr5PGrOvNtRZR3PHGSKuXCo9QWdwH0QlRuTJ9zcQIM2k5yxf2IkyvfEZK6QOlv65bL90YrpsRGxHPK/LZXa4it/2ZUkfr6e04VZi6l40Nahc760J0teRFdmHD5MIFZ2nbrW3W35o38F2cjkIA6nm5cHP3eLlkbZcNZxdg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB9679.eurprd04.prod.outlook.com (2603:10a6:102:23d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9; Tue, 23 Sep 2025 03:19:21 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9160.008; Tue, 23 Sep 2025 03:19:21 +0000 Date: Tue, 23 Sep 2025 12:31:00 +0800 From: Peng Fan To: Mathieu Poirier Cc: Peng Fan , Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Ulf Hansson , Hiago De Franco , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] remoteproc: imx_rproc: Fix runtime PM cleanup order and error handling Message-ID: <20250923043100.GA31170@nxa18884-linux.ap.freescale.net> References: <20250917-imx_rproc_c2-v1-0-00ce23dc9c6e@nxp.com> <20250917-imx_rproc_c2-v1-1-00ce23dc9c6e@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: SI1PR02CA0004.apcprd02.prod.outlook.com (2603:1096:4:1f7::12) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB9679:EE_ X-MS-Office365-Filtering-Correlation-Id: 230c9145-13e1-4f93-4eb8-08ddfa4ffd04 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|52116014|376014|1800799024|7416014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZWtBWI4pcIp1UJXqXavBy/TS3v7Roe5qdEkmbmTn9iv74H4o/QDiSAeYU0Ao?= =?us-ascii?Q?Ixz9ZJgc+Yy1ZUkfTkMlZtpLYMtm/SFs/uOWTi4qFA0Sy9sbYlIJTflKhsZD?= =?us-ascii?Q?QiIkXub3e3CQX0mfQGOReNkPK53TRf8kCSO/lgYlMzLA7VhaJXY1WtYRXu2b?= =?us-ascii?Q?FyemwgUcsezGlwrPHjmdgHyUc4/3Y1CH4Ae/PcWduIaL+goETWuGJ51eDoF7?= =?us-ascii?Q?MRw5PU7utTKXJhjJ+VAiAaPz2nkIXZkwHX4VxZDqvqENGJ6iI2zr4Th9gU6Z?= =?us-ascii?Q?8tzpbrULaRZRzIL70fdg59HZTzfpRjDMs4rw2D/vcHjHG4m0a3gqBawNahor?= =?us-ascii?Q?Zl3YhY3UhARJHFkRKf5sGsb7hgA1fXT0VcjJwDn3MB2WvZEOr/Qql2gbunEL?= =?us-ascii?Q?LN0EVOgAo1jCandJ18FIAb4MexS3RVxiaCZzctIcnhfgWf35W4kcCQ49Keun?= =?us-ascii?Q?S4RLhRGI02Hbk6nETntEm2FKAU0PeFcpi+KbGRIfzkVZ4UkUNfngIVDqk6YM?= =?us-ascii?Q?qMwyvzoIiP7/rHjG/lEa7qaVfvccy3n9MUqo3+qKULmYOBtSgyNmLKx8gfZO?= =?us-ascii?Q?4EcAQbXGeJA0OswDtC6+boPrCXOrvw8hHeGuhScuIG6tZpwN8rFvQJK5AROx?= =?us-ascii?Q?iPWurvErrvS58AhvYdeosZua9WYEh6tyGr4Q2K/TPvCUiYliNpSx647VxV0k?= =?us-ascii?Q?+M4kN1z5AxgXpTmaroyRqlDL+UkjU/LVWbX41VfMDOiRc94jmZF0Ow23EPxf?= =?us-ascii?Q?8sL4xC3mfd8D8TmUtCDRsAUkmj41o220MRkH4FYSEj7oMIeYZLSsF9z31eSw?= =?us-ascii?Q?wZeEf/wZiAw7DM2yKbjbZjIzmyRWr1KQSihSMizk/StIfDNtWNRyR1jPAhfc?= =?us-ascii?Q?ITZXV0w5k/boKnW7zOple4+c5B6GHbVYJYZkuIAzFBXl7fRCSSynMussLP9b?= =?us-ascii?Q?goN9XJisxG2UIiTfrShgfwomXTdUNmuoh7aa8qWFuH3WEGK+FmaUJnv+X4uV?= =?us-ascii?Q?5rxWW7kzMeQtDvtKhQqsgU7x+OmVfZzZ1FaZXmndieqMjWmVlbD+E1yKc4lz?= =?us-ascii?Q?TEym/QybsHRyE347eVxxZDQB7YFd8yLhUlWQclCIG3EsWgrDqQaQtE65wphq?= =?us-ascii?Q?L2HrGGk9GFnKAi83tA9dcm3Fr3nDtYTYffV0fWxPJ0td2dB3JfgIsehtaHOD?= =?us-ascii?Q?9fS1Ez3mwpY0zPw3Cj/i9FF5JrLCyZNOsvQMyAc4AsTFG10NusngF9TJ7frJ?= =?us-ascii?Q?IvXhjXKBeod1Hoce2pPVDCQunJFqryiKsk8no6mnVavC28gOsc3aOxtuYgMi?= =?us-ascii?Q?b0NcGvvVdyXnYiI3Hs0ZKIda7uuEO4Z5VRf9/oNy8xGCvmb1tVLqgqcPcDx2?= =?us-ascii?Q?8XTv8bwTDuoZuD6mEicpuwfXEpvUMBAkRtHhQppeFnH2zGGdb8Uh63nwU9P1?= =?us-ascii?Q?0aNII9cMnVB3TTqXqwTBN5SPlamHotb4503m2TJSbLpmuDSx1qAgMg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(52116014)(376014)(1800799024)(7416014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UD+tMU7XjMUH/Mjr3IjJH+S4ZnSJlhycap/ZrRcP0Bw4EqTXOBVykg1ydo4f?= =?us-ascii?Q?Ye3kU0hzZRlBlCMoMOhI2lMgvq0IPkjjYQgQLOFXFtegUJSuVRGu3F8AA5/V?= =?us-ascii?Q?Sugb+P2LI2q6UwKIuhKUFcAgkC1r/hziLYwjTUbB58x6p64KZCPd1LlzpC3d?= =?us-ascii?Q?3hKrxu8lfxvKpny6Nmoj1MOfKdiLDZxVCwLMeR8FCNxtcX0H4q2aacgsjTaY?= =?us-ascii?Q?5NrQcuTrMLnwCc5r+sZv7FdMV9rgksw49ocPxbEz4LzxuxZ82A9NeU1xumYF?= =?us-ascii?Q?fLTTItjbBmw5IOqWnUUaT15i1VLA6y0XrSgHAooKKBvMs5JNGa3sK4UZ9o3b?= =?us-ascii?Q?fVAb/YYMuve8jKOxH0TzcfGi765xIoyhHcqJoXb+KDcRB2mNhWFIPOblSqsc?= =?us-ascii?Q?cuqC1AvVXgOOjyOSCAPEQye0Wx0jwtIPvUn3XN/T7Og5bqXb2z1+k6f0fTDz?= =?us-ascii?Q?+BbOjuAbNDYqoN4dGxQGjNPZY69TMqXP6MZosBLyFhC2oz0uVpamjvRkE13r?= =?us-ascii?Q?JLV0z1VpUdJvHhik8fXmt7zdVze+HwjdRo9NxevqlXi7+XRyOx+5gPXTNHHS?= =?us-ascii?Q?cAyLyYbKkd9IAHsxIDELVP5msFsXHoyo0ErFTy6or6kxq07LtYeJLE9j1U3U?= =?us-ascii?Q?r8Zn9/B+aOyzDHjyItNfBDVf0G7iCmx2fGqPfszAlkHrBKaG/8KlvY3bwgVp?= =?us-ascii?Q?50S39DBunzXLKE3bRCNOVsdxDm9VvlE4CB5nbxasHa5LohVOYsSgBFvKW0N6?= =?us-ascii?Q?HT6Rx9yMe91ebd4xWzPn+FNF8bFHbMFOeP5+L13qzQK5dI8fsowdHGzGNbsy?= =?us-ascii?Q?INgq4bP9Ft/b5Dc26nq9OIIvs+5yPPTK6CZSAMeeTXutrnhTOiktJxcvJ//Q?= =?us-ascii?Q?wzKB9hnWsMDRiBhP5BsNY+IFZg7svPTQthb4TcbZ1QUvEZhtpiBqC01jC3qa?= =?us-ascii?Q?Ck32H8BrsCPVLRI0jQVhSrayUUkwh2lzvaHJqGg967O0v/DiFGl5SMNxRR8U?= =?us-ascii?Q?tp1XDiyanqcsUuCqqDKyfeXMYDw7fMJDJ05J4seWZC7gxGVkxRznnfPIqElW?= =?us-ascii?Q?nreGESmuNZyNhJVVWwilrtGqOhV5Cn3WPo/nx53wUt5r5UtaJw6dMZlZo1yr?= =?us-ascii?Q?4xNsJ8WkCYnOFoKYoBTWzx67AUuGDgVuXL9WzvZQhM18j3K7PyP2iZCn3ZuA?= =?us-ascii?Q?NqNhR/UALevU9DbCiKKHe2hsD/HJ3GCy8T9hRUxFrZ9Eg9Hp+7Kou+ldKO7i?= =?us-ascii?Q?a/eSr2zi3DLuOD9zvlu72AVnhqXvslj7LKGBICoXCwkVSnr7B1nQuThPke27?= =?us-ascii?Q?Y4jDmfr57KX6ZrCSSJUrACxDfDTSJATAVrlD49wxnm2hoD+gd/UrU+VK/qom?= =?us-ascii?Q?7+1ZQMqjpf0v+E1NFc4H4PhY6uKtD0ee2frM5h+cr7SZohMskVeeDTBrEMUW?= =?us-ascii?Q?1JljOPe2VQx5mvQB6Mj39+n/5IwUTVxGOtX2li/hbamJhCPOAK4xOKsQ9LDJ?= =?us-ascii?Q?FM3q8dfGyc7AugYUWhut9gktY5QnSpa3QIqoim/dP4ztlCrYObegyBgxx7CE?= =?us-ascii?Q?ZxjoOGVi5x0vAlA9mSAsez2ltwu72lPjB2/vwaOA?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 230c9145-13e1-4f93-4eb8-08ddfa4ffd04 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2025 03:19:21.2889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2j1WbnRU7pQNs30+SkvCl3zsd/2vznZNrie05qBAHiJg5t9D7mlDqZxrZdhEXoWfnG8b6cbGqHu7WY37uLxEUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9679 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250922_201928_388143_3CA4191F X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 22, 2025 at 10:07:08AM -0600, Mathieu Poirier wrote: >On Wed, Sep 17, 2025 at 09:19:13PM +0800, Peng Fan wrote: >> The order of runtime PM API calls in the remove path is wrong. >> pm_runtime_put() should be called before pm_runtime_disable(), per the >> runtime PM guidelines. > >Where is this mentioned? I have looked in [1] and couldn't find anything. > >[1]. Documentation/power/runtime_pm.rst > Per this API says: int pm_runtime_disable(struct device *dev);` - increment the device's 'power.disable_depth' field (if the value of that field was previously zero, this prevents subsystem-level runtime PM callbacks from being run for the device), make sure that all of the pending runtime PM operations on the device are either completed or canceled; This implies that pm_runtime_put() should be called before pm_runtime_disable(). Thanks, Peng