From: Janne Grunau <j@jannau.net>
To: James Calligeros <jcalligeros99@gmail.com>
Cc: Sven Peter <sven@kernel.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Neal Gompa <neal@gompa.dev>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 08/11] mfd: macsmc: Wire up Apple SMC HID subdevice
Date: Thu, 25 Sep 2025 23:55:06 +0200 [thread overview]
Message-ID: <20250925215506.GD637503@robin.jannau.net> (raw)
In-Reply-To: <20250827-macsmc-subdevs-v2-8-ce5e99d54c28@gmail.com>
On Wed, Aug 27, 2025 at 09:22:42PM +1000, James Calligeros wrote:
> Add the new SMC HID function to the mfd device
>
> Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
> ---
> drivers/mfd/macsmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/macsmc.c b/drivers/mfd/macsmc.c
> index 286dc150aa6cfdd6d29f769094278daaddabe7c3..893fc47d62b2c956d966d1841895a3fa2b9a3005 100644
> --- a/drivers/mfd/macsmc.c
> +++ b/drivers/mfd/macsmc.c
> @@ -45,6 +45,7 @@
> #define SMC_TIMEOUT_MS 500
>
> static const struct mfd_cell apple_smc_devs[] = {
> + MFD_CELL_NAME("macsmc-hid"),
I think it would make sense to use MFD_CELL_OF and device nodes for all
macsmc even though it's in the case of macsmc-input (or -hid) not
strictly necessary
> MFD_CELL_OF("macsmc-gpio", NULL, NULL, 0, 0, "apple,smc-gpio"),
> MFD_CELL_OF("macsmc_hwmon", NULL, NULL, 0, 0, "apple,smc-hwmon"),
> MFD_CELL_OF("macsmc-reboot", NULL, NULL, 0, 0, "apple,smc-reboot"),
Janne
next prev parent reply other threads:[~2025-09-25 21:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 11:22 [PATCH v2 00/11] mfd: macsmc: add rtc, hwmon and hid subdevices James Calligeros
2025-08-27 11:22 ` [PATCH v2 01/11] dt-bindings: rtc: Add Apple SMC RTC James Calligeros
2025-08-27 11:22 ` [PATCH v2 02/11] dt-bindings: hwmon: Add Apple System Management Controller hwmon schema James Calligeros
2025-08-29 16:40 ` Rob Herring
2025-09-25 20:49 ` Janne Grunau
2025-09-25 21:43 ` Rob Herring
2025-09-28 0:36 ` James Calligeros
2025-09-28 2:09 ` Guenter Roeck
2025-08-27 11:22 ` [PATCH v2 03/11] rtc: Add new rtc-macsmc driver for Apple Silicon Macs James Calligeros
2025-08-27 11:22 ` [PATCH v2 04/11] mfd: macsmc: Wire up Apple SMC RTC subdevice James Calligeros
2025-08-27 11:22 ` [PATCH v2 05/11] hwmon: Add Apple Silicon SMC hwmon driver James Calligeros
2025-08-28 22:19 ` Guenter Roeck
2025-09-25 21:33 ` Janne Grunau
2025-08-27 11:22 ` [PATCH v2 06/11] mfd: macsmc: Wire up Apple SMC hwmon subdevice James Calligeros
2025-08-27 11:22 ` [PATCH v2 07/11] input: macsmc-hid: New driver to handle the Apple Mac SMC buttons/lid James Calligeros
2025-08-29 11:11 ` Dmitry Torokhov
2025-10-21 21:35 ` Janne Grunau
2025-09-25 21:49 ` Janne Grunau
2025-08-27 11:22 ` [PATCH v2 08/11] mfd: macsmc: Wire up Apple SMC HID subdevice James Calligeros
2025-09-25 21:55 ` Janne Grunau [this message]
2025-08-27 11:22 ` [PATCH v2 09/11] arm64: dts: apple: t8103,t600x,t8112: Add SMC RTC node James Calligeros
2025-08-27 11:22 ` [PATCH v2 10/11] arm64: dts: apple: Add common hwmon sensors and fans James Calligeros
2025-09-25 22:02 ` Janne Grunau
2025-08-27 11:22 ` [PATCH v2 11/11] arm64: dts: apple: t8103, t600x, t8112: Add common hwmon nodes to devices James Calligeros
2025-08-27 13:47 ` [PATCH v2 00/11] mfd: macsmc: add rtc, hwmon and hid subdevices Guenter Roeck
2025-08-27 22:06 ` James Calligeros
2025-08-28 2:50 ` Neal Gompa
2025-08-28 22:12 ` Alexandre Belloni
2025-09-25 22:13 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925215506.GD637503@robin.jannau.net \
--to=j@jannau.net \
--cc=alexandre.belloni@bootlin.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jcalligeros99@gmail.com \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox