From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01A74CCA470 for ; Wed, 1 Oct 2025 13:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DZbLNfHIZ29CMiiF5Knwp+rQzPvGl9fYN8jxX1s/MFE=; b=5C3V8cqhHy10YkaHF39faFxX3d 8mcBtpA1bZqysqyvWYw+s11rubvjk4arz3T59tRLbWjYhLe4ge8mQzlpfiZ8fU1bTHYw9I2Qu9VOI E/CBmKRXaunJdZPZBaDSG9fC96lZJwx4mEIjiK37ac6KFIhbr7uGdQrTxV4/dIBSOjcn2W8FqKYiE Qa3BP8DtJJIrIm/qEH4MqUmOioUDyvdpZIPHuULZaBhpuoAhHC1YckTilf2SFyX40ypCB0PYIM8Rj WfqFjmXpsu1Yq/F5rLPYNA8gwwZoX+n1imd0PLkcSMhCX9wITb1B4x9CbiZAPm7z0FxvUp2EVPR0Y m7+QP5qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v3wnM-0000000803V-0CT8; Wed, 01 Oct 2025 13:23:00 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v3wnG-00000007zra-2Oq2 for linux-arm-kernel@lists.infradead.org; Wed, 01 Oct 2025 13:22:56 +0000 Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 950E5173F; Wed, 1 Oct 2025 15:21:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1759324884; bh=jcF9TO4w0dmiNuHteMC+0VDVhFz7gX4DbHPqYH+9J6g=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MpBmYH54e+Hgvzux5IzTqdFPaYf1ivO5KMDVr287GWvHA8LWBHT85mr7Q25ImYPyo u6u6g092p9vWV1FC/ZqxsF+rg1w8VDeSlbjFpsBi0oJ08oNAWwESmdNfBJuOm89kLx uiGSV1YONGDZmWCDKar/S4YvVV9Fcz0Cw+uglpds= From: Tomi Valkeinen Date: Wed, 01 Oct 2025 16:22:19 +0300 Subject: [PATCH v6 07/11] drm: xlnx: zynqmp: Use drm helpers when calculating buffer sizes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251001-xilinx-formats-v6-7-014b076b542a@ideasonboard.com> References: <20251001-xilinx-formats-v6-0-014b076b542a@ideasonboard.com> In-Reply-To: <20251001-xilinx-formats-v6-0-014b076b542a@ideasonboard.com> To: Vishal Sagar , Anatoliy Klymenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Laurent Pinchart , Michal Simek Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dmitry Baryshkov , Pekka Paalanen , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=jcF9TO4w0dmiNuHteMC+0VDVhFz7gX4DbHPqYH+9J6g=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBo3SsjnX1o4AVIECTUWPwFyTd++aQO6/WfXxbCK g+/9Efx86mJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCaN0rIwAKCRD6PaqMvJYe 9UIwD/wJvuoMNRezoTPoSMUJkTadTXRubLBLrcUD+KJja74oLbQ8X18IGh8MFvgCgQnDdsXIHTE /EQHvp2ByacWuhTNz/x7kkxXaBCs01iZt0RxV4YnXYxI2TY98xVW5NHyaOkEvhkaQ7hQCSREuFE 9bUXyQLgFVJAy6Tm9RB3iyZ6lrVP8yCOsmUqS+cAO4uJb5ghkgvPkq8aOPLyimxTMEfJFvJYL1l WCWsDojtnWj07L/NXMKV2dy+K7l2jlYDgbYkOXy0hIMn5EV5y8Zvzf+fJXfkdc51y66q5XNIEro 5HfhlejYqgUj6XmfDROMQNd4IBQlrBis0kGusyGugUNGzQEgx552XFeuvqUnU1j6YS+AlHsWIdF nNBCoE6pmidb/NeGIgT5845i22AVAMTyvi/4npI4py2E3CSrVUxtXSeUADlvtQhM5N0yJdtUgx8 ZBX6CkPSq3zryg6sRYUA9uUaZnDmeVsLy/wE5rCKmhQ0AEs4oGs0DQ5LRQqFdwlOt5XHAZLEbdI N8/Duy+n4ja/7M+EYGh+Ck3+D1mKw0X9vl7ZVvKBEqni4KIYXzJ8SDp3cBX26GusIW6SNi8wjzk 4AwD0Hp4diSQo+jQfQwE50AvRxkw+jDaAenHbxfduYtBidqYJ0o/eAFHCJsCMuTpI8q7m8EoDJO Pgu2Qm6td1XUdvw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251001_062254_784990_A196676E X-CRM114-Status: GOOD ( 10.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use drm helpers, drm_format_info_plane_width(), drm_format_info_plane_height() and drm_format_info_min_pitch() to calculate sizes for the DMA. This cleans up the code, but also makes it possible to support more complex formats (like XV15, XV20). Reviewed-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c index 80d1e499a18d..b9883ea2d03e 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c @@ -1116,16 +1116,19 @@ int zynqmp_disp_layer_update(struct zynqmp_disp_layer *layer, return 0; for (i = 0; i < info->num_planes; i++) { - unsigned int width = state->crtc_w / (i ? info->hsub : 1); - unsigned int height = state->crtc_h / (i ? info->vsub : 1); struct zynqmp_disp_layer_dma *dma = &layer->dmas[i]; struct dma_async_tx_descriptor *desc; dma_addr_t dma_addr; + unsigned int width; + unsigned int height; + + width = drm_format_info_plane_width(info, state->crtc_w, i); + height = drm_format_info_plane_height(info, state->crtc_h, i); dma_addr = drm_fb_dma_get_gem_addr(state->fb, state, i); dma->xt.numf = height; - dma->sgl.size = width * info->cpp[i]; + dma->sgl.size = drm_format_info_min_pitch(info, i, width); dma->sgl.icg = state->fb->pitches[i] - dma->sgl.size; dma->xt.src_start = dma_addr; dma->xt.frame_size = 1; -- 2.43.0