Re: [PATCH v2 1/3] dt-bindings: spi: axiado,ax3000-spi: Add binding for Axiado SPI DB controller

Conor Dooley
2025-09-29T18:53:29Z

[-- Attachment #1: Type: text/plain, Size: 2596 bytes --]

On Mon, Sep 29, 2025 at 01:58:01AM -0700, Vladimir Moravcevic wrote:
> Add documentation for Axiado Digital Block SPI controller.
>
> Signed-off-by: Vladimir Moravcevic <vmoravcevic@axiado.com>
> Signed-off-by: Prasad Bolisetty <pbolisetty@axiado.com>

What did Prasad do here? Are you missing a Co-developed-by tag?

> ---
> .../devicetree/bindings/spi/axiado,ax3000-spi.yaml | 63 ++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml b/Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..34fa96778dfdec89bc14782265ec23c0bc455a20
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/axiado,ax3000-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Axiado AX3000 SoC SPI controller
> +
> +maintainers:
> + - Vladimir Moravcevic <vmoravcevic@axiado.com>
> + - Tzu-Hao Wei <twei@axiado.com>
> +
> +allOf:
> + - $ref: spi-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - axiado,ax3000-spi
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: ref
> + - const: pclk
> +
> + clocks:
> + maxItems: 2
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clock-names
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + spi0: spi@80510000 {

The "spi0" label here is unused and should be removed.

> + compatible = "axiado,ax3000-spi";
> + reg = <0x00 0x80510000 0x00 0x1000>;
> + clock-names = "ref", "pclk";
> + clocks = <&spi_clk>, <&apb_pclk>;
> + interrupt-parent = <&gic500>;
> + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
> + num-cs = <1>;

num-cs isn't required by your binding and you have not specified a
default. Your driver assumes a default of 4. You should include that,
along with any maximum value, in the binding. See spi-cadence.yaml for
an example.

> + };
> + };
> +...
>
> --
> 2.25.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]