From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5208CCA471 for ; Fri, 3 Oct 2025 20:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eh+sUFlOv59lp/vCBeSkjajmcNvaT/3Hx34rZwnuFVM=; b=GSrmwOL1R+xR/IsxQfyQBNv7L4 bq6N8wXF70KDLNlCxROPTNOk0cMH7LbWPJ8mKQSG1DxyL+JuQnXeapi4cdCQVxYf/3MsKGPVqPgPE h5ydwyXAIiYx/c1L8f0ZFS+V3949vq6JmeZR6yfihmj4hwbCR8TeJuYRrjfBcLcFB/Ii+5QUlWar8 /JxgjVr1HabJIlKAbD7cSkoF+eVgtJuHAb3LlyHkTCt19S3iXxXzTkew8XNw2cisxLFXLwNT1W0u6 sNLGVqqcv7WKjTVG23yCjtuwE05jsvVaN1CosjWkGBeUjtVZvIzpbB6dRPPxqmHlXCtcPSFdsArGX V+E3ZRyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v4mCh-0000000D3vq-3ez4; Fri, 03 Oct 2025 20:16:35 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v4mCe-0000000D3qy-1dWi; Fri, 03 Oct 2025 20:16:33 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1759522567; cv=none; d=zohomail.com; s=zohoarc; b=BewWrUSbHUV6Ma4sSIKIjzhzShF9pbcqjQpsgSi5VV8ZJ/0PmN4/WLJETBA1hanA/WBas9KsEHM37phCMHzTIixuSR/xsOJgWwY38Hh8x5SGZW7T3bxsUftfukcPXtJjeFYAt+CwLD1+Td9erCEGBOkKsT37JPL4EKbfDxxLGJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759522567; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=eh+sUFlOv59lp/vCBeSkjajmcNvaT/3Hx34rZwnuFVM=; b=KeG9a0qWHgpbzJNclaKV90zJf/KQGjakHcqovcgNsmWovU0Omm6LEt0NnWk+S31QiOAsEZjdqemA+xM1ipZdgxS4mzhkzjzjgYx/H4KenRnfvSKNR36eDbUn/vO4+RJRr+Ehb0+uWe0Pf3Ic4AoYtMq65bOoSCPgO4C9icNqmIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1759522567; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=eh+sUFlOv59lp/vCBeSkjajmcNvaT/3Hx34rZwnuFVM=; b=kL+vIulPBmx9LaDeQ+jTQGDxoNjGGFN9cKpWi+SW/s1aPWa9bqkKr14EShgQIYzN r6I6eh0yOjI6Os39ivfO7tQfRi02ryAHDpiJqmUak0tWitZ5EEb9UlVVZrztQt6n+tU d1dOPktsNqULDMd0LaBjspASvqPMlAzfpIWNqIT0= Received: by mx.zohomail.com with SMTPS id 1759522565601633.8413941370096; Fri, 3 Oct 2025 13:16:05 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 03 Oct 2025 22:15:08 +0200 Subject: [PATCH v6 6/7] drm/panthor: Use existing OPP table if present MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251003-mt8196-gpufreq-v6-6-76498ad61d9e@collabora.com> References: <20251003-mt8196-gpufreq-v6-0-76498ad61d9e@collabora.com> In-Reply-To: <20251003-mt8196-gpufreq-v6-0-76498ad61d9e@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Jassi Brar , Chia-I Wu , Chen-Yu Tsai , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Kees Cook , "Gustavo A. R. Silva" , Ulf Hansson Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-hardening@vger.kernel.org, linux-pm@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251003_131632_497643_FABA14F1 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On SoCs where the GPU's power-domain is in charge of setting performance levels, the OPP table of the GPU node will have already been populated during said power-domain's attach_dev operation. To avoid initialising an OPP table twice, only set the OPP regulator and the OPPs from DT if there's no OPP table present. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_devfreq.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c index 978f193a2aee561fadd9a976e9b1417118260889..6beb6170d6eea3dd65880dfe64a61abbdd5f08da 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.c +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c @@ -143,6 +143,7 @@ int panthor_devfreq_init(struct panthor_device *ptdev) struct panthor_devfreq *pdevfreq; struct dev_pm_opp *opp; unsigned long cur_freq; + struct opp_table *t; unsigned long freq = ULONG_MAX; int ret; @@ -152,18 +153,23 @@ int panthor_devfreq_init(struct panthor_device *ptdev) ptdev->devfreq = pdevfreq; - ret = devm_pm_opp_set_regulators(dev, reg_names); - if (ret) { - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n"); - - return ret; + t = dev_pm_opp_get_opp_table(dev); + if (IS_ERR_OR_NULL(t)) { + ret = devm_pm_opp_set_regulators(dev, reg_names); + if (ret) { + if (ret != -EPROBE_DEFER) + DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n"); + + return ret; + } + + ret = devm_pm_opp_of_add_table(dev); + if (ret) + return ret; + } else { + dev_pm_opp_put_opp_table(t); } - ret = devm_pm_opp_of_add_table(dev); - if (ret) - return ret; - spin_lock_init(&pdevfreq->lock); panthor_devfreq_reset(pdevfreq); -- 2.51.0