Re: [PATCH v2 1/2] dt-bindings: clock: aspeed: Add VIDEO reset definition

Conor Dooley
2025-10-03T20:50:49Z

[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]

On Fri, Oct 03, 2025 at 09:49:00PM +0100, Conor Dooley wrote:
> On Fri, Oct 03, 2025 at 09:58:44AM +0800, Jammy Huang wrote:
> > ASPEED clock controller provides a couple of resets. Add the define of
> > video to allow referring to it.
> >
> > Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> > ---
> > v2 changes:
> > - Update index of ASPEED_RESET_VIDEO
>
> Ah, so here is the next version. I don't see how this can be correct if
> 21 was correct before. Was 21 wrong?

Given the driver has mappings, I guess this is actually correct.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> > ---
> > include/dt-bindings/clock/aspeed-clock.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
> > index 06d568382c77..671e5a476eae 100644
> > --- a/include/dt-bindings/clock/aspeed-clock.h
> > +++ b/include/dt-bindings/clock/aspeed-clock.h
> > @@ -53,5 +53,6 @@
> > #define ASPEED_RESET_AHB 8
> > #define ASPEED_RESET_CRT1 9
> > #define ASPEED_RESET_HACE 10
> > +#define ASPEED_RESET_VIDEO 11
> >
> > #endif
> > --
> > 2.25.1
> >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]