From: Sudeep Holla <sudeep.holla@arm.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Maulik Shah <quic_mkshah@quicinc.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: smp: Implement cpus_has_pending_ipi()
Date: Mon, 6 Oct 2025 11:54:26 +0100 [thread overview]
Message-ID: <20251006-manipulative-urban-antelope-31101f@sudeepholla> (raw)
In-Reply-To: <20251003150251.520624-3-ulf.hansson@linaro.org>
On Fri, Oct 03, 2025 at 05:02:44PM +0200, Ulf Hansson wrote:
> To add support for keeping track of whether there may be a pending IPI
> scheduled for a CPU or a group of CPUs, let's implement
> cpus_has_pending_ipi() for arm64.
>
> Note, the implementation is intentionally lightweight and doesn't use any
> additional lock. This is good enough for cpuidle based decisions.
>
I’m not completely against this change, but I’d like to discuss a few points
based on my understanding (which might also be incorrect):
1. For systems that don’t use PM domains for idle, wouldn’t this be
unnecessary? It might be worth making this conditional if we decide to
proceed.
2. I understand this is intended for the DragonBoard 410c, where the firmware
can’t be updated. However, ideally, the PSCI firmware should handle checking
for pending IPIs if that’s important for the platform. The firmware could
perform this check at the CPU PPU/HW level and prevent entering the
state if needed.
3. I’m not an expert, but on systems with a large number of CPUs, tracking
this for idle (which may or may not be enabled) seems a bit excessive,
especially under heavy load when the system isn’t really idling.
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-10-06 10:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 15:02 [PATCH 0/3] pmdomain: Improve idlestate selection for CPUs Ulf Hansson
2025-10-03 15:02 ` [PATCH 1/3] smp: Introduce a weak helper function to check for pending IPIs Ulf Hansson
2025-10-03 15:02 ` [PATCH 2/3] arm64: smp: Implement cpus_has_pending_ipi() Ulf Hansson
2025-10-06 10:54 ` Sudeep Holla [this message]
2025-10-06 12:22 ` Ulf Hansson
2025-10-06 14:41 ` Sudeep Holla
2025-10-10 8:03 ` Ulf Hansson
2025-10-06 15:55 ` Marc Zyngier
2025-10-10 8:30 ` Ulf Hansson
2025-10-10 9:48 ` Marc Zyngier
2025-10-10 9:55 ` Mark Rutland
2025-10-17 14:01 ` Thomas Gleixner
2025-10-20 13:15 ` Ulf Hansson
2025-10-03 15:02 ` [PATCH 3/3] pmdomain: Extend the genpd governor for CPUs to account for IPIs Ulf Hansson
2025-10-06 15:36 ` [PATCH 0/3] pmdomain: Improve idlestate selection for CPUs Sudeep Holla
2025-10-10 7:52 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006-manipulative-urban-antelope-31101f@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=quic_mkshah@quicinc.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox