* [PATCH net v2] net: airoha: Fix loopback mode configuration for GDM2 port
@ 2025-10-08 9:27 Lorenzo Bianconi
2025-10-08 23:17 ` Jacob Keller
2025-10-09 10:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2025-10-08 9:27 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Lorenzo Bianconi
Cc: linux-arm-kernel, linux-mediatek, netdev
Add missing configuration for loopback mode in airhoha_set_gdm2_loopback
routine.
Fixes: 9cd451d414f6e ("net: airoha: Add loopback support for GDM2")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
Changes in v2:
- Use human readable marcos to configure loopback mode register
- Link to v1: https://lore.kernel.org/r/20251005-airoha-loopback-mode-fix-v1-1-d017f78acf76@kernel.org
---
drivers/net/ethernet/airoha/airoha_eth.c | 4 +++-
drivers/net/ethernet/airoha/airoha_regs.h | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
index 81ea01a652b9c545c348ad6390af8be873a4997f..833dd911980b3f698bd7e5f9fd9e2ce131dd5222 100644
--- a/drivers/net/ethernet/airoha/airoha_eth.c
+++ b/drivers/net/ethernet/airoha/airoha_eth.c
@@ -1710,7 +1710,9 @@ static void airhoha_set_gdm2_loopback(struct airoha_gdm_port *port)
airoha_fe_wr(eth, REG_GDM_RXCHN_EN(2), 0xffff);
airoha_fe_rmw(eth, REG_GDM_LPBK_CFG(2),
LPBK_CHAN_MASK | LPBK_MODE_MASK | LPBK_EN_MASK,
- FIELD_PREP(LPBK_CHAN_MASK, chan) | LPBK_EN_MASK);
+ FIELD_PREP(LPBK_CHAN_MASK, chan) |
+ LBK_GAP_MODE_MASK | LBK_LEN_MODE_MASK |
+ LBK_CHAN_MODE_MASK | LPBK_EN_MASK);
airoha_fe_rmw(eth, REG_GDM_LEN_CFG(2),
GDM_SHORT_LEN_MASK | GDM_LONG_LEN_MASK,
FIELD_PREP(GDM_SHORT_LEN_MASK, 60) |
diff --git a/drivers/net/ethernet/airoha/airoha_regs.h b/drivers/net/ethernet/airoha/airoha_regs.h
index e1c15c20be8e13197de743d9b590dc80058560a5..69c5a143db8c079be0a6ecf41081cd3f5048c090 100644
--- a/drivers/net/ethernet/airoha/airoha_regs.h
+++ b/drivers/net/ethernet/airoha/airoha_regs.h
@@ -151,6 +151,9 @@
#define LPBK_LEN_MASK GENMASK(23, 10)
#define LPBK_CHAN_MASK GENMASK(8, 4)
#define LPBK_MODE_MASK GENMASK(3, 1)
+#define LBK_GAP_MODE_MASK BIT(3)
+#define LBK_LEN_MODE_MASK BIT(2)
+#define LBK_CHAN_MODE_MASK BIT(1)
#define LPBK_EN_MASK BIT(0)
#define REG_GDM_TXCHN_EN(_n) (GDM_BASE(_n) + 0x24)
---
base-commit: 1b54b0756f051c11f5a5d0fbc1581e0b9a18e2bc
change-id: 20251005-airoha-loopback-mode-fix-3a9c0036017e
Best regards,
--
Lorenzo Bianconi <lorenzo@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] net: airoha: Fix loopback mode configuration for GDM2 port
2025-10-08 9:27 [PATCH net v2] net: airoha: Fix loopback mode configuration for GDM2 port Lorenzo Bianconi
@ 2025-10-08 23:17 ` Jacob Keller
2025-10-09 10:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jacob Keller @ 2025-10-08 23:17 UTC (permalink / raw)
To: Lorenzo Bianconi, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-arm-kernel, linux-mediatek, netdev
[-- Attachment #1.1: Type: text/plain, Size: 2420 bytes --]
On 10/8/2025 2:27 AM, Lorenzo Bianconi wrote:
> Add missing configuration for loopback mode in airhoha_set_gdm2_loopback
> routine.
>
> Fixes: 9cd451d414f6e ("net: airoha: Add loopback support for GDM2")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> Changes in v2:
> - Use human readable marcos to configure loopback mode register
> - Link to v1: https://lore.kernel.org/r/20251005-airoha-loopback-mode-fix-v1-1-d017f78acf76@kernel.org
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> drivers/net/ethernet/airoha/airoha_eth.c | 4 +++-
> drivers/net/ethernet/airoha/airoha_regs.h | 3 +++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
> index 81ea01a652b9c545c348ad6390af8be873a4997f..833dd911980b3f698bd7e5f9fd9e2ce131dd5222 100644
> --- a/drivers/net/ethernet/airoha/airoha_eth.c
> +++ b/drivers/net/ethernet/airoha/airoha_eth.c
> @@ -1710,7 +1710,9 @@ static void airhoha_set_gdm2_loopback(struct airoha_gdm_port *port)
> airoha_fe_wr(eth, REG_GDM_RXCHN_EN(2), 0xffff);
> airoha_fe_rmw(eth, REG_GDM_LPBK_CFG(2),
> LPBK_CHAN_MASK | LPBK_MODE_MASK | LPBK_EN_MASK,
> - FIELD_PREP(LPBK_CHAN_MASK, chan) | LPBK_EN_MASK);
> + FIELD_PREP(LPBK_CHAN_MASK, chan) |
> + LBK_GAP_MODE_MASK | LBK_LEN_MODE_MASK |
> + LBK_CHAN_MODE_MASK | LPBK_EN_MASK);
> airoha_fe_rmw(eth, REG_GDM_LEN_CFG(2),
> GDM_SHORT_LEN_MASK | GDM_LONG_LEN_MASK,
> FIELD_PREP(GDM_SHORT_LEN_MASK, 60) |
> diff --git a/drivers/net/ethernet/airoha/airoha_regs.h b/drivers/net/ethernet/airoha/airoha_regs.h
> index e1c15c20be8e13197de743d9b590dc80058560a5..69c5a143db8c079be0a6ecf41081cd3f5048c090 100644
> --- a/drivers/net/ethernet/airoha/airoha_regs.h
> +++ b/drivers/net/ethernet/airoha/airoha_regs.h
> @@ -151,6 +151,9 @@
> #define LPBK_LEN_MASK GENMASK(23, 10)
> #define LPBK_CHAN_MASK GENMASK(8, 4)
> #define LPBK_MODE_MASK GENMASK(3, 1)
> +#define LBK_GAP_MODE_MASK BIT(3)
> +#define LBK_LEN_MODE_MASK BIT(2)
> +#define LBK_CHAN_MODE_MASK BIT(1)
> #define LPBK_EN_MASK BIT(0)
>
> #define REG_GDM_TXCHN_EN(_n) (GDM_BASE(_n) + 0x24)
>
> ---
> base-commit: 1b54b0756f051c11f5a5d0fbc1581e0b9a18e2bc
> change-id: 20251005-airoha-loopback-mode-fix-3a9c0036017e
>
> Best regards,
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] net: airoha: Fix loopback mode configuration for GDM2 port
2025-10-08 9:27 [PATCH net v2] net: airoha: Fix loopback mode configuration for GDM2 port Lorenzo Bianconi
2025-10-08 23:17 ` Jacob Keller
@ 2025-10-09 10:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-09 10:00 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-arm-kernel,
linux-mediatek, netdev
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 08 Oct 2025 11:27:43 +0200 you wrote:
> Add missing configuration for loopback mode in airhoha_set_gdm2_loopback
> routine.
>
> Fixes: 9cd451d414f6e ("net: airoha: Add loopback support for GDM2")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> Changes in v2:
> - Use human readable marcos to configure loopback mode register
> - Link to v1: https://lore.kernel.org/r/20251005-airoha-loopback-mode-fix-v1-1-d017f78acf76@kernel.org
>
> [...]
Here is the summary with links:
- [net,v2] net: airoha: Fix loopback mode configuration for GDM2 port
https://git.kernel.org/netdev/net/c/fea8cdf6738a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-09 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-08 9:27 [PATCH net v2] net: airoha: Fix loopback mode configuration for GDM2 port Lorenzo Bianconi
2025-10-08 23:17 ` Jacob Keller
2025-10-09 10:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).