Re: [PATCH v2 1/4] dt-bindings: usb: dwc3: Add Google Tensor G5 DWC3

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

On Wed, Oct 08, 2025 at 09:40:57PM -0700, Roy Luo wrote:
> On Wed, Oct 8, 2025 at 1:58 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Oct 08, 2025 at 05:59:57AM +0000, Roy Luo wrote:

> > > +allOf:
> > > +  - $ref: snps,dwc3-common.yaml#
> > > +
> > > +unevaluatedProperties: false
> >
> > So every property from snps,dwc3-common.yaml is valid here, with any of
> > the permitted values?
> 
> Conor,
> 
> Appreciate the review.
> Ack to all the comments, will fix them in the next patch.
> And yes, every property from snps,dwc3-common.yaml is valid here.
> You can find more context here [1], essentially the dwc3 glue would be
> operating on the same platform device as the dwc3 core, hence all
> properties are allowed.
> 
> [1] https://lore.kernel.org/all/20250414-dwc3-refactor-v7-0-f015b358722d@oss.qualcomm.com/

I find it exceedingly hard to believe that every property from that
file, with every permitted value, is possible. AFAIU, the tensor g5 is a
phone chip that's only used in pixel devices, not something that people
can just buy and integrate into whatever device they feel like. There
should be a vanishingly small number of possible configurations,
possibly exactly one configuration. There are dozens of properties in
the dwc3 common binding, of which at least 10 are for "quirks" or other
sorts of hardware errata that are not going to be variable from one
phone to another.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]