From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25F4FCCD184 for ; Sat, 11 Oct 2025 17:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0w+B/tCledBrlOq6HIpAHqdVg2SY76LtseeOT2jub/4=; b=IkXox8LS+6i45jpTlNq1dd+DMp 8SwJEkFKS25OI3Dtm5Am3uFDdNCfnFE7ybP16bxhTMydzWjsn2eL0Nke4UQr4aItnjvyYd2qgKalY Lkg9KufMMxkhmzaedETc5MbtjUasPIIUa+j2S0gQAUCIBO7LlElrxzQqr0/8ioaIUvj848t/su2gE 6AHVPNlZQt92PfXkFYBn9FCHjSO0+ZpUAZcoQn8I7EeC3kwIy35wbj39HraObho25HbyaE6aBp9Ct +YBw4P7HrxSgSZZbCzXk/O/fnzqE+QXQqsab30EyXfapGu6ZxLObNun0jmzRPygRB+UzHM5LhLaKL CMhMomCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v7d8s-0000000AQAs-3AEH; Sat, 11 Oct 2025 17:12:26 +0000 Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v7d8p-0000000AQA5-3cJg for linux-arm-kernel@lists.infradead.org; Sat, 11 Oct 2025 17:12:25 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4ckVMj5NPpz9tCk; Sat, 11 Oct 2025 19:04:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1760202273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0w+B/tCledBrlOq6HIpAHqdVg2SY76LtseeOT2jub/4=; b=RVIAzvfQHpCMffZm841KON3A5nvmrP8XNbIn5GMdR19rO/ZO1vQOEPTbNuFqM9CNg/ZnLQ DPHB2Dcn0GoUjW8sW0KxsK6JIq+nAO5RcHv+XE57jD+UxMqUmyDlfUTFEUysT320qvG5ve t92iVj4w2fa03FUII4WNySbovgSqTnV6m+vZ5N2rXa0SxnUpZLrQ4p6BtaVKtqmQJKMKjw ekGQoID+YFVqEr0s8qQN1zbs+KOFfJObzIGJnB4+I5kNRhdPByF1swJVjnjgEjFZp/QLtb RTK+vLtOAsBX2VVPlWmrtjUTfrUsq7IwCq5cCsQiKkapICICgW3teDZTqw/ywQ== From: Marek Vasut DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1760202271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0w+B/tCledBrlOq6HIpAHqdVg2SY76LtseeOT2jub/4=; b=mUixiEpwpW3c3V4Ub2e7psSTx6UmwmLgemrJ9G9/0NCMPJSFCpExucMvy+As8H1VglndLL q69EBWzx/vlHHpQf3d8pOBOVu6q8NGRZ7ZLKJzuFNynjCoHqueMaBeQNIsC0OD+AZXUcjX pHkgU+t77KsVL3QnSSo97HRjxpi6mhX1ZLLT1cd/xgpQ5VKGtHtO5rhQ37oE8oAPofUrQT jwe9VWf0dGPm5qZfPm/9Yi1nhCKgcQjOY2q3eodUD8TT0ZzT1sdyvAncbSpn2OxIoD247E z6BQYvxQumaWj6OOxlHntzSl429kgVhZcdEoDBNDB16lmFHTHNvh8wJqvBif+g== To: dri-devel@lists.freedesktop.org Cc: Marek Vasut , Abel Vesa , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , Liu Ying , Lucas Stach , Peng Fan , Pengutronix Kernel Team , Rob Herring , Shawn Guo , Thomas Zimmermann , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: [PATCH 35/39] drm/bridge: fsl-ldb: Parse register offsets from DT Date: Sat, 11 Oct 2025 18:51:50 +0200 Message-ID: <20251011170213.128907-36-marek.vasut@mailbox.org> In-Reply-To: <20251011170213.128907-1-marek.vasut@mailbox.org> References: <20251011170213.128907-1-marek.vasut@mailbox.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-RS-ID: ea661708900ef395549 X-MBO-RS-META: kd9wg3mdhk94dhn81apjjnztjthnmakq X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251011_101224_040039_11872CA0 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The DT binding for this bridge describe register offsets for the LDB, parse the register offsets from DT instead of hard-coding them in the driver. No functional change. Signed-off-by: Marek Vasut --- Cc: Abel Vesa Cc: Conor Dooley Cc: Fabio Estevam Cc: Krzysztof Kozlowski Cc: Laurent Pinchart Cc: Liu Ying Cc: Lucas Stach Cc: Peng Fan Cc: Pengutronix Kernel Team Cc: Rob Herring Cc: Shawn Guo Cc: Thomas Zimmermann Cc: devicetree@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: imx@lists.linux.dev Cc: linux-arm-kernel@lists.infradead.org Cc: linux-clk@vger.kernel.org --- drivers/gpu/drm/bridge/fsl-ldb.c | 42 ++++++++++++++++++++------------ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 5c3cf37200bce..c54caea0b63fc 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -61,24 +61,16 @@ enum fsl_ldb_devtype { }; struct fsl_ldb_devdata { - u32 ldb_ctrl; - u32 lvds_ctrl; bool lvds_en_bit; bool single_ctrl_reg; }; static const struct fsl_ldb_devdata fsl_ldb_devdata[] = { [IMX6SX_LDB] = { - .ldb_ctrl = 0x18, .single_ctrl_reg = true, }, - [IMX8MP_LDB] = { - .ldb_ctrl = 0x5c, - .lvds_ctrl = 0x128, - }, + [IMX8MP_LDB] = { }, [IMX93_LDB] = { - .ldb_ctrl = 0x20, - .lvds_ctrl = 0x24, .lvds_en_bit = true, }, }; @@ -90,6 +82,8 @@ struct fsl_ldb { struct clk *clk; struct regmap *regmap; const struct fsl_ldb_devdata *devdata; + u32 ldb_ctrl; + u32 lvds_ctrl; bool ch0_enabled; bool ch1_enabled; }; @@ -204,7 +198,7 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, reg |= (fsl_ldb->ch0_enabled ? LDB_CTRL_DI0_VSYNC_POLARITY : 0) | (fsl_ldb->ch1_enabled ? LDB_CTRL_DI1_VSYNC_POLARITY : 0); - regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->ldb_ctrl, reg); + regmap_write(fsl_ldb->regmap, fsl_ldb->ldb_ctrl, reg); if (fsl_ldb->devdata->single_ctrl_reg) return; @@ -212,7 +206,7 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, /* Program LVDS_CTRL */ reg = LVDS_CTRL_CC_ADJ(2) | LVDS_CTRL_PRE_EMPH_EN | LVDS_CTRL_PRE_EMPH_ADJ(3) | LVDS_CTRL_VBG_EN; - regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->lvds_ctrl, reg); + regmap_write(fsl_ldb->regmap, fsl_ldb->lvds_ctrl, reg); /* Wait for VBG to stabilize. */ usleep_range(15, 20); @@ -220,7 +214,7 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, reg |= (fsl_ldb->ch0_enabled ? LVDS_CTRL_CH0_EN : 0) | (fsl_ldb->ch1_enabled ? LVDS_CTRL_CH1_EN : 0); - regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->lvds_ctrl, reg); + regmap_write(fsl_ldb->regmap, fsl_ldb->lvds_ctrl, reg); } static void fsl_ldb_atomic_disable(struct drm_bridge *bridge, @@ -231,12 +225,12 @@ static void fsl_ldb_atomic_disable(struct drm_bridge *bridge, /* Stop channel(s). */ if (fsl_ldb->devdata->lvds_en_bit) /* Set LVDS_CTRL_LVDS_EN bit to disable. */ - regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->lvds_ctrl, + regmap_write(fsl_ldb->regmap, fsl_ldb->lvds_ctrl, LVDS_CTRL_LVDS_EN); else if (!fsl_ldb->devdata->single_ctrl_reg) - regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->lvds_ctrl, 0); - regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->ldb_ctrl, 0); + regmap_write(fsl_ldb->regmap, fsl_ldb->lvds_ctrl, 0); + regmap_write(fsl_ldb->regmap, fsl_ldb->ldb_ctrl, 0); clk_disable_unprepare(fsl_ldb->clk); } @@ -296,7 +290,7 @@ static int fsl_ldb_probe(struct platform_device *pdev) struct device_node *remote1, *remote2; struct drm_panel *panel; struct fsl_ldb *fsl_ldb; - int dual_link; + int dual_link, idx, ret; fsl_ldb = devm_drm_bridge_alloc(dev, struct fsl_ldb, bridge, &funcs); if (IS_ERR(fsl_ldb)) @@ -309,6 +303,22 @@ static int fsl_ldb_probe(struct platform_device *pdev) fsl_ldb->dev = &pdev->dev; fsl_ldb->bridge.of_node = dev->of_node; + idx = of_property_match_string(dev->of_node, "reg-names", "ldb"); + if (idx < 0) + return idx; + + ret = of_property_read_u32_index(dev->of_node, "reg", 2 * idx, &fsl_ldb->ldb_ctrl); + if (ret) + return ret; + + idx = of_property_match_string(dev->of_node, "reg-names", "lvds"); + if (idx < 0) + return idx; + + ret = of_property_read_u32_index(dev->of_node, "reg", 2 * idx, &fsl_ldb->lvds_ctrl); + if (ret) + return ret; + fsl_ldb->clk = devm_clk_get(dev, "ldb"); if (IS_ERR(fsl_ldb->clk)) return PTR_ERR(fsl_ldb->clk); -- 2.51.0