From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org, "Antoine Tenart" <atenart@kernel.org>,
devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>
Subject: [PATCH net-next v14 15/16] net: phy: dp83822: Add SFP support through the phy_port interface
Date: Mon, 13 Oct 2025 16:31:41 +0200 [thread overview]
Message-ID: <20251013143146.364919-16-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20251013143146.364919-1-maxime.chevallier@bootlin.com>
The DP83822 can support 100BaseFX. This mode was only accessible through
custom DT properties, but there also exist SFP modules that support
these modes. As this only requires setting the relevant supported
interface in the driver, expose the port capability with the new
phy_port API, allowing SFP support.
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/phy/dp83822.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index c6e5b7244658..94036e5af242 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -980,6 +980,13 @@ static int dp83822_attach_mdi_port(struct phy_device *phydev,
}
}
+ /* If attached from SFP, is_mii is set, but not the mediums. */
+ if (port->is_mii)
+ dp83822->fx_enabled = true;
+
+ if (dp83822->fx_enabled)
+ __set_bit(PHY_INTERFACE_MODE_100BASEX, port->interfaces);
+
return 0;
}
--
2.49.0
next prev parent reply other threads:[~2025-10-13 14:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 14:31 [PATCH net-next v14 00/16] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 01/16] dt-bindings: net: Introduce the ethernet-connector description Maxime Chevallier
2025-10-30 12:13 ` Maxime Chevallier
2025-10-30 13:23 ` Andrew Lunn
2025-10-30 14:50 ` Maxime Chevallier
2025-10-30 15:01 ` Andrew Lunn
2025-10-30 15:12 ` Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 02/16] net: ethtool: common: Indicate that BaseT works on up to 4 lanes Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 03/16] net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values Maxime Chevallier
2025-10-22 21:42 ` Andrew Lunn
2025-10-23 7:43 ` Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 04/16] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 05/16] net: phy: dp83822: Add support for phy_port representation Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 06/16] dt-bindings: net: dp83822: Deprecate ti,fiber-mode Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 07/16] net: phy: Create a phy_port for PHY-driven SFPs Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 08/16] net: phy: Introduce generic SFP handling for PHY drivers Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 09/16] net: phy: marvell-88x2222: Support SFP through phy_port interface Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 10/16] net: phy: marvell: " Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 11/16] net: phy: marvell10g: Support SFP through phy_port Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 12/16] net: phy: at803x: Support SFP through phy_port interface Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 13/16] net: phy: qca807x: " Maxime Chevallier
2025-10-13 14:31 ` [PATCH net-next v14 14/16] net: phy: Only rely on phy_port for PHY-driven SFP Maxime Chevallier
2025-10-13 14:31 ` Maxime Chevallier [this message]
2025-10-13 14:31 ` [PATCH net-next v14 16/16] Documentation: networking: Document the phy_port infrastructure Maxime Chevallier
2025-10-21 1:52 ` [PATCH net-next v14 00/16] net: phy: Introduce PHY ports representation Jakub Kicinski
2025-10-21 8:09 ` Maxime Chevallier
2025-10-21 15:07 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013143146.364919-16-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).