From: Leo Yan <leo.yan@arm.com>
To: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
James Clark <james.clark@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Leo Yan <leo.yan@arm.com>
Subject: [PATCH] perf: arm_spe: Ensure trace is disabled when TRUNCATED flag is set
Date: Wed, 15 Oct 2025 19:23:37 +0100 [thread overview]
Message-ID: <20251015-arm_spe_fix_truncated_flag-v1-1-555e328cba05@arm.com> (raw)
The TRUNCATED flag can be set in the following cases:
1. When data loss is detected (PMBSR_EL1.DL == 0b1).
2. When arm_spe_perf_aux_output_begin() fails to find a valid limit
because it runs out of free space.
Currently, only the first case invokes irq_work_run() to execute the
event disable callback, while the second case does not.
Move the call to irq_work_run() later with checking the TRUNCATED flag,
so that both cases are handled and redundant calls are avoided.
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
drivers/perf/arm_spe_pmu.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
index fa50645feddadbea5dc1e404f80f62cf5aa96fd4..05ba977f75d607a1d524f68694db9ea18a6ef20c 100644
--- a/drivers/perf/arm_spe_pmu.c
+++ b/drivers/perf/arm_spe_pmu.c
@@ -731,12 +731,6 @@ static irqreturn_t arm_spe_pmu_irq_handler(int irq, void *dev)
if (act == SPE_PMU_BUF_FAULT_ACT_SPURIOUS)
return IRQ_NONE;
- /*
- * Ensure perf callbacks have completed, which may disable the
- * profiling buffer in response to a TRUNCATION flag.
- */
- irq_work_run();
-
switch (act) {
case SPE_PMU_BUF_FAULT_ACT_FATAL:
/*
@@ -765,6 +759,15 @@ static irqreturn_t arm_spe_pmu_irq_handler(int irq, void *dev)
break;
}
+ /*
+ * The TRUNCATED flag is set when data loss is detected by PMBSR_EL1.DL,
+ * or arm_spe_perf_aux_output_begin() sets the flag if runs out of free
+ * space. Ensure that all perf callbacks have completed for disabling
+ * the profiling buffer.
+ */
+ if (handle->aux_flags & PERF_AUX_FLAG_TRUNCATED)
+ irq_work_run();
+
/* The buffer pointers are now sane, so resume profiling. */
write_sysreg_s(0, SYS_PMBSR_EL1);
return IRQ_HANDLED;
---
base-commit: 1f4a222b0e334540343fbb5d3eac4584a6bfe180
change-id: 20251015-arm_spe_fix_truncated_flag-1a5b3620a3ab
Best regards,
--
Leo Yan <leo.yan@arm.com>
next reply other threads:[~2025-10-15 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 18:23 Leo Yan [this message]
2025-11-03 14:14 ` [PATCH] perf: arm_spe: Ensure trace is disabled when TRUNCATED flag is set Will Deacon
2025-11-03 17:14 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015-arm_spe_fix_truncated_flag-v1-1-555e328cba05@arm.com \
--to=leo.yan@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox