From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82D6ECCD18E for ; Wed, 15 Oct 2025 05:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc: To:From:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=vkfC6oyc+tLRX6pAwVB+5VChWivTatMtNmzCnEAtV8E=; b=lOJmG5Ydhfi2693zwUbvRdTH31 /mDDvobeTjYg2BbbD5w2iyepNvGW4BPd4MJEpKjNOhUZIl7/n+TZypDl/KeF1SluofTikOrWiYMuI E2gnfQSmTPdMR+YYmx+moxcN+U4cj2CyVszY9yLlGrAHnGmh349Cu0EQBG/gkn9VLvF9zzV9Yihrp un085pSFDNnYoYu5l0D1IlWJqKsRbeUos99gtqD9WI52DH2VDb+vyWNNkDISFpYO7qQWQmKTibU3t A9KUI3doZJqppktu3QKM6MQbVUK1KIsmIsE2ckbJv2o0i5Gquw+3lEn2/jd1NuKgIeyktALF/8UTO 6kLRd1cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8trn-00000000UwU-0RiH; Wed, 15 Oct 2025 05:16:03 +0000 Received: from m16.mail.163.com ([220.197.31.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8trj-00000000Uvk-2bkC for linux-arm-kernel@lists.infradead.org; Wed, 15 Oct 2025 05:16:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id; bh=vkfC6oyc+tLRX6p AwVB+5VChWivTatMtNmzCnEAtV8E=; b=IZCxiCu/r6Hb/EqJWciCLAtIAxvXOZp mcNdDpjjx/DQqiT0He8sYn6aK/VnrTICv5kjxM3e/38lGkunTWsv4Ix2bpHcWNK1 o1Lewgfy3VxxtMkdIclIkVsRLDogrEOXlwucgVA+OsTW/m8LkwGFWsuxZOVV705n 4ydacRZzF2zk= Received: from localhost.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PygvCgB3A5TILe9ovbHOAA--.30995S2; Wed, 15 Oct 2025 13:15:06 +0800 (CST) From: Lizhe To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, jonas@kwiboo.se, chaoyi.chen@rock-chips.com, david.wu@rock-chips.com Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lizhe Subject: [PATCH net-next] net: dwmac-rk: No need to check the return value of phy_power_on() Date: Tue, 14 Oct 2025 22:14:46 -0700 Message-Id: <20251015051446.2677-1-sensor1010@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: PygvCgB3A5TILe9ovbHOAA--.30995S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ww4xKw13WFyfXr15Gr4fGrg_yoW8tr13pa 93GF9Fyr1kXa4xGa12yFsrZa45C3y3try0qF1xA34ruF13AF1Dtr10yryFvF1j9rykXFya yr4UAF1xC3Z8ur7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRrb1bUUUUU= X-Originating-IP: [112.4.48.30] X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/1tbiKBrnq2jvHAA8gQABsZ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251014_221600_094055_789218D5 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 'phy_power_on' is a local scope one within the driver, since the return value of the phy_power_on() function is always 0, checking its return value is redundant. the function name 'phy_power_on()' conflicts with the existing phy_power_on() function in the PHY subsystem. a suitable alternative name would be rk_phy_power_set(), particularly since when the second argument is false, this function actually powers off the PHY Signed-off-by: Lizhe --- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 51ea0caf16c1..ac3324430b2d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1461,23 +1461,18 @@ static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable) return 0; } -static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable) +static void rk_phy_power_set(struct rk_priv_data *bsp_priv, bool enable) { struct regulator *ldo = bsp_priv->regulator; struct device *dev = bsp_priv->dev; - int ret; if (enable) { - ret = regulator_enable(ldo); - if (ret) + if (regulator_enable(ldo)) dev_err(dev, "fail to enable phy-supply\n"); } else { - ret = regulator_disable(ldo); - if (ret) + if (regulator_disable(ldo)) dev_err(dev, "fail to disable phy-supply\n"); } - - return 0; } static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev, @@ -1655,11 +1650,7 @@ static int rk_gmac_powerup(struct rk_priv_data *bsp_priv) dev_err(dev, "NO interface defined!\n"); } - ret = phy_power_on(bsp_priv, true); - if (ret) { - gmac_clk_enable(bsp_priv, false); - return ret; - } + rk_phy_power_set(bsp_priv, true); pm_runtime_get_sync(dev); @@ -1676,7 +1667,7 @@ static void rk_gmac_powerdown(struct rk_priv_data *gmac) pm_runtime_put_sync(gmac->dev); - phy_power_on(gmac, false); + rk_phy_power_set(gmac, false); gmac_clk_enable(gmac, false); } -- 2.17.1