From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F211CCD18E for ; Wed, 15 Oct 2025 12:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0hpnPQiRP3FNHD7iq56gdTDMHg7THYND/+0IMnv3ckE=; b=of7thEpQl8tOo+P29H0UKivxAn /4dd5zAqA7Fp2abyPfRcz3NzselKTJB7/UwQGzDprvCxRIkQeWz1b/THD73Cf/L0bp8WQD5Nme8KV IOiGdDXxz472mqI5D2sNdCUVO/qWsxRlGSM9aHo0PxvAG1I/YkgTMnLHvN9LP3/EIPwT1EHPR4mGt ezinabqSFwYNnMGqSmbphM9InyW2RuNnHP+NL17Sbfrh0LiGiR54Hd0BUIHpEyOhb9cK4Fgf7Qqvp AaWTAku6McC5bQmz2DciFINzfsgWal/mkyQGVWfIU5QpGm05DtKu0Zb91V5/yrptItfANsLQOutG9 Zifbc9FQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v90qM-00000001aI2-1cET; Wed, 15 Oct 2025 12:43:02 +0000 Received: from mail-francesouthazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c207::3] helo=MRWPR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v90qJ-00000001aFq-0Z35 for linux-arm-kernel@lists.infradead.org; Wed, 15 Oct 2025 12:43:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WDNfChs9YjtHUmFx00MxyVVIDfq3Q+RIJIhwldjObOfqaiiTheo1DRBBMPB0QmmMI0fBH/d//uUkAXrYqH93AqKekNcPxytQWnPxqv/p0P1JBUGa9uhQZuD1Y2nwTanqEzfNxs22BhAIemPaNtt7HZ0Ux9TPU9Lqkz+M9MOZ0A3Zk4aZI7/0oDBVZRI1kTyI9dZairs1/XlhYZhT88K1o3+Oh93SgNbjLELPJPWwOlmg7mZDgPVWllh70Kx6Zle6hYH/5AJkdzlsgZsmpRoRi+aBLqxdfoD7Sl4u9S24wbKmr2FrH3bleivd+mSHNfcW/VSD9SRsP1MAuwRqOBZCYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0hpnPQiRP3FNHD7iq56gdTDMHg7THYND/+0IMnv3ckE=; b=vgvK7YfKJAceSuPKRYl5V+ufAydqWw9nYwBpE/5oKD7uiISiOQVogFY4Y7fbbILahjjcQYFlGPNicEAb7FR54mg0Luw4azw9kjs7z48DYyqCKXJo6buBDXdhg2WSAVbm9dgjZMqII5ivYODquvYyycYSfC60eiPnpUmCkWGGeee89nQj1Mj7M0MV44sqKpe651qusfqRLbDHu5mTjHrt7yz5AchDVY+vLjTjCcmHuMkMrLJQxxjjfqPD0WARxxt2fpYxs0A6MqTMvdGSJS5CJj3hskQi/3i9XHgqDDMRG6bjgM1lqg+AA6BBV6ZMtX4mkH5kODeCgnC/cgJxZeEEXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0hpnPQiRP3FNHD7iq56gdTDMHg7THYND/+0IMnv3ckE=; b=x66N/t51Pnl7WCliaQKNxYiZoYGJd/KrJunqW5N7k0AtY/oEEpa34KboNa7nqjxbEDkCcwsliuOjpnuL5G76CTs/jLjWFilMYwNYiKSj11LZBedMOSQsJGu6sE513ZNLDQ3sZqYsC5LBHAKpfPOUGDlGq1sBwmcET8EBXF+mtDcgkuNFaOjKIAMZU4wfT/SAnBqYYgB/pvCtUeDY7LyjhXJMjWnoyUShxbSuheVA3PL3RBut6pT+NHmPtGsxR+89hJJVEVOZ0+gVj07qIrSxCAvvrq8kPpS3JGzkHQ/5dxriZIKWEtd1RLEDjJRSM6awjcyMBx9LXbL36c8j6VGUyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8284.eurprd04.prod.outlook.com (2603:10a6:10:25e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9203.13; Wed, 15 Oct 2025 12:42:49 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9228.010; Wed, 15 Oct 2025 12:42:48 +0000 Date: Wed, 15 Oct 2025 21:55:03 +0800 From: Peng Fan To: Frank Li Cc: Peng Fan , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dong Aisheng , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] firmware: imx: scu-irq: Free mailbox client on failure Message-ID: <20251015135503.GA31091@nxa18884-linux.ap.freescale.net> References: <20251014-imx-firmware-v1-0-ba00220613ca@nxp.com> <20251014-imx-firmware-v1-2-ba00220613ca@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: SG2PR02CA0047.apcprd02.prod.outlook.com (2603:1096:3:18::35) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8284:EE_ X-MS-Office365-Filtering-Correlation-Id: d681db4b-a988-4a80-7578-08de0be858f9 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ll7QJ6sxzFI2GDsa3x2ehioG5Mp0q/DkGxdVFGji4ju98gtqFh3+rfRVlGYs?= =?us-ascii?Q?RrMU6M411IezEvi/aXe3OevLGdLcyMRAvEg6NpJiOYmwb46xfCfDso4ES4c7?= =?us-ascii?Q?3jrb5OMV9UIGgSV5+kq+AbU9GW3L3VFQhtsA/OGh5NVU7P3xC3BymnAcSDsn?= =?us-ascii?Q?PjyfkRIBZjwc/dvCLVTCYLR9/XA9x3l7wQ/oDfPD6YcOxXbT63UlkirptKug?= =?us-ascii?Q?lO7/xFMmV0Uljw5Sq5GKudKRmPDS8MO0PboNIXy54hPt3xhUlpSDHPtAv/mz?= =?us-ascii?Q?E7amODTpolOaMiIqyIwM/MIMk8Dhudxau1RgJbw/A/3Y+kKUv178MIRTcSun?= =?us-ascii?Q?fcxf8pA6SYVmFlxt4yGt16uMf4m4Q/zYPOglV2okH3LY8gmurbG3Mtve/ptA?= =?us-ascii?Q?sH+rmr5qTb/wdXbC3tFt245jz2xyb3ulbhX6Nd85fvr4EteCXE09L0oxKkY3?= =?us-ascii?Q?7Qb0qU8hVILwBrSD5Byw0BO7pLfnMCnUtByRPs08tZJdHVQX59OAMXtpIWkK?= =?us-ascii?Q?oW8ywbAleeKaNlTY9aJThPmbgWi8AqPoLZWPxl5YOVtstxMC0cMngxUGwWPg?= =?us-ascii?Q?InmMAry/akLky4EHlad/3MexJFeyCxM/7Ghiogx406IL2CVmxtqBNhK2Et4n?= =?us-ascii?Q?wjNX4cbXkaSwfgbbOWmikEIz2/LdRuicf1qsrtErKgUaEWdenq0efINSH9K1?= =?us-ascii?Q?+V266AozoFuSjW3rYFihRnNkkA3BeS6ydrrsNlO1ue2S4YDTzX4bghtzrITL?= =?us-ascii?Q?vrg70nqp/vrxB6VL0kGOciQbQadbb8wfkRtAOjBFvArDblEmIyofTxYiU5ib?= =?us-ascii?Q?9ophy/n1/1gKmy31jCzlGcqc2S+ozaUymSjhh35C41BskWjlcz5usVT76uBs?= =?us-ascii?Q?mxFr11lSl2FNPM2lp+6T9zOca1wqyoLuFm30whzgoQT/DpKV4SwCSsupJnPg?= =?us-ascii?Q?d27rqgVtqTGWVVQE8Z0fG8YUTL2PeD0z28AnP5oRDoUSXCfpbXW+foX60hIb?= =?us-ascii?Q?rKAZ2wJE8RYJsPGFLj0Im7KR9jzUNQqPYGOEUQoSarat7mtZ+pUogOTWqkIk?= =?us-ascii?Q?CJaYa1yddBYyH+ypRbxKG7tXLmwqU/wo2zwcvuLAlBf2ZnfgAw8HJidM87Zb?= =?us-ascii?Q?LvJNX1TMfIHAHl/fR7I0JhbuSA1qkz+67+9FRAcFtQuEacrIWKtLGxdQCIXQ?= =?us-ascii?Q?Z8eDhEo//RsRsflIGWlxmhFEXNfpVEFKApVOs5T2NTRn3sMb/wuXbp7GtkDP?= =?us-ascii?Q?51HeDXaCRrSgCrSp2KSi1rCcoCLrie8XhALhMsV4JL4hq9qI/ae3QqtT5QkS?= =?us-ascii?Q?F0EK39IxOe+lVTx1tsB7XugbL/+hRdZsT8n3Vo2AURN55oy7NcySTB248jCp?= =?us-ascii?Q?UN9eZNm/5a7DhTArH1Hfurzrzcy8EXfSLiof51bZ2EQoyZwY0tqUPKiS+idX?= =?us-ascii?Q?JajhbSAP+ZgzIfJqk8bJOwMFanD9R3inLGGRmabG8TC4NtwhWs9NOHXtqeD+?= =?us-ascii?Q?6D0cwzQZVjH9CkCumENnkX4pGwNtH41FNI1P?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xme/vDP3lTs/07D9Z1LrVCwrMJSdcG2KJolRkmbfCHY6LFPms+HT/veIbfXs?= =?us-ascii?Q?H17jULk4LGVcuWj8NSNzU2ljDUyajnYBzJhjKfYkXoCZ5OQv4hNRNcXAYUbd?= =?us-ascii?Q?x/AjjhkF0JvH07I5k7VgjoNj6Wh2DI7Fq8qcdcHL1H7Y5HBVSE7qkDcNqk1P?= =?us-ascii?Q?h1s4nieHsjp0LA+zmRsIuSSQ/DmkuVXCeWJRubznQkmQCrFMOR36wsIGM5co?= =?us-ascii?Q?IlJFe/1tMIUZUkvU2E+WoBssBzUHK9kdMSgQjb8MAz/YCKk0ZjTyNOCPXBeW?= =?us-ascii?Q?yFNBHerO4oVi+9wi0WF8zqt9fw0AmZciOU3re1rYPfB5tMPyPS0vcy14n2ya?= =?us-ascii?Q?qaXbzN8HC2pk+pWX01WNTtthqz+MrwNEY3L5Tt0tTTvnid/O6+J+TX+rzcKA?= =?us-ascii?Q?TcuKl1TMvR/wUKMPs22Zmu3UEULCc7HnmEnqIM3GT9G6XNXsYz/2TKHExF3f?= =?us-ascii?Q?NWwWLzuj4BBF+16G2vQri0Dlf2thXVxRmXsyY6DEQqT7gxaeDlPd6OHSKmGm?= =?us-ascii?Q?K2bBHOX+KZSOstyigWC7G9JIcS4P4H7c++b5ZsRn+gjpnOYnC9fYXXRUG0Yi?= =?us-ascii?Q?o6Cmec8rkKsH9JJf8cPDlWg9KBZGl+na3gWExFgkzbPEASNwFVbzfsCngmI6?= =?us-ascii?Q?Xz01hCSKHcFl/beTJqEdqnes8Hlc4+oo1xszAreLiWkrJe2EpkKw38HKN0vG?= =?us-ascii?Q?BVvZOwYIgmhb56f+WjYw17JllzcFoFNP4Qyl0nVUL39xdt+tGIfo3y/2rg6k?= =?us-ascii?Q?xAx9Xq7XgzC0wAhTe6+146cCQ7/SHYsQsqJgjjj3luZ3EWcs1exhz80HJpu8?= =?us-ascii?Q?0/4Ta6xFr3ZxKmIlpUwU15Bk39avYjh/IqpzkDo1AGcvDYGwbHiSUJqLH1jX?= =?us-ascii?Q?OJYJHRm9ZGLvSKnMHugUTPGRxecD60yp+1KUEY7G1KMhhBSzMiWxCAvytC4y?= =?us-ascii?Q?y8FeN1rN6oFE+5WlxzOpljHgahIeBARj6gY0ohGeZbYp6SPuD8NEj/JZSEBX?= =?us-ascii?Q?EK4ZllDSfYf075SZXXX4pbFAw7izIOW43VXxi/WSTpiOqdV8xSvjRIZibanG?= =?us-ascii?Q?FYhsyglENz0FKMirkiPHRb9a4R61i186A8lGNZDHetFPU08fMAHUC70ShnG9?= =?us-ascii?Q?ycxAeqS+ARaSODM4H+5cUL7esSdyfEEruyoDRDfkxCDAUGhMemZn1kwd4Tau?= =?us-ascii?Q?AyNKDJhZnB6ZMD0Hf+BekzXmCru76hCjnrnc19BEhz8PFRMuORQvTK1n8uln?= =?us-ascii?Q?iPDOjr5Ni8KPewnLdxvPFX+4W5ykZKMh74qykBiTF6kbuaKZwOnCkSEHmRJu?= =?us-ascii?Q?vjZ2ZXvwoeB7hITTzssP5s95MmtIOmqxk4EaYuaSBY3c0lbBIjpICtaW6/Gi?= =?us-ascii?Q?WdZE77kYNuzM5SGDfqswxa0uBzCVkEQNqbGp90xYqg3/TI3nU2tNoyZHPNfl?= =?us-ascii?Q?PVyk0wcBF2GXv9PwH6AQW0NWrnyCGLx7zRgFYveiOckdMFRb75dBCgxnaKLS?= =?us-ascii?Q?KOk6BxUJznB/kHO8aZcENqcnmMc9ul4xcs1vNfIHUgcKtVIfmZFRwlIEwS7+?= =?us-ascii?Q?vLGwr5a8z9a4IioTRCNOm1SUAhqdwqhgyVDjr82P?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d681db4b-a988-4a80-7578-08de0be858f9 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 12:42:48.9416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cM7a+xkBUXptWiVJUgj+ONvVw50DO9h/pKZyWsslxC6NxzuBdKtRU4uNFfqhu203NSfXJflAy20nwGCJdLsp3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8284 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251015_054259_647120_41858BD2 X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 14, 2025 at 11:54:36AM -0400, Frank Li wrote: >On Tue, Oct 14, 2025 at 12:54:39PM +0800, Peng Fan wrote: >> With mailbox channel freed, it is pointless to keep mailbox client. >> So free the mailbox client in err path. >> >> Signed-off-by: Peng Fan >> --- >> drivers/firmware/imx/imx-scu-irq.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c >> index f2b902e95b738fae90af9cbe54da4f488219906f..1fbe4c3de5c1592bfcf2334a83776c25d5ca7a3f 100644 >> --- a/drivers/firmware/imx/imx-scu-irq.c >> +++ b/drivers/firmware/imx/imx-scu-irq.c >> @@ -255,6 +255,7 @@ int imx_scu_enable_general_irq_channel(struct device *dev) >> >> free_ch: >> mbox_free_channel(ch); >> + devm_kfree(dev, cl); > > >you use devm_kmalloc(), when return failure, framework will auto free cl. > >Avoid mixing manual free and management free code. > >So I think this patch is not neccesary. Actually in imx-scu.c, there is only a warning message if this API call returns error. So need to free here. Thanks Peng > >Frank >> >> return ret; >> } >> >> -- >> 2.37.1 >>