Re: [PATCH 0/9] Gernal RK3368 HDMI support and 2 outputs for RK3368-Lion

Diederik de Haas
2025-10-20T10:23:18Z

Hi Heiko,

On Mon Oct 20, 2025 at 10:24 AM CEST, Heiko Stuebner wrote:
> This series adds the necessary bits for HDMI output on RK3368 and enables
> this on RK3368-Lion. At the same time, use the recently added DSI support
> to enable the generic Video-Demo-adapter as an overlay on Lion as well.

I noticed several 'spelling' issues in various patches, therefor
reporting it against the series:

- s/Gernal/General/ ? (series Subject)
- s/internal in the controller/internal to the controller/ (patch 1)

Incorrect/inconsistent casing (not sure about these though):
- s/phy/PHY/ (patch 2)
- s/soc/SoC/ (patch 3 + 7)
- s/hdmi/HDMI/ (patch 7)
- s/vop/VOP/ (patch 7)

- s/the newer one that/the newer ones that/ ? (correct if there is only
1 newer) (patch 3)
- s/devicetree already is set up/devicetree is already set up/ (patch 3)
- s/definitly/definitely/ (patch 4 + 5)
- s/to no cause/to not cause/ (patch 4 + 5)
- s/power-domain property/power-domains property/ (patch 4 + 5)
- s/hirarchy/hierarchy/ (patch 6)
- s/is change at/is changed at/ (patch 6)

Sorry ;-P

Diederik

>
> The reason I'm shaving this Yak is that the recently added DSI support
> created DTC warnings about a single endpoint with an address.
>
> So it was either removing the @0 from the endpoint, or adding a second
> output option :-) .
>
>
> Heiko Stuebner (9):
> dt-bindings: display: rockchip: dw-hdmi: Add compatible for RK3368
> HDMI
> drm/rockchip: hdmi: add RK3368 controller variant
> soc: rockchip: grf: Add select correct PWM implementation on RK3368
> arm64: dts: rockchip: Add power-domain to RK3368 DSI controller
> arm64: dts: rockchip: Add power-domain to RK3368 VOP controller
> arm64: dts: rockchip: Use phandle for i2c_lvds_blc on rk3368-lion
> haikou
> arm64: dts: rockchip: Add HDMI node to RK3368
> arm64: dts: rockchip: Enable HDMI output on RK3368-Lion-Haikou
> arm64: dts: rockchip: Add the Video-Demo overlay for Lion Haikou
>
> .../display/rockchip/rockchip,dw-hdmi.yaml | 1 +
> arch/arm64/boot/dts/rockchip/Makefile | 5 +
> .../rk3368-lion-haikou-video-demo.dtso | 174 ++++++++++++++++++
> .../boot/dts/rockchip/rk3368-lion-haikou.dts | 36 +++-
> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 45 +++++
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++
> drivers/soc/rockchip/grf.c | 1 +
> 7 files changed, 268 insertions(+), 10 deletions(-)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-lion-haikou-video-demo.dtso