From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA573CCD1A7 for ; Tue, 21 Oct 2025 02:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XpUIeAKORNa+0mqCh5r5CTMv5sAuU4DTv+KTTJOd+Bs=; b=UilM5D61ZlMufNFcc2fAYJ+qba DeNLqvNe/7DISAN6wu40atnZkNe7uJrTSUuwrec8CdFmIm6mE/V6bY2fkPHnZOLf+JPPpPRRSEAqw 9FGVzUjS94XI2Qf2ZT0F1vm29C8GilhJWl9SBjy8zw5dhWPTThJUh7SyFeMR42QPAwQCBwZxZ9SAW Q+TQefyJ8spAl7d+z9L04Vc7YVw08/dubPtToWsCWW7/xsMd1Ii2YBj9B/W3yXN9cWX+wZFnCsyvX Mr4rGfuiT6RjjabMvM71pruu+QOwuNvTSM1G9RO4vCbcKvIjB4l9Vj7/GNVFk3Hs5+LIUEfuQTb55 zl72kPnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vB2Yx-0000000Fctq-15Ss; Tue, 21 Oct 2025 02:57:27 +0000 Received: from mail-m32107.qiye.163.com ([220.197.32.107]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vB2Yr-0000000FcpZ-3BuB; Tue, 21 Oct 2025 02:57:23 +0000 Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 26979c631; Tue, 21 Oct 2025 10:57:17 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, p.zabel@pengutronix.de, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, m.szyprowski@samsung.com, luca.ceresoli@bootlin.com, jani.nikula@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v7 09/18] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Date: Tue, 21 Oct 2025 10:56:55 +0800 Message-Id: <20251021025701.1524229-2-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251021025701.1524229-1-damon.ding@rock-chips.com> References: <20251021023130.1523707-1-damon.ding@rock-chips.com> <20251021025701.1524229-1-damon.ding@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9a04b3177b03a3kunmcdd3bf8c5a4090 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGU5DTVYaQ0tNTkIeSh5KTUtWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=e1Iptogem0HGDffUFCEtAEDoi58P4rurfVIuxSPDyoF7aw9DlZiQX2UfLCornFMe8VQ5iq8ghNsis7kv+F5/HFd3uaYEAitkIo5CoqfUePi1UBf3zhjc8U2OTuMXXTThCUuuAkXaPjE3CeQbDYVL3PQp/g4LZGLuXSxhrIfvKDU=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=XpUIeAKORNa+0mqCh5r5CTMv5sAuU4DTv+KTTJOd+Bs=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251020_195722_546846_AF988D35 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The &analogix_dp_plat_data.skip_connector related check can be replaced by &analogix_dp_plat_data.bridge. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov Tested-by: Marek Szyprowski ------ Changes in v3: - Squash the Exynos side commit and the Analogix side commit together. Changes in v4: - Rename the &analogix_dp_plat_data.bridge to &analogix_dp_plat_data.next_bridge. --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +- drivers/gpu/drm/exynos/exynos_dp.c | 1 - include/drm/bridge/analogix_dp.h | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 3caa47d31649..4606ecc3f480 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -959,7 +959,7 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge, return -EINVAL; } - if (!dp->plat_data->skip_connector) { + if (!dp->plat_data->next_bridge) { connector = &dp->connector; connector->polled = DRM_CONNECTOR_POLL_HPD; diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index ac16138a22fe..1eeb0b15f99a 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -200,7 +200,6 @@ static int exynos_dp_probe(struct platform_device *pdev) dp->plat_data.power_on = exynos_dp_poweron; dp->plat_data.power_off = exynos_dp_poweroff; dp->plat_data.attach = exynos_dp_bridge_attach; - dp->plat_data.skip_connector = !!bridge; out: dp->adp = analogix_dp_probe(dev, &dp->plat_data); diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h index 582357c20640..f06da105d8f2 100644 --- a/include/drm/bridge/analogix_dp.h +++ b/include/drm/bridge/analogix_dp.h @@ -30,7 +30,6 @@ struct analogix_dp_plat_data { struct drm_bridge *next_bridge; struct drm_encoder *encoder; struct drm_connector *connector; - bool skip_connector; int (*power_on)(struct analogix_dp_plat_data *); int (*power_off)(struct analogix_dp_plat_data *); -- 2.34.1