linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] firmware: arm_scmi: Add new sensor unit types
@ 2025-10-21 16:52 Artem Shimko
  2025-10-22  8:26 ` Sudeep Holla
  0 siblings, 1 reply; 3+ messages in thread
From: Artem Shimko @ 2025-10-21 16:52 UTC (permalink / raw)
  To: Sudeep Holla, Cristian Marussi
  Cc: a.shimko.dev, arm-scmi, linux-arm-kernel, linux-kernel

Add support for two new sensor unit types introduced in Arm SCMI
- STATE_BINARY (0x5E): Binary state (1: enabled/on, 0: disabled/off)
- BYTES_SEC (0x5F): Bytes per second

These unit types are used for sensors that report binary state information
and data transfer rate measurements respectively.

Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
---
Hello,

This patch adds definitions for two new sensor unit types that were
introduced in the Arm System Control and Management Interface (SCMI)
Specification version 4.0:

STATE_BINARY (0x5E) - Used for sensors that represent binary states
where:
1 indicates enabled/on state
0 indicates disabled/off state

BYTES_SEC (0x5F) - Used for sensors that measure data transfer rates
in bytes per second

These additions ensure compatibility with SCMIv4.0 and allow proper
handling of binary state sensors and bandwidth measurement sensors
in the Linux SCMI driver.

The patch follows the existing pattern for sensor unit type definitions
and maintains backward compatibility with previous SCMI versions.

Thank you for your consideration.

Best regards,
Artem Shimko

 include/linux/scmi_protocol.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h
index aafaac1496b0..629acb7831eb 100644
--- a/include/linux/scmi_protocol.h
+++ b/include/linux/scmi_protocol.h
@@ -488,6 +488,8 @@ enum scmi_sensor_class {
 	CUBIC_METERS_SEC = 0x5B,
 	MM_MERCURY = 0x5C,
 	RADIANS_SEC_SQUARED = 0x5D,
+	STATE_BINARY = 0x5E,
+	BYTES_SEC = 0x5F,
 	OEM_UNIT = 0xFF
 };
 
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] firmware: arm_scmi: Add new sensor unit types
  2025-10-21 16:52 [PATCH] firmware: arm_scmi: Add new sensor unit types Artem Shimko
@ 2025-10-22  8:26 ` Sudeep Holla
  2025-10-22  9:35   ` Artem Shimko
  0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2025-10-22  8:26 UTC (permalink / raw)
  To: Artem Shimko
  Cc: Cristian Marussi, arm-scmi, Sudeep Holla, linux-arm-kernel,
	linux-kernel

On Tue, Oct 21, 2025 at 07:52:11PM +0300, Artem Shimko wrote:
> Add support for two new sensor unit types introduced in Arm SCMI
> - STATE_BINARY (0x5E): Binary state (1: enabled/on, 0: disabled/off)
> - BYTES_SEC (0x5F): Bytes per second
> 
> These unit types are used for sensors that report binary state information
> and data transfer rate measurements respectively.
> 
> Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
> ---
> Hello,
> 
> This patch adds definitions for two new sensor unit types that were
> introduced in the Arm System Control and Management Interface (SCMI)
> Specification version 4.0:
>

It is still alpha, we don't add anything into the kernel unless it is
of beta quality. Do you have a use or you are just adding to match the
spec ?

-- 
Regards,
Sudeep


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] firmware: arm_scmi: Add new sensor unit types
  2025-10-22  8:26 ` Sudeep Holla
@ 2025-10-22  9:35   ` Artem Shimko
  0 siblings, 0 replies; 3+ messages in thread
From: Artem Shimko @ 2025-10-22  9:35 UTC (permalink / raw)
  To: Sudeep Holla; +Cc: Cristian Marussi, arm-scmi, linux-arm-kernel, linux-kernel

On Wed, Oct 22, 2025 at 12:22 PM Sudeep Holla <sudeep.holla@arm.com> wrote:

> It is still alpha, we don't add anything into the kernel unless it is
> of beta quality. Do you have a use or you are just adding to match the
> spec ?
Hi Sudeep,

I'm adding it to meet the specifications.

Trying to be useful

Thank you.

Best regards,
Artem


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-22  9:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-21 16:52 [PATCH] firmware: arm_scmi: Add new sensor unit types Artem Shimko
2025-10-22  8:26 ` Sudeep Holla
2025-10-22  9:35   ` Artem Shimko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).