From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6124BCCD1BE for ; Thu, 23 Oct 2025 14:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L70ISb5udTSOblj/fwUOMONa2wOnc7GX6XtX6syjQ/A=; b=JZ4iFMwC0zih1RIx9BVIW6BQV6 SmWJCsu5D+KWGV4lrOd7ld50NnzpjEdOojkZVVDwG9XR+zV5As1CzAEm5V521XoxV2so55RW5QSdE rK0stS6kf3mLahhT0CgX5vAmJEcPRzcSQHHoed7dsNPCf40AhsLmJof3qBc5+7mn5AKn7tqFnS3Wl d6B6AE348NbMbxYdQ4LeONXWmC6/2JqqXfKQf+U/vIScVWxf0Z9yVuu+eBawYAh0Hi3yPOOeVOvEu rqqagoUlfYZ56HL6giDsGA4XOWJ0LeKtMUGL4koBUri+Xr60aBehnb+W+4DqpvNdiA85diBtON3h1 LKpU6srA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBwHX-00000006ac6-0dsS; Thu, 23 Oct 2025 14:27:11 +0000 Received: from mail-westcentralusazon11013043.outbound.protection.outlook.com ([40.93.201.43] helo=CY3PR05CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBwHU-00000006aap-2Ad6; Thu, 23 Oct 2025 14:27:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zp8r2qlkb8MJUBtASLgWR8tbYPt4j0hjPFfjBf0U1gLqvP/APV339QBhHinJObhJeRWznN4ZGLeQKOazmh+0rNWHD7DL4xI0Xim3suiTTX3IRajV4qSITkxYnBo4H+ffci9RPsikFKJFWJGUVqNxxCDshqPFJnpaE/T4LiRiEKdKd7UmmsoiPw6RbcMqVBXtqWGPssdaRHAU/bG5T3COUj060MCzFz9/+Ra/bb4S6IFe1kOa+yZjQlo3ev+6h9idTOE6nWtoGKJZKMRoGIGAVNJBz5stzOU40P6tkX3Tv26l5jyVzPqH3bG+A7qYhhY1OVHQIkcrgRuHhrQgTUVNoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L70ISb5udTSOblj/fwUOMONa2wOnc7GX6XtX6syjQ/A=; b=VVjSeLxDXb5u2xQmfLsIG4UB8Ao2SunI7hC2BlrivRlhLVBqxxZ8tdVIINqQjllMKbc8rUcK3CYUl/210j819t+VW/Pix6RPqH/IegBqV8kO978M3hvcjRmE7uK546Xk3MiwEkm8I+5DHo6yInBBs/YoXaET4kxo0NeHbIvkUCaTq9e+eeXV7xqShDlS9rnv6XRl0U7+dlRHAgqpHzVbrkljLf/Dq5Us2pvxINvcBdm+aW7PyY1mvZinGByeYN10gMYo5PcskiuBP26FIF2kgFabuVaZSwnT+O9+rqHwDahBVlWzP+8iPbIOdxKAn/2qTciSaZodjVDpYaZqsE6JVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L70ISb5udTSOblj/fwUOMONa2wOnc7GX6XtX6syjQ/A=; b=LaErF0yY2OGFTRdwOOBIuM8AQuBmFbwSZxykaJNzCpKBNMdOLZOh/GpR8OBxMw8RvXzg4sAMQUVTqml+kPykHZ1J9kuBTHwNqCDbE47enKwHswgeDWB9dht48haicoE8Dhz4r2WSEKAMR55TKgbhqaas6knd7I7RGxnf6X0e981MRhoSmV78FQm0g5DrSQxJ+05zn2sQ2EzZP5sSTm1ObnE0e3biWJ8RdayKBDGVXqVXfS+t79lnqKfl1FlMYQ+ELOiJeDN4Qmkx2BSyGVeg0BB5pnmVasd1hOTB+ixTj6cC32/p+ev3eoBBQ2P58zQlGYQKqzB3RFMOmlZdHFIAyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) by DM4PR12MB7743.namprd12.prod.outlook.com (2603:10b6:8:101::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9253.13; Thu, 23 Oct 2025 14:26:58 +0000 Received: from MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b]) by MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b%4]) with mapi id 15.20.9253.011; Thu, 23 Oct 2025 14:26:58 +0000 Date: Thu, 23 Oct 2025 11:26:57 -0300 From: Jason Gunthorpe To: Robin Murphy Cc: AngeloGioacchino Del Regno , Christian Benvenuti , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Joerg Roedel , Leon Romanovsky , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Matthias Brugger , Nelson Escobar , Rob Clark , Samuel Holland , Suravee Suthikulpanit , Chen-Yu Tsai , Will Deacon , Yong Wu , patches@lists.linux.dev Subject: Re: [PATCH 2/3] iommu/amd: Don't call report_iommu_fault() Message-ID: <20251023142657.GH262900@nvidia.com> References: <2-v1-391058a85f30+14b-iommu_set_fault_jgg@nvidia.com> <579bdc4e-ab71-4120-8991-34400d4bbf8d@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <579bdc4e-ab71-4120-8991-34400d4bbf8d@arm.com> X-ClientProxiedBy: MN0PR04CA0026.namprd04.prod.outlook.com (2603:10b6:208:52d::17) To MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB3613:EE_|DM4PR12MB7743:EE_ X-MS-Office365-Filtering-Correlation-Id: c37b7ba0-f2e7-4046-2c9e-08de124038ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?REoMElNXr7jlpZpQ0trkmXGqAvhAtCOVDrUD7ZC3d6Bo4zbmrhp/QmyjCcJc?= =?us-ascii?Q?ACL5mlwUlHjKr5xscknjKDRZk+7eRPIOiAlLDFTYm8aUHRmqdE2cwPs20rxa?= =?us-ascii?Q?MY0ZHiJEqAesUxza8xzvLWghFAELg9Eo7l6b0awNlZJESRnIbsHPlmtRAggR?= =?us-ascii?Q?ljzXKI24GVzeJvL2k0qX1MspcvWSw0sMXN3Z5tuQnVDMFvFg5RjqOyt+zQCe?= =?us-ascii?Q?814mNcCJhybLJs99SgY7SKGoF0mrgEhOBzritDkgyW4GrPDwdbDGnFm9aHmO?= =?us-ascii?Q?iwC8dhfzNLjULsRuS8qXMMtvWfNI5ykGLrjClsB7Ox0c0JVcpSA8CvagL+XZ?= =?us-ascii?Q?6NjagHdoLPGLn80OLhsVbpITZpFWSjCw4HQZQsibZL2fDmKhmL0uztNk/6eQ?= =?us-ascii?Q?vaHpNR2aAQaI2zLDjnCuKGPN9jTuu/6ViE26DhxjrOr7ugrTs+zR9NYuXlq2?= =?us-ascii?Q?50Z8DxxW4gKE5mwkiAAStNXnIs/in8BUtokFx4ZbwgAF+PNAhvCGyIzVJJe9?= =?us-ascii?Q?GG5g/QytWP89MJHgSXrqN9c9Luue8CAI2tuezwuaCHqTIf5d8UQVRsCl9B5m?= =?us-ascii?Q?zC0GlqprdBHsUn/C9pA4mpn060x+g9y3M8GBU7IWQfNbEdXITbO9wzoMdays?= =?us-ascii?Q?0mlvA0FmKr2swbq3fwKmyqCp1uM+f8IbkQssBW0DomVPe6P2Es+oTWx3LWlV?= =?us-ascii?Q?D4u5toI0Kfs+jE6apiAIYExNIszAfQC6EDxOIpX0HIUCRN70Cuue2cjfBKzR?= =?us-ascii?Q?HExZ1Dr3IMLfMgg1Flxmt/BKSbISgLgGdUrFD+9uLZYfSWuD+q5F7OzzspuI?= =?us-ascii?Q?RRwUGTiVNfEFTo1bzbF4LSNiPKNkhxd8hC3mG1bjD9A0pn+fsFMwh9j9f/e3?= =?us-ascii?Q?EIhfvJ2BLEYjDaMKM/Me6fXYPlukazqAvZ84qS2eX+8YYpWnwGn61xtxH9Bc?= =?us-ascii?Q?Ye+PGqV8hbz4lWHEETkWxZiYCvo+mGGHt/e+HqQymnvIpFq/afYcPUsu0a7b?= =?us-ascii?Q?7mAyEYXU8jrX0vuw2tWsiaBAwGCWNCuiYskjiG0uHtQ9t4d+bH6Uwz7Jgw89?= =?us-ascii?Q?pgrQZTLrR00rEKcD1CChL9DCexTkFNxOC7kJY9OR+yJbK9D18lGNWjH5ZeyB?= =?us-ascii?Q?97hXrX5UV406hAQWiGS4N9cba23nhNrK19axK1xo5v0e1U1kuN+rt3oAWMxW?= =?us-ascii?Q?16DTnVfL83hdrpglC8745dqVY/+lRa8Gd6UvedoGrgRFLhnXIQapYPNadtMs?= =?us-ascii?Q?9sH0WzZa1DWiB9tFhdkFlkoxKcc3IN91VedhQXnbyDYOMznTFTgPF3GcNu1C?= =?us-ascii?Q?EQ7E/wN9C83ynD5T2y2TA0r838DqAp0TcpJap2exz3fdpBaCiwdEGT9wBmR4?= =?us-ascii?Q?RAHrm5diAHmMrDDFdCDRM6M79GuEnOfATKfEjRtgkVIjikqYM51/WOy0Wzsa?= =?us-ascii?Q?oZFpnoY6pPZS3RLudwq5v+uOZckB7DyX?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3613.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PIvtdRJKmggPKpS4XzTl+AxK0XCRneZRLugGHDAH/DQ7vn4nCwiEGLjRg6C+?= =?us-ascii?Q?QEfBX6hxqBrbcRK4pJmnlWYwqWCEWEeNFNII9yypl8o0TWzCYYf8lKUdXocC?= =?us-ascii?Q?LUS06atd4NNaCFXWqojzv6RS5h/tl1E90l4RO/VE+MCuH51NvA7ctriotzZx?= =?us-ascii?Q?vkqXhWMbm4KwFRWAqwN5+ZjQf6KS/mmUV4irI7WNMtyKBm7IvXfasOTP01xg?= =?us-ascii?Q?VdFcMlubBNvukVIliV465/3/ZA58Yc2WYRiqKLfrbuxd5Eo4hzEOganLakUE?= =?us-ascii?Q?IwgdB+MiFP/uFbzdEASsqjRngcfTCpkp0t9I6UzlGrLlP29YGMUY8lr6UwGT?= =?us-ascii?Q?/zZ2mJyOavbK6+WfZqrX386oIEaezFx6H5tD8OXyrIJajATDsN4zN1a2t29u?= =?us-ascii?Q?EzIcDIbPRjdmtLJCDpcalfXnCd9upBVLa8OY2dFb+EHlBirEz/zDzhbOI+1h?= =?us-ascii?Q?PVdpHrVJxT0LFsWNRu6krdjTrrypbK0DIxL9j2qJNW4kEFH84C+Vp0NB2Z3/?= =?us-ascii?Q?hqmY+9jLSDZgqJHegfPpMYfxgYx73GxwwfCKZHVdw1+0acLDa9nOuJtRY9Ar?= =?us-ascii?Q?geRzeQiCD8j7WRI4eItZK+PCpn7dR5iG9M45J491cCjr+9oWH3hrbmfS/3b1?= =?us-ascii?Q?g3YSJYMn41rAQuS5EXDatyNciURZneDVod2B6OuA3azESLWjNxVe4f1kufh0?= =?us-ascii?Q?ks56027rwjP4vyQ1KMErvo+d6FJawGcFdyvx/iraWKaqyHefGiTKvltBxjG6?= =?us-ascii?Q?34A4W0yXNUJ2SEJ4UeTd5t7C5CKzkNWwBGXPfzyaoz7wxoc/LUJhmfJmICG2?= =?us-ascii?Q?dtzbjyQ16CnaCcb89rvyAKTUsiR783EmFDIuxSHjJGektForohww2yqlR89k?= =?us-ascii?Q?2HgplBidOcSg8MKC06wJg3VCAjxm4l0FrpaIE/KJpQGJr+ogM12Lcf9Vvemi?= =?us-ascii?Q?Ez0V8Sf5Nv2v1qxgyI6v/JVG0PfYZlUUyFk1V1I7FEFwfKeKIduCCVR52Whu?= =?us-ascii?Q?uX6lDhTHmvWPHqs+iPUnWiOpBEVtzTrssk9mDT01NTPXBt5/WSVn2BUYggbI?= =?us-ascii?Q?WU1M38C9U+ux9BMfIf9V/dkD8rwllMuY/C8bvjXAE8vnbnE0f6ybFmOVfEc+?= =?us-ascii?Q?honl7t0F32n+wZ6zTE0V/U5BhB8qREwbX2su4WamTfvcqt4ilrXQ9LqI6orC?= =?us-ascii?Q?mKCN6mrQLPPH9mbF/jd/RTmFnYF1a0Lr8gE1cFyOh/lIWg5vxWguSgeqzaaK?= =?us-ascii?Q?H/5XhCbS0MGLpHN2rex8ZkpGLyrjjhBGvdEp9fhUcVbfBW+izJqeWimTdNTM?= =?us-ascii?Q?PDGi9Uc4uBB6NgDdE5cOauDHJaiG6JtHMWv4J8z19mD0t/RLAZOFfBW7uNlp?= =?us-ascii?Q?LcrsBSLLls6bTPsUjDJ1uNR3rW93OBcXS+rhKDsGj/Q1BTngox7fz+zsNc2O?= =?us-ascii?Q?SHZhQo8YJBS3N/cXO0ieny09s0W0RyNU7OwJ6du/Mt8GcN/eQyaqn4hTuuvb?= =?us-ascii?Q?HB1nUk2T4JuDwcLrzVnYm2A9BB1KJPpNJUKnt4PjUQaGyUaMW3lb+fv3/Ed5?= =?us-ascii?Q?esGHrKw1Jl0c0NwTdvg=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c37b7ba0-f2e7-4046-2c9e-08de124038ed X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3613.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2025 14:26:58.0176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gpr+5VVnFFAJZN8NC2yB3UKQMBqLMY8fLwl3qLZbc2arRFa2jX5ypiTBtyzmw3Ew X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7743 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251023_072708_576762_98431F25 X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 23, 2025 at 01:34:21PM +0100, Robin Murphy wrote: > On 2025-10-22 6:12 pm, Jason Gunthorpe wrote: > > This old style API is only used by drivers/gpu/drm/msm and > > drivers/remoteproc, neither are used on x86 HW. Remove the dead code to > > discourage new users. > > I'd be almost certain there's somebody somewhere using remoteproc on x86 > with some FPGA/bespoke PCI device/on-board MCU/etc. - whether they're doing > it on AMD *and* care about its fault reporting mechanism is really the > question. Hmm! Looking more closely static int rproc_enable_iommu(struct rproc *rproc) { struct iommu_domain *domain; struct device *dev = rproc->dev.parent; int ret; if (!rproc->has_iommu) { ^^^^^^^^^^^^^ dev_dbg(dev, "iommu not present\n"); return 0; } iommu_set_fault_handler(domain, rproc_iommu_fault, rproc); And then: drivers/remoteproc/omap_remoteproc.c: rproc->has_iommu = true; drivers/remoteproc/qcom_q6v5_adsp.c: .has_iommu = true, config OMAP_REMOTEPROC tristate "OMAP remoteproc support" depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX depends on OMAP_IOMMU config QCOM_Q6V5_ADSP tristate "Qualcomm Technology Inc ADSP Peripheral Image Loader" depends on OF && ARCH_QCOM depends on QCOM_SMEM So, I think it is safe. I will revise the commit message. Seems like these drivers are definately used: drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 + drivers/iommu/arm/arm-smmu/qcom_iommu.c | 1 + drivers/iommu/omap-iommu.c | 1 + But I wonder if these are all dead code too? Any thoughts? drivers/iommu/ipmmu-vmsa.c | 1 + drivers/iommu/mtk_iommu.c | 1 + drivers/iommu/mtk_iommu_v1.c | 1 + drivers/iommu/rockchip-iommu.c | 1 + drivers/iommu/sun50i-iommu.c | 1 + > > if (dev_data) { > > - /* > > - * If this is a DMA fault (for which the I(nterrupt) > > - * bit will be unset), allow report_iommu_fault() to > > - * prevent logging it. > > - */ > > - if (IS_IOMMU_MEM_TRANSACTION(flags)) { > > - /* Device not attached to domain properly */ > > - if (dev_data->domain == NULL) { > > - pr_err_ratelimited("Event logged [Device not attached to domain properly]\n"); > > - pr_err_ratelimited(" device=%04x:%02x:%02x.%x domain=0x%04x\n", > > - iommu->pci_seg->id, PCI_BUS_NUM(devid), PCI_SLOT(devid), > > - PCI_FUNC(devid), domain_id); > > - goto out; > > - } > This part is unrelated to the report_iommu_fault() call - in fact it was > specifically added even more recently. Yeah, I'll fix it Thanks, Jason