From: Conor Dooley <conor@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: alexandre.belloni@bootlin.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v1 1/2] dt-bindings: rtc: Add MediaTek MT6685 PM/Clock IC Real Time Clock
Date: Fri, 24 Oct 2025 17:22:17 +0100 [thread overview]
Message-ID: <20251024-unleash-slouchy-ef6903088ffe@spud> (raw)
In-Reply-To: <20251024083318.25890-2-angelogioacchino.delregno@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2877 bytes --]
On Fri, Oct 24, 2025 at 10:33:17AM +0200, AngeloGioacchino Del Regno wrote:
> The MediaTek MT6685 PM / Clock IC contains various SPMI sub
> devices, of which two are Real Time Clock IPs, one usually
> reserved for the secure world and one for the unsecured one,
> reachable at different SPMI addresses.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>
> NOTE: This does not contain any example because the MT6685 RTC
> will be added to the mfd binding for MediaTek SPMI PMICs
> and examples will be there.
Were it not for this mfd stuff, could easily go in trivial-rtc.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
>
> ** For reviewing purposes, this is how the example will look like: **
>
> - |
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> spmi {
> #address-cells = <2>;
> #size-cells = <0>;
>
> pmic@9 {
> compatible = "mediatek,mt6363";
> reg = <0x9 SPMI_USID>;
> interrupts = <9 1 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-controller;
> #address-cells = <1>;
> #interrupt-cells = <3>;
> #size-cells = <0>;
>
> clock-controller@514 {
> compatible = "mediatek,mt6685-sck-top";
> reg = <0x514>;
> #clock-cells = <1>;
> };
>
> rtc@580 {
> compatible = "mediatek,mt6685-rtc";
> reg = <0x580>;
> interrupts = <9 0 IRQ_TYPE_LEVEL_HIGH>;
> };
> };
> };
>
> .../bindings/rtc/mediatek,mt6685-rtc.yaml | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/mediatek,mt6685-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6685-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6685-rtc.yaml
> new file mode 100644
> index 000000000000..1aec163b251a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6685-rtc.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/mediatek,mt6685-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6685 PM/Clock IC Real Time Clock
> +
> +allOf:
> + - $ref: rtc.yaml#
> +
> +maintainers:
> + - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> +
> +properties:
> + compatible:
> + const: mediatek,mt6685-rtc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
> --
> 2.51.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-10-24 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 8:33 [PATCH v1 0/2] rtc: Add support for MT6685 RTC AngeloGioacchino Del Regno
2025-10-24 8:33 ` [PATCH v1 1/2] dt-bindings: rtc: Add MediaTek MT6685 PM/Clock IC Real Time Clock AngeloGioacchino Del Regno
2025-10-24 16:22 ` Conor Dooley [this message]
2025-10-24 8:33 ` [PATCH v1 2/2] rtc: Add support for MT6685 Clock IC's RTC over SPMI AngeloGioacchino Del Regno
2025-10-26 1:37 ` kernel test robot
2025-10-26 5:13 ` kernel test robot
2025-10-30 17:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024-unleash-slouchy-ef6903088ffe@spud \
--to=conor@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox