From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31F83CCF9E5 for ; Mon, 27 Oct 2025 01:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WbQ2nvFTp+Ev/UZzO6hfJ3ypfnkAXEaRnRchw5NdZOk=; b=RYaOGi7r7Elwj56ckJdx00eR3M DjZVhBmvAtnh1LcVJt8MPzHmjxOQwuh2fsTN+T+S4KRpEUD9jqrGU9+bV44nOV8+ox6fq15jFQiXt SPJbjcJc1Ipm6HxgS/U8CiGJyPD/FxIQwv90dUU8Wz7ZZfVV4e6RMgtqRMDD5557dft6yiIcOZ1OV yd0znMXnR5oPQRnymWF13Bay1npe5szamQ5V2xzHxlWZv8SHmCfimw7jvPIDaQnNfOipzzq+jdwu5 kZFPuK4y/meOkE9mvDzAxNHjRIAcaSfxn+yIhBWFMuAoizKfSA5LC5ReUXGin3YN2qhkZw2s0a5TH QZ75JHfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDCER-0000000Cxnd-0bqV; Mon, 27 Oct 2025 01:41:11 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDCEO-0000000Cxmz-40wz; Mon, 27 Oct 2025 01:41:10 +0000 Received: from pendragon.ideasonboard.com (82-203-161-16.bb.dnainternet.fi [82.203.161.16]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 99B671661; Mon, 27 Oct 2025 02:39:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761529159; bh=n2izf+vNSxdejnbRHxRXfCo5yW8E26f7kiMpnt+M1RY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V/l1R8D94FVYffJ/y1K80bQndqw60xN08/Gyck75Ld4b+RZwAxdzBgzbM/r9VJOnG 33iB5BHXrR88goAvPfcxeWnsU/Aq6ubb5yvrBqkZ/NPOwHyCLfTYGS0qGYdXr0tMir UZXEHiuuXgjO8lDf5bbuyGws3cD/1gF1NvLcL8u8= Date: Mon, 27 Oct 2025 03:40:52 +0200 From: Laurent Pinchart To: Frank Li Cc: Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eugen Hristev , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Alice Yuan , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Steve Longerbeam , Greg Kroah-Hartman , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v3 10/31] media: staging: media: imx6-mipi-csi2: use devm_platform_ioremap_resource() simplify code Message-ID: <20251027014052.GU13023@pendragon.ideasonboard.com> References: <20250821-95_cam-v3-0-c9286fbb34b9@nxp.com> <20250821-95_cam-v3-10-c9286fbb34b9@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250821-95_cam-v3-10-c9286fbb34b9@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251026_184109_134754_89FAAE58 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 21, 2025 at 04:15:45PM -0400, Frank Li wrote: > Use devm_platform_ioremap_resource() simplify code. No functional change. > > Signed-off-by: Frank Li > --- > drivers/staging/media/imx/imx6-mipi-csi2.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c > index b04c1b98c088b8bfa66eb3f61cca8bb735b7eae4..7b8911bea3fad8187fafb1d0916d730fd6fa671c 100644 > --- a/drivers/staging/media/imx/imx6-mipi-csi2.c > +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c > @@ -738,7 +738,6 @@ static void csi2_nf_cleanup(void *data) > static int csi2_probe(struct platform_device *pdev) > { > struct csi2_dev *csi2; > - struct resource *res; > int i, ret; > > csi2 = devm_kzalloc(&pdev->dev, sizeof(*csi2), GFP_KERNEL); > @@ -772,15 +771,10 @@ static int csi2_probe(struct platform_device *pdev) > if (ret) > return ret; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - v4l2_err(&csi2->sd, "failed to get platform resources\n"); > - return -ENODEV; > - } > - > - csi2->base = devm_ioremap(&pdev->dev, res->start, PAGE_SIZE); > - if (!csi2->base) > - return -ENOMEM; > + csi2->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(csi2->base)) > + return dev_err_probe(&pdev->dev, -ENOMEM, > + "failed to get platform resources"); devm_platform_ioremap_resource() prints error messages internally with dev_err_probe(), so you can just return PTR_ERR(csi2->base); here. With that, Reviewed-by: Laurent Pinchart > > ret = devm_mutex_init(&pdev->dev, &csi2->lock); > if (ret) > -- Regards, Laurent Pinchart