From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
Vinod Koul <vkoul@kernel.org>, Sinan Kaya <okaya@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@amd.com>,
Stephan Gerhold <stephan.gerhold@linaro.org>,
Md Sadre Alam <quic_mdalam@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Casey Connolly <casey.connolly@linaro.org>,
Abin Joseph <abin.joseph@amd.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
linux-arm-msm@vger.kernel.org
Subject: [PATCH 2/6] dmaengine: pl330: Remove redundant pm_runtime_mark_last_busy() calls
Date: Mon, 27 Oct 2025 15:32:28 +0200 [thread overview]
Message-ID: <20251027133232.392898-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20251027133232.392898-1-sakari.ailus@linux.intel.com>
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/dma/pl330.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 82a9fe88ad54..72f260328ae9 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2133,10 +2133,8 @@ static void pl330_tasklet(struct tasklet_struct *t)
spin_unlock_irqrestore(&pch->lock, flags);
/* If work list empty, power down */
- if (power_down) {
- pm_runtime_mark_last_busy(pch->dmac->ddma.dev);
+ if (power_down)
pm_runtime_put_autosuspend(pch->dmac->ddma.dev);
- }
}
static struct dma_chan *of_dma_pl330_xlate(struct of_phandle_args *dma_spec,
@@ -2313,7 +2311,6 @@ static int pl330_terminate_all(struct dma_chan *chan)
list_splice_tail_init(&pch->work_list, &pl330->desc_pool);
list_splice_tail_init(&pch->completed_list, &pl330->desc_pool);
spin_unlock_irqrestore(&pch->lock, flags);
- pm_runtime_mark_last_busy(pl330->ddma.dev);
if (power_down)
pm_runtime_put_autosuspend(pl330->ddma.dev);
pm_runtime_put_autosuspend(pl330->ddma.dev);
@@ -2347,7 +2344,6 @@ static int pl330_pause(struct dma_chan *chan)
desc->status = PAUSED;
}
spin_unlock_irqrestore(&pch->lock, flags);
- pm_runtime_mark_last_busy(pl330->ddma.dev);
pm_runtime_put_autosuspend(pl330->ddma.dev);
return 0;
@@ -2371,7 +2367,6 @@ static void pl330_free_chan_resources(struct dma_chan *chan)
list_splice_tail_init(&pch->work_list, &pch->dmac->desc_pool);
spin_unlock_irqrestore(&pl330->lock, flags);
- pm_runtime_mark_last_busy(pch->dmac->ddma.dev);
pm_runtime_put_autosuspend(pch->dmac->ddma.dev);
pl330_unprep_slave_fifo(pch);
}
@@ -3176,7 +3171,6 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
pm_runtime_irq_safe(&adev->dev);
pm_runtime_use_autosuspend(&adev->dev);
pm_runtime_set_autosuspend_delay(&adev->dev, PL330_AUTOSUSPEND_DELAY);
- pm_runtime_mark_last_busy(&adev->dev);
pm_runtime_put_autosuspend(&adev->dev);
return 0;
--
2.47.3
next prev parent reply other threads:[~2025-10-27 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 13:32 [PATCH 1/6] dmaengine: at_xdmac: Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
2025-10-27 13:32 ` Sakari Ailus [this message]
2025-10-27 13:32 ` [PATCH 3/6] dmaengine: qcom: " Sakari Ailus
2025-10-27 13:36 ` Dmitry Baryshkov
2025-12-16 16:53 ` Vinod Koul
2025-10-27 13:32 ` [PATCH 4/6] dmaengine: ste_dma40: " Sakari Ailus
2025-10-29 14:16 ` Linus Walleij
2025-10-27 13:32 ` [PATCH 5/6] dmaengine: ti: " Sakari Ailus
2025-10-27 13:32 ` [PATCH 6/6] dmaengine: zynqmp_dma: " Sakari Ailus
2025-10-31 6:55 ` Joseph, Abin
2025-12-16 16:59 ` [PATCH 1/6] dmaengine: at_xdmac: " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027133232.392898-2-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=abin.joseph@amd.com \
--cc=casey.connolly@linaro.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=michal.simek@amd.com \
--cc=okaya@kernel.org \
--cc=quic_mdalam@quicinc.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=stephan.gerhold@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).