From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23DD5CCF9E5 for ; Mon, 27 Oct 2025 13:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K4olja8Zxm7jjnaeqd40tZ3pVZb9XLvY9tkwfe64Ebs=; b=amnJN+oCt4RmPPFCdNWE2enQd7 vBkP4+vI6yCMU65XDDL5210X8YLIh7643Dy1WLPAi38iyYel0IQK39ewiSuCBFcfSeNZFcnIi9xVp oljXuLjgZKrN6vpynQvu0kfwuO2oNnF12sCJq/1rY8Pwi7e13k/4ufSi0b2OhTsOCCEys+0GP6Ehf Py+E4MNTJDaiRKbGvv8Tp3bsJN4kuGdqYfsMHNKi5Y8lj5X3qd3gPCRLEhwhru1Dsd79pQM5WBq5X nMkrBbXcwwVcpUIKn/U0j6dRSxvOm7rw+64TsugRWUA/xyYaJSEGvy3fYslZW56EAlICKtwqfZMFI 4zCNLpSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDNLJ-0000000E34C-49vh; Mon, 27 Oct 2025 13:33:01 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDNLA-0000000E2zR-0RkA for linux-arm-kernel@bombadil.infradead.org; Mon, 27 Oct 2025 13:32:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=K4olja8Zxm7jjnaeqd40tZ3pVZb9XLvY9tkwfe64Ebs=; b=lajETk+f5QJ6iAq21oFe8Q7UCU mQQCC1oASAVHKj4hBKvofvsF33ULTAgjmphSeBQ5bx9GRzZP/GqusTDOpQ4Dv+7uB3oLepkCyvkBN ZPE285M4FHTvAPe8scNGzrxPaoP4McCdjm31tIV62HZ/ZE+WT7tbyNb4fE4WPi2m6s3S9Z4gKR0Gb iRTUTIbRNCqJ8SVro29Olojd1IQDaD2Egal7GJg6WPXDMYLwjKSsEHb9A+2AUMDk8m/pJsgVa74+F HiZP1tZbEVpCi2ngIi0N8CmjXZF02PMOHzx4DeDYVF/tw7ys/ujW/xR7sN3oHdbdVUoyEB+iZui38 kzy2Ghtg==; Received: from mgamail.intel.com ([192.198.163.11]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDMTM-00000002BdK-3nyW for linux-arm-kernel@lists.infradead.org; Mon, 27 Oct 2025 12:37:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761571969; x=1793107969; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=goC/t74Beaos4bhfJNoY+s7Khzyp5MrUbBGzebOtlkI=; b=O0529CZ4EC1dOnRPHEk8njx26xTzA+ViaoDosP64LjG8pikv8yDuDR+z LZv9h3gHqCgPCnZYx9apcWD8tgI6lBZZHpzUqubrnkqi2XpVR6DFx4KTv jsyTVj6jmd7ZcszKj5L/ujQfXrJumvixux9TWstJ1jQ7unw+2R5XfXYbm ZQgsjjggKqzX+o7mLPDNlpE1qhCyxUo114ve/xJeJmXm7lX1ADJ7mH3qH ylbkXTBb+GSdxQy8qCP1P6xDkot9cT3pXGtvJETZxbZv2RlEe78VvNwaW HLnaOyYgtpvVJFmQIabH//wxOswzPHVM7vHB0uqE/8Qw3JCUnUPsYMAnh Q==; X-CSE-ConnectionGUID: Mr4C7JmXTl+2UAMEtzaP9Q== X-CSE-MsgGUID: 86qxb50LRPmAQuZQgTOv2w== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="74249733" X-IronPort-AV: E=Sophos;i="6.19,258,1754982000"; d="scan'208";a="74249733" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2025 06:32:42 -0700 X-CSE-ConnectionGUID: u/pg0HMwQ/y/6IS7yqqC8Q== X-CSE-MsgGUID: hIjq87w2Q6WwIk5sez8q8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,258,1754982000"; d="scan'208";a="185511616" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.31]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2025 06:32:40 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id A3CC0121EFA; Mon, 27 Oct 2025 15:32:37 +0200 (EET) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1vDNKq-00000001eDb-2dp5; Mon, 27 Oct 2025 15:32:32 +0200 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-arm-kernel@lists.infradead.org Cc: Ludovic Desroches , Vinod Koul , Sinan Kaya , Linus Walleij , Michal Simek , Stephan Gerhold , Md Sadre Alam , Konrad Dybcio , Casey Connolly , Abin Joseph , Radhey Shyam Pandey , linux-arm-msm@vger.kernel.org Subject: [PATCH 4/6] dmaengine: ste_dma40: Remove redundant pm_runtime_mark_last_busy() calls Date: Mon, 27 Oct 2025 15:32:30 +0200 Message-ID: <20251027133232.392898-4-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027133232.392898-1-sakari.ailus@linux.intel.com> References: <20251027133232.392898-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_123717_418171_2E4913FB X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), pm_runtime_autosuspend() and pm_request_autosuspend() now include a call to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to pm_runtime_mark_last_busy(). Signed-off-by: Sakari Ailus --- drivers/dma/ste_dma40.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index d52e1685aed5..e67e0d66e6e8 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -1452,7 +1452,6 @@ static int d40_pause(struct dma_chan *chan) res = d40_channel_execute_command(d40c, D40_DMA_SUSPEND_REQ); - pm_runtime_mark_last_busy(d40c->base->dev); pm_runtime_put_autosuspend(d40c->base->dev); spin_unlock_irqrestore(&d40c->lock, flags); return res; @@ -1479,7 +1478,6 @@ static int d40_resume(struct dma_chan *chan) if (d40_residue(d40c) || d40_tx_is_linked(d40c)) res = d40_channel_execute_command(d40c, D40_DMA_RUN); - pm_runtime_mark_last_busy(d40c->base->dev); pm_runtime_put_autosuspend(d40c->base->dev); spin_unlock_irqrestore(&d40c->lock, flags); return res; @@ -1581,7 +1579,6 @@ static void dma_tc_handle(struct d40_chan *d40c) if (d40_queue_start(d40c) == NULL) { d40c->busy = false; - pm_runtime_mark_last_busy(d40c->base->dev); pm_runtime_put_autosuspend(d40c->base->dev); } @@ -2054,16 +2051,13 @@ static int d40_free_dma(struct d40_chan *d40c) else d40c->base->lookup_phy_chans[phy->num] = NULL; - if (d40c->busy) { - pm_runtime_mark_last_busy(d40c->base->dev); + if (d40c->busy) pm_runtime_put_autosuspend(d40c->base->dev); - } d40c->busy = false; d40c->phy_chan = NULL; d40c->configured = false; mark_last_busy: - pm_runtime_mark_last_busy(d40c->base->dev); pm_runtime_put_autosuspend(d40c->base->dev); return res; } @@ -2466,7 +2460,6 @@ static int d40_alloc_chan_resources(struct dma_chan *chan) if (is_free_phy) d40_config_write(d40c); mark_last_busy: - pm_runtime_mark_last_busy(d40c->base->dev); pm_runtime_put_autosuspend(d40c->base->dev); spin_unlock_irqrestore(&d40c->lock, flags); return err; @@ -2618,12 +2611,9 @@ static int d40_terminate_all(struct dma_chan *chan) chan_err(d40c, "Failed to stop channel\n"); d40_term_all(d40c); - pm_runtime_mark_last_busy(d40c->base->dev); pm_runtime_put_autosuspend(d40c->base->dev); - if (d40c->busy) { - pm_runtime_mark_last_busy(d40c->base->dev); + if (d40c->busy) pm_runtime_put_autosuspend(d40c->base->dev); - } d40c->busy = false; spin_unlock_irqrestore(&d40c->lock, flags); -- 2.47.3