From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: thippeswamy.havalige@amd.com, Ravi Kumar Bandi <ravib@amazon.com>,
lpieralisi@kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, kwilczynski@kernel.org,
robh@kernel.org, michal.simek@amd.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Stefan Roese <stefan.roese@mailbox.org>,
"Musham, Sai Krishna" <sai.krishna.musham@amd.com>,
Sean Anderson <sean.anderson@linux.dev>,
"Yeleswarapu, Nagaradhesh" <nagaradhesh.yeleswarapu@amd.com>
Subject: Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts
Date: Mon, 27 Oct 2025 18:28:47 -0500 [thread overview]
Message-ID: <20251027232847.GA1488235@bhelgaas> (raw)
In-Reply-To: <176085776570.12994.10687348823390647832.b4-ty@kernel.org>
[+cc Stefan et al]
On Sun, Oct 19, 2025 at 12:39:25PM +0530, Manivannan Sadhasivam wrote:
> On Sat, 20 Sep 2025 22:52:32 +0000, Ravi Kumar Bandi wrote:
> > The pcie-xilinx-dma-pl driver does not enable INTx interrupts
> > after initializing the port, preventing INTx interrupts from
> > PCIe endpoints from flowing through the Xilinx XDMA root port
> > bridge. This issue affects kernel 6.6.0 and later versions.
> >
> > This patch allows INTx interrupts generated by PCIe endpoints
> > to flow through the root port. Tested the fix on a board with
> > two endpoints generating INTx interrupts. Interrupts are
> > properly detected and serviced. The /proc/interrupts output
> > shows:
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] PCI: xilinx-xdma: Enable INTx interrupts
> commit: c098c13f4365e6750009be4d90dba36fa4a19b4e
Pretty sure we have confirmation that we don't need either this patch
or Stefan's patch, so I removed the pci/controller/xilinx-dma branch.
It was at 2002478e5034 ("PCI: xilinx-xdma: Enable INTx interrupts") in
case we need to resurrect it.
IIUC, Stefan confirmed that he didn't need this patch (Ravi's) [1],
and that after Vivado is fixed to generate the correct interrupt-map,
his patch (Stefan's) won't be needed either [2].
[1] https://lore.kernel.org/r/29bc5e92-04c9-475a-ba3d-a5ea26f1c95a@mailbox.org
[2] https://lore.kernel.org/r/9c7e43c3-24e9-4b08-a6ce-2035b50226f4@mailbox.org
next prev parent reply other threads:[~2025-10-27 23:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 23:13 [PATCH] PCI: xilinx-xdma: Enable legacy interrupts Ravi Kumar Bandi
2025-09-20 15:51 ` Manivannan Sadhasivam
2025-09-20 22:39 ` Bandi, Ravi Kumar
2025-09-20 22:52 ` [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts Ravi Kumar Bandi
2025-09-24 6:13 ` Bandi, Ravi Kumar
2025-09-29 14:07 ` Manivannan Sadhasivam
2025-10-19 7:10 ` Manivannan Sadhasivam
2025-10-19 7:09 ` Manivannan Sadhasivam
2025-10-27 23:28 ` Bjorn Helgaas [this message]
2025-10-28 0:36 ` Bandi, Ravi Kumar
2025-10-21 17:23 ` Bjorn Helgaas
2025-10-21 17:46 ` Bandi, Ravi Kumar
2025-10-21 19:10 ` Bjorn Helgaas
2025-10-21 20:55 ` Bandi, Ravi Kumar
2025-10-21 21:28 ` Bjorn Helgaas
2025-10-21 21:35 ` Bandi, Ravi Kumar
2025-10-22 6:59 ` Stefan Roese
2025-10-22 9:55 ` mani
2025-10-22 9:59 ` Stefan Roese
2025-10-22 10:08 ` Havalige, Thippeswamy
2025-10-22 10:32 ` mani
2025-10-22 10:36 ` Havalige, Thippeswamy
2025-10-22 10:58 ` mani
2025-10-22 12:48 ` Musham, Sai Krishna
2025-10-22 13:10 ` mani
2025-10-23 11:38 ` Musham, Sai Krishna
2025-10-22 13:37 ` Stefan Roese
2025-10-23 6:35 ` Musham, Sai Krishna
2025-10-23 7:03 ` Stefan Roese
2025-10-23 16:11 ` Bjorn Helgaas
2025-10-24 11:59 ` mani
2025-10-22 10:04 ` Havalige, Thippeswamy
2025-10-22 10:06 ` Havalige, Thippeswamy
2025-10-22 10:11 ` Stefan Roese
2025-10-22 10:13 ` Havalige, Thippeswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027232847.GA1488235@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=michal.simek@amd.com \
--cc=nagaradhesh.yeleswarapu@amd.com \
--cc=ravib@amazon.com \
--cc=robh@kernel.org \
--cc=sai.krishna.musham@amd.com \
--cc=sean.anderson@linux.dev \
--cc=stable@vger.kernel.org \
--cc=stefan.roese@mailbox.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox