From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D83B1CCD1BF for ; Wed, 29 Oct 2025 07:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FJMoyZ1t1YeDBw7c8GChVfEptGd+0NATOX776m3g0j4=; b=xAGWK/tyFvq3Qjxnaa3wocuy4k 24AVunxtZV3k0f6KKz/2Mp/1AG7wRyOC9ZHLyObxEMSbZ59hMe212m3gVLQy004OqoG0xmQ3mkNcE RZgQtANTFCXFXJDAQBmiPCUv8YdcI0VMkgbuBBBxA7SGorJtXWrNTPsUwalkwTjmiW+mobBpbkkes e0J60zm7ynkSH4kEnkGi7xFDKYcASwQ+jOOZRjzV5gJK/8JxcjfmevJnwnEcoSRsslh1TjrifmLvE Zu+rtblAJ2NZ+aNrmBTE5iOurqyJ8vyESOumWrfYrzkx0SV09egsXECog1q+2mKV8XVr7HZ2ECSDj 3lMXlnGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vE0PG-000000002Rm-2K3o; Wed, 29 Oct 2025 07:15:42 +0000 Received: from smtpbgau1.qq.com ([54.206.16.166]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vE0PB-000000002EX-2leM; Wed, 29 Oct 2025 07:15:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=airkyi.com; s=altu2504; t=1761722101; bh=FJMoyZ1t1YeDBw7c8GChVfEptGd+0NATOX776m3g0j4=; h=From:To:Subject:Date:Message-Id; b=WfsLwyq4FS8wSfAryEYVifdG9ybxMh9BxPhlWhlLPJ9Ws9+Zg1Tp1HgRBHfWE7Iyb BtJZIxFXnP94bPr2p4bz8Lnxfwdsx0GUv3AK4dyJMdjyJXlRzAGMfRr1vFYXr0VCi2 hW0MQQjpYofYNPWUvI7h1oEG4iUxxMbaKJaMbJ68= X-QQ-mid: zesmtpsz6t1761722098t70ec4185 X-QQ-Originating-IP: nrXTS2MjCDfq0/Rdag/r96GHT70yO64qGAp8vt7JiO8= Received: from DESKTOP-8BT1A2O.localdomain ( [58.22.7.114]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 29 Oct 2025 15:14:55 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 238686505024682894 From: Chaoyi Chen To: Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH v8 03/10] drm/bridge: Implement generic USB Type-C DP HPD bridge Date: Wed, 29 Oct 2025 15:14:28 +0800 Message-Id: <20251029071435.88-4-kernel@airkyi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20251029071435.88-1-kernel@airkyi.com> References: <20251029071435.88-1-kernel@airkyi.com> X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:airkyi.com:qybglogicsvrsz:qybglogicsvrsz4a-0 X-QQ-XMAILINFO: Non7B45eNO9BaBSoFlGwoRXV2OmWn8KRiK6uYLn7ywxwE29wtMwDJyZm 2tT/HRL+JM2WLApvGJbwkfcsC9zCQon0VkgP10jWshukESwmPnN9S4NQvG64PWBwIluI4lp XQsedcX688J25pN1JvD0wH35e+57B4h6Kmi6Zn/mhBWoy1tzclPEoL0PwTD7F8weUbo/xwq 0HKmEWEv5xLwAH1UFvc1GfmSUqpoZNVJf5sl/FrvV2HOp3vvSoW1A7yNBcx4napbicgjYK6 n5OM3PagBifX4lCB+xxrc7SL1KWK50p81vObqQZwjibKjkhA3J0/aeRRJKe04c483grXjpB y2DyDZ/SlyBxZK+zwiCB5b63HLthB/UH/T9GyNLWJyyGZinFMTPcMZGqhZOMTZIDXd0ZtUA nDrlE4qm0xH6x/YkAcAIiDAkgI4rRZx8IQ9Ljjx4UHIvujRiOcuXuBnd7ufOx+jKKR0r7T9 cGO/EycjO/hQGXdNRwCBMuRaBr3a/PbNHrfMgK5/i//EnS0Oh1MXz2rZ8KAh+Kg1Ton4LVN Dv4Uj9F+J5GOG3WbmwJPrXf+Iy68Nn2fR149pm5vFNXwEiN6XXpx0LHaR6XwqFCrXEBfJi6 wf4ORP9DXPj9vQewD8RfRx0L25cnvD3WYSy2m6Ux50SQ6h5aN1iVv6kOsGnivF/YGYVYOSR oQtp+XnnwvE503ypzAFcE62tkNq2sQLW7uD29KD74Qn+Fji3jo09gQEe1mK+en/7Mid2+mh FE7v8TaPZXbsGjWOe0x12aMpbrlo0IHUQNQX4VtmJyT4qvOyalujhwbdfernR81j5JK/vSt K+BkK9tqKxJuZnoXcfmTtgB4mClTWPWf3i9iAZOmH8BQFQWO4Nzrt67kU5aaFRsFBspT4i0 wkkP5Aqg7orzWKNlgBvFTidtL6LyHw9bF0IDFOoOJX1ipD/KIpHRlog+CxXQ9jCbIIutAqZ 3CY1Ca0caTNJLibEDS0qitMhp+0pwRy/5LKaps1g1iWsQKU/x0RA/HCUI3EIICgSpIFpRXI mk0Wpg65QMsjHJK2g0CFIYaILTi1WoPzz22laIjg== X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= X-QQ-RECHKSPAM: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251029_001539_243333_BCECC02A X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Chaoyi Chen Several USB-C controller drivers have already implemented the DP HPD bridge function provided by aux-hpd-bridge.c, but there are still some USB-C controller driver that have not yet implemented it. This patch implements a generic DP HPD bridge based on aux-hpd-bridge.c, so that other USB-C controller drivers don't need to implement it again. Signed-off-by: Chaoyi Chen --- Changes in v8: - Merge generic DP HPD bridge into one module. drivers/gpu/drm/bridge/Kconfig | 5 +- drivers/gpu/drm/bridge/Makefile | 8 +++- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 23 ++++++++- drivers/gpu/drm/bridge/aux-hpd-bridge.h | 13 +++++ .../gpu/drm/bridge/aux-hpd-typec-dp-bridge.c | 47 +++++++++++++++++++ 5 files changed, 93 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/drm/bridge/aux-hpd-bridge.h create mode 100644 drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index a250afd8d662..17257b223a28 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -23,13 +23,16 @@ config DRM_AUX_BRIDGE build bridges chain. config DRM_AUX_HPD_BRIDGE - tristate + tristate "AUX HPD bridge support" depends on DRM_BRIDGE && OF select AUXILIARY_BUS help Simple bridge that terminates the bridge chain and provides HPD support. + Specifically, if you want a default Type-C DisplayPort HPD bridge for + each port of the Type-C controller, say Y here. + menu "Display Interface Bridges" depends on DRM && DRM_BRIDGE diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile index c7dc03182e59..2998937444bc 100644 --- a/drivers/gpu/drm/bridge/Makefile +++ b/drivers/gpu/drm/bridge/Makefile @@ -1,6 +1,12 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_DRM_AUX_BRIDGE) += aux-bridge.o -obj-$(CONFIG_DRM_AUX_HPD_BRIDGE) += aux-hpd-bridge.o + +hpd-bridge-y := aux-hpd-bridge.o +ifneq ($(CONFIG_TYPEC),) +hpd-bridge-y += aux-hpd-typec-dp-bridge.o +endif +obj-$(CONFIG_DRM_AUX_HPD_BRIDGE) += hpd-bridge.o + obj-$(CONFIG_DRM_CHIPONE_ICN6211) += chipone-icn6211.o obj-$(CONFIG_DRM_CHRONTEL_CH7033) += chrontel-ch7033.o obj-$(CONFIG_DRM_CROS_EC_ANX7688) += cros-ec-anx7688.o diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-bridge.c index 2e9c702c7087..11ad6dc776c7 100644 --- a/drivers/gpu/drm/bridge/aux-hpd-bridge.c +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c @@ -12,6 +12,8 @@ #include #include +#include "aux-hpd-bridge.h" + static DEFINE_IDA(drm_aux_hpd_bridge_ida); struct drm_aux_hpd_bridge_data { @@ -204,7 +206,26 @@ static struct auxiliary_driver drm_aux_hpd_bridge_drv = { .id_table = drm_aux_hpd_bridge_table, .probe = drm_aux_hpd_bridge_probe, }; -module_auxiliary_driver(drm_aux_hpd_bridge_drv); + +static int drm_aux_hpd_bridge_mod_init(void) +{ + int ret; + + ret = auxiliary_driver_register(&drm_aux_hpd_bridge_drv); + if (ret) + return ret; + + return drm_aux_hpd_typec_dp_bridge_init(); +} + +static void drm_aux_hpd_bridge_mod_exit(void) +{ + drm_aux_hpd_typec_dp_bridge_exit(); + auxiliary_driver_unregister(&drm_aux_hpd_bridge_drv); +} + +module_init(drm_aux_hpd_bridge_mod_init); +module_exit(drm_aux_hpd_bridge_mod_exit); MODULE_AUTHOR("Dmitry Baryshkov "); MODULE_DESCRIPTION("DRM HPD bridge"); diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.h b/drivers/gpu/drm/bridge/aux-hpd-bridge.h new file mode 100644 index 000000000000..69364731c2f1 --- /dev/null +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef AUX_HPD_BRIDGE_H +#define AUX_HPD_BRIDGE_H + +#if IS_REACHABLE(CONFIG_TYPEC) +int drm_aux_hpd_typec_dp_bridge_init(void); +void drm_aux_hpd_typec_dp_bridge_exit(void); +#else +static inline int drm_aux_hpd_typec_dp_bridge_init(void) { return 0; } +static inline void drm_aux_hpd_typec_dp_bridge_exit(void) { } +#endif /* IS_REACHABLE(CONFIG_TYPEC) */ + +#endif /* AUX_HPD_BRIDGE_H */ diff --git a/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c new file mode 100644 index 000000000000..6f2a1fca0fc5 --- /dev/null +++ b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c @@ -0,0 +1,47 @@ +// SPDX-License-Identifier: GPL-2.0+ +#include +#include +#include +#include + +#include + +#include "aux-hpd-bridge.h" + +#if IS_REACHABLE(CONFIG_TYPEC) +static int drm_typec_bus_event(struct notifier_block *nb, + unsigned long action, void *data) +{ + struct typec_altmode *alt = (struct typec_altmode *)data; + + if (action != TYPEC_ALTMODE_REGISTERED) + goto done; + + if (is_typec_partner(&alt->dev) || alt->svid != USB_TYPEC_DP_SID) + goto done; + + /* + * alt->dev.parent->parent : USB-C controller device + * alt->dev.parent : USB-C connector device + */ + drm_dp_hpd_bridge_register(alt->dev.parent->parent, + to_of_node(alt->dev.parent->fwnode)); + +done: + return NOTIFY_OK; +} + +static struct notifier_block drm_typec_event_nb = { + .notifier_call = drm_typec_bus_event, +}; + +int drm_aux_hpd_typec_dp_bridge_init(void) +{ + return typec_altmode_register_notify(&drm_typec_event_nb); +} + +void drm_aux_hpd_typec_dp_bridge_exit(void) +{ + typec_altmode_unregister_notify(&drm_typec_event_nb); +} +#endif -- 2.49.0