From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B050CCF9EB for ; Wed, 29 Oct 2025 23:11:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=QiIGSbexaAA+CmlhronKLWB3qTL5OB3HlpsKNFOwIow=; b=4NQgdhmT0JtrVM Nowtce5QwPXHlLEeetpet7oXsgq5FTGYK02L204kwjjMNrLu0z+cO3s+RKfN8uvn1xraqEB/tV6R/ vmFMG5QhfTCgRLzzBLa6Swk6U4JGJdNDADLH44biGd/Q4axtWulIDRJFBHp42s9HUBkoCmLbwMUzl EO9Mdlu76rT9Mj5DtAXYSwhgFIK1+C+SZl0hwn1rE+RFJqP8wAdo/bBHHSjKf7WrH0BbIqwX8lTIb Qx6mZu6f9QLnAWq397ifZfDVV3L5ux+gPpQ49H095f5b9v6JaWq6Ori+x8P0/11wF2J5WxmxDC35s QWKZNDkKhkx/s50N784Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEFJv-00000003E9x-0776; Wed, 29 Oct 2025 23:11:11 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEFJt-00000003E9j-0QtF; Wed, 29 Oct 2025 23:11:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 281F36029F; Wed, 29 Oct 2025 23:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 812A4C4CEF7; Wed, 29 Oct 2025 23:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761779466; bh=eHlQ2ZALLjGdsa88lWgTESQ22heSRABB6bxl7CsGUww=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=C1tmLb7mh4BjAht6SYKF9rf3E5ABcFVOINxHcK7CjmzQ398z2SAAuitNQkhsyWAXj xNUGo9R6um8sdlaF7tTnnwcjylb6Hy3x27qfCnai9SSW+zaGEJgH3XKB+dQ6C/55S1 OFxBaFVfIatdHz/gy4117dT7Poo4G8Y/r2EhXEhkWAnsS+Yqc6khm0mYqPooQ7Suty FhaKMD+sNsPy+SSSkymX+V87/ohpuYei2+8/fXbMXpzUfm8I+INFt4tzLxDde8+MJX dKLQmQSgYmapfYnzafjIm3AeV5zzL85G2Ix8P6DA+Dl5Ae+lCFtvFxvbjqXwYpzAXC BMr89O3kAt/hg== Date: Wed, 29 Oct 2025 18:11:05 -0500 From: Bjorn Helgaas To: Sebastian Reichel Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , Jingoo Han , Shawn Lin , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v4 4/9] PCI: dw-rockchip: Add helper function for enhanced LTSSM control mode Message-ID: <20251029231105.GA1601725@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251029-rockchip-pcie-system-suspend-v4-4-ce2e1b0692d2@collabora.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 29, 2025 at 06:56:43PM +0100, Sebastian Reichel wrote: > Remove code duplocation and improve readability by introducing a new > function to setup the enhanced LTSSM mode. s/duplocation/duplication/ s/setup/set up/ Maybe also include the actual function name instead of just "a new function". "rockchip_pcie_enable_enhanced_ltssm_control_mode()" is pretty long; I wouldn't object to a shorter version :)