Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

Jh Hsu (許希孜)
2025-11-06T05:34:16Z

On Wed, 2025-11-05 at 18:48 +0000, Conor Dooley wrote:
> > > Please drop mention of the evb from all of these commit messages.
> > > The
> > > compatible has nothing to do with the evb board, it's going to be
> > > common
> > > across all boards using an mt8189.
> > >
> > > >   arm64: dts: mediatek: Add MT6319 PMIC Support
> > > >   arm64: dts: mediatek: add properties for MT6359
> > >
> > > Wait a minute, what are these two patches even doing in this
> > > series
> > > in
> > > the first place, when it is otherwise about the mt8189?
> >
> > mt8189 evb board include mt63xx.dtsi,
> > and the dtsi files maybe for other boards in the future,
> > ie. mt8189/81xx custom/OEM/ODM boards.
> > Should i separate those two patches as a new patch series ?
>
> They seemed unrelated to your series and poor quality to the point
> that
> they looked like an accidental inclusions, given there's no mention
> of
> them in the cover letter. Since they do appear to be related, sure
> keep
> them. That said, the "add properties for MT6359" patch is in need of
> major rework, so you'll have to rework it.

Got it, will add mt63xx information and rework mt63xx dtsi in next
version