From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EF07CCF9F8 for ; Sun, 2 Nov 2025 00:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wAoWEwzBX3a4CSgVsF+TC9XL+SJXQBdUt7yh09xW8IE=; b=1bbEo/tVfP8Vl2GwjfdaOa0l2i oxQFYPJCTc5cbCQhUPf/PkVYHGgFu8am0yua03N0I26B6OfaqTL9QQUd+zC2XREXm7sPN3rpx71xO +GQnivhDRHgjbGcPBQaCQhdZspNirg8As+pK5jFhHEY19ht1oVzxf44JXmXVlFe46rVu42JuslvKN ugSNSyIqiyc0BR7IdPgCW5wuxa73+BxBDRx+56rmdT+J5713/fNO5IqfRMcxd8m4Lha2cXstwGZqE kw/oGQfuqvIu3eIEONvoGUcCtgAU9zihZn/KZMt0TL0/a//SWmNZXsxOjFX5Fg/ONDzO57/+aon6i xUo0g9Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFLzq-00000008Bog-2c0H; Sun, 02 Nov 2025 00:31:02 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFLzl-00000008Bnx-2lZ7; Sun, 02 Nov 2025 00:31:00 +0000 Received: from pendragon.ideasonboard.com (82-203-160-149.bb.dnainternet.fi [82.203.160.149]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2C6711118; Sun, 2 Nov 2025 01:29:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762043344; bh=svWNgZCtOjso/oW4IU8AjB0f/EKUwcTrDzXQT6w5yd4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hb4LFYO8jCYLvGpe7YVbC2qXUNIoNFojN2fIQmy0cKSJ0HPrZ5+ixKw1oNxT1SwIC v4Ss/TyZEkKnD4VeEs24LF3pUENpRzDcasVRh31FFk+VhhmiS/7r9TAu247UgBrJ4i vDPQcMVVJhYC3xNMRXVbsIw6ay3v+jXJLXGSZ/aA= Date: Sun, 2 Nov 2025 02:30:42 +0200 From: Laurent Pinchart To: Stanimir Varbanov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Andrea della Porta , Nicolas Ferre , Claudiu Beznea , Phil Elwell , Jonathan Bell , Dave Stevenson Subject: Re: [PATCH v2 0/5] dd ethernet support for RPi5 Message-ID: <20251102003042.GJ797@pendragon.ideasonboard.com> References: <20250822093440.53941-1-svarbanov@suse.de> <20251031114518.GA17287@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251101_173059_280771_1AF0FB98 X-CRM114-Status: GOOD ( 28.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 31, 2025 at 05:35:32PM +0200, Stanimir Varbanov wrote: > On 10/31/25 1:45 PM, Laurent Pinchart wrote: > > On Fri, Aug 22, 2025 at 12:34:35PM +0300, Stanimir Varbanov wrote: > >> Hello, > >> > >> Changes in v2: > >> - In 1/5 updates according to review comments (Nicolas) > >> - In 1/5 added Fixes tag (Nicolas) > >> - Added Reviewed-by and Acked-by tags. > >> > >> v1 can found at [1]. > >> > >> Comments are welcome! > > > > I'm very happy to see support for Raspberry Pi 5 progressing fast > > upstream. > > > > I've tested the latest mainline kernel (v6.18-rc3) that includes this > > series (except for 1/5 that is replaced by > > https://lore.kernel.org/all/20250820-macb-fixes-v4-0-23c399429164@bootlin.com/ > > as far as I understand). The ethernet controller is successfully > > detected, and so is the PHY. Link status seems to work fine too, but > > data doesn't seem to go through when the kernel tries to get a DHCP > > address (for NFS root). Here's the end of the kernel log (with the > > messages related to the USB controller stripped out): > > > > [ 0.896779] rp1_pci 0002:01:00.0: assign IRQ: got 27 > > [ 0.896809] rp1_pci 0002:01:00.0: enabling device (0000 -> 0002) > > [ 0.896840] rp1_pci 0002:01:00.0: enabling bus mastering > > [ 0.931874] macb 1f00100000.ethernet: invalid hw address, using random > > [ 0.944448] macb 1f00100000.ethernet eth0: Cadence GEM rev 0x00070109 at 0x1f00100000 irq 95 (da:2e:6d:9d:52:a4) > > [ 0.989067] macb 1f00100000.ethernet eth0: PHY [1f00100000.ethernet-ffffffff:01] driver [Broadcom BCM54210E] (irq=POLL) > > [ 0.989272] macb 1f00100000.ethernet eth0: configuring for phy/rgmii-id link mode > > [ 0.991271] macb 1f00100000.ethernet: gem-ptp-timer ptp clock registered. > > [ 4.039490] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx > > [ 4.062589] Sending DHCP requests ..... > > [ 40.902771] macb 1f00100000.ethernet eth0: Link is Down > > [ 43.975334] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx > > > > I've tried porting patches to drivers/net/phy/broadcom.c from the > > Raspberry Pi kernel to specifically support the BCM54213PE PHY (which is > > otherwise identified as a BCM54210E), but they didn't seem to help. > > > > What's the status of ethernet support on the Pi 5, is it supposed to > > work upstream, or are there pieces still missing ? > > We have this [1] patch queued up, could you give it a try please. > > [1] https://www.spinics.net/lists/kernel/msg5889475.html It fixes the issue, thank you ! I've sent a patch to add an ethernet0 alias (https://lore.kernel.org/all/20251102002901.467-1-laurent.pinchart@ideasonboard.com), with that I get working ethernet with a stable MAC address. -- Regards, Laurent Pinchart