From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Simon Horman" <horms@kernel.org>,
"Boon Khai Ng" <boon.khai.ng@altera.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 1/4] net: altera-tse: Set platform drvdata before registering netdev
Date: Tue, 4 Nov 2025 18:20:35 -0800 [thread overview]
Message-ID: <20251104182035.29082775@kernel.org> (raw)
In-Reply-To: <20251103104928.58461-2-maxime.chevallier@bootlin.com>
On Mon, 3 Nov 2025 11:49:24 +0100 Maxime Chevallier wrote:
> We don't have to wait until netdev is registered before setting it as the
> pdev's drvdata. Move it at netdev alloc time.
FWIW sometimes the late setting of drvdata is done to make sure drvdata
is NULL if we error out but forget to set ret (so probe returns 0 even
tho it failed). But the error paths looks fine here so 🤷️
next prev parent reply other threads:[~2025-11-05 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 10:49 [PATCH net-next v2 0/4] net: altera-tse: Cleanup init sequence Maxime Chevallier
2025-11-03 10:49 ` [PATCH net-next v2 1/4] net: altera-tse: Set platform drvdata before registering netdev Maxime Chevallier
2025-11-05 2:20 ` Jakub Kicinski [this message]
2025-11-03 10:49 ` [PATCH net-next v2 2/4] net: altera-tse: Warn on bad revision at probe time Maxime Chevallier
2025-11-03 13:42 ` Andrew Lunn
2025-11-03 10:49 ` [PATCH net-next v2 3/4] net: altera-tse: Don't use netdev name for the PCS mdio bus Maxime Chevallier
2025-11-03 10:49 ` [PATCH net-next v2 4/4] net: altera-tse: Init PCS and phylink before registering netdev Maxime Chevallier
2025-11-05 2:20 ` [PATCH net-next v2 0/4] net: altera-tse: Cleanup init sequence patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104182035.29082775@kernel.org \
--to=kuba@kernel.org \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).