Re: [PATCH v3] PCI: dw-rockchip: Prevent advertising L1 Substates support

Niklas Cassel
2025-10-18T05:07:50Z

On 17 October 2025 18:45:58 CEST, Bjorn Helgaas <helgaas@kernel.org> wrote:

(snip)

>>
>> Thus, prevent advertising L1 Substates support until proper driver support
>> is added.
>
>I think Mani is planning a change so we don't try to enable L1
>Substates by default, which should avoid the regression even without a
>patch like this.

Sounds good, I suggested the same:
https://lore.kernel.org/linux-pci/aO9tWjgHnkATroNa@ryzen/

>
>That will still leave the existing CONFIG_PCIEASPM_POWER_SUPERSAVE=y
>and sysfs l1_1_aspm problems.

Indeed, which is why I think that this patch is v6.18 material.

>
>And we'll need to figure out a way to allow L1.x to be enabled based
>on 'supports-clkreq' and possibly other info. That would likely be
>v6.19 material since it's new functionality.

I agree.

Kind regards,
Niklas