Re: [PATCH v3] PCI: dw-rockchip: Prevent advertising L1 Substates support

Shawn Lin
2025-11-11T13:28:32Z

在 2025/11/11 星期二 21:08, Niklas Cassel 写道:
> Hello Mani,
>
> On Tue, Oct 21, 2025 at 08:05:17AM +0530, Manivannan Sadhasivam wrote:
>>
>> On Fri, 17 Oct 2025 18:32:53 +0200, Niklas Cassel wrote:
>>> The L1 substates support requires additional steps to work, namely:
>>> -Proper handling of the CLKREQ# sideband signal. (It is mostly handled by
>>> hardware, but software still needs to set the clkreq fields in the
>>> PCIE_CLIENT_POWER_CON register to match the hardware implementation.)
>>> -Program the frequency of the aux clock into the
>>> DSP_PCIE_PL_AUX_CLK_FREQ_OFF register. (During L1 substates the core_clk
>>> is turned off and the aux_clk is used instead.)
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] PCI: dw-rockchip: Prevent advertising L1 Substates support
>> commit: 40331c63e7901a2cc75ce6b5d24d50601efb833d
>
> Last update in this thread was "Applied, thanks!"
>
> and the patch was applied to pci/controller/dw-rockchip
>
> since then it seems to have been demoted to pci/controller/dw-rockchip-pend
>
> I'm simply curious, what is the plan for this patch?
>
> I know that Shawn was working on a series that adds support for L1ss for
> this driver, but it seems to have stagnated, so it seems far from certain

Yes, that's because Bjorn prefers to disable it in dwc core intially and
sent a patch which we discussed but didn't come to a conclusion. So I
still be waiting..:）

> that it will be ready in time to make it for the v6.19 merge window.
>
> Right now, pci/next branch seems to merge pci/controller/dw-rockchip rather
> than pci/controller/dw-rockchip-pend.
>
> If the L1ss does not make it in time, then this patch will not have had any
> time in linux-next, which might not make Linus happy.
>
>
> Kind regards,
> Niklas
>