From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Manish Chopra <manishc@marvell.com>,
Marco Crivellari <marco.crivellari@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Sunil Goutham <sgoutham@marvell.com>,
Richard Cochran <richardcochran@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Kory Maincent <kory.maincent@bootlin.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/7] bnx2x: convert to use ndo_hwtstamp callbacks
Date: Wed, 5 Nov 2025 10:46:10 -0800 [thread overview]
Message-ID: <20251105104610.726fb780@kernel.org> (raw)
In-Reply-To: <f28ee997-ed08-4123-83ab-3496e88ed815@linux.dev>
On Wed, 5 Nov 2025 13:33:08 +0000 Vadim Fedorenko wrote:
> >> bp->hwtstamp_ioctl_called = true;
> >> - bp->tx_type = config.tx_type;
> >> - bp->rx_filter = config.rx_filter;
> >> + bp->tx_type = config->tx_type;
> >> + bp->rx_filter = config->rx_filter;
> >>
> >> rc = bnx2x_configure_ptp_filters(bp);
> >
> > bnx2x_configure_ptp_filters() may return -ERANGE if settings were not applied.
> > This may already be semi-broken but with the get in place we will make
> > it even worse.
>
> Ah, you mean in case of -ERANGE we will still have new filter
> configuration set in bp object? It's easy to fix, but it will be
> some kind of change of behavior. If it's acceptable, I'm happy to send
> v3 of the patchset.>
True, you can probably make the -ERANGE handling a separate patch
for ultimate clarity.
next prev parent reply other threads:[~2025-11-05 18:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 15:09 [PATCH net-next v2 0/7] convert drivers to use ndo_hwtstamp callbacks part 3 Vadim Fedorenko
2025-11-03 15:09 ` [PATCH net-next v2 1/7] bnx2x: convert to use ndo_hwtstamp callbacks Vadim Fedorenko
2025-11-05 1:37 ` Jakub Kicinski
2025-11-05 13:33 ` Vadim Fedorenko
2025-11-05 18:46 ` Jakub Kicinski [this message]
2025-11-05 19:12 ` Vadim Fedorenko
2025-11-03 15:09 ` [PATCH net-next v2 2/7] net: liquidio: " Vadim Fedorenko
2025-11-03 15:09 ` [PATCH net-next v2 3/7] net: liquidio_vf: " Vadim Fedorenko
2025-11-03 15:09 ` [PATCH net-next v2 4/7] net: octeon: mgmt: " Vadim Fedorenko
2025-11-03 15:09 ` [PATCH net-next v2 5/7] net: thunderx: " Vadim Fedorenko
2025-11-03 15:09 ` [PATCH net-next v2 6/7] net: pch_gbe: " Vadim Fedorenko
2025-11-03 19:20 ` Kory Maincent
2025-11-03 15:09 ` [PATCH net-next v2 7/7] qede: " Vadim Fedorenko
2025-11-05 1:43 ` Jakub Kicinski
2025-11-05 13:36 ` Vadim Fedorenko
2025-11-05 1:50 ` [PATCH net-next v2 0/7] convert drivers to use ndo_hwtstamp callbacks part 3 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105104610.726fb780@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=manishc@marvell.com \
--cc=marco.crivellari@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sgoutham@marvell.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).