From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: airoha: Reorganize airoha_queue struct
Date: Wed, 5 Nov 2025 16:28:46 -0800 [thread overview]
Message-ID: <20251105162846.53acd791@kernel.org> (raw)
In-Reply-To: <aQsCYoS-cvkUjrMv@lore-desk>
On Wed, 5 Nov 2025 08:53:06 +0100 Lorenzo Bianconi wrote:
> > On Mon, 03 Nov 2025 11:27:56 +0100 Lorenzo Bianconi wrote:
> > > Do not allocate memory for rx-only fields for hw tx queues and for tx-only
> > > fields for hw rx queues.
> >
> > Could you share more details (pahole)
> > Given that napi_struct is in the same struct, 20B is probably not going
> > to make much difference?
>
> I agree the difference is not huge, I added this patch mainly for code
> readability. If you prefer I can drop the patch, I do not have a strong
> opinion about it. What do you think?
I would not do it but your call.. Perhaps staring at data structures
in crash dumps w/ drgn made me overly cautions of unnecessary overlap.
next prev parent reply other threads:[~2025-11-06 0:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 10:27 [PATCH net-next 0/2] net: airoha: Allow mapping out-of-order DMA tx descriptors Lorenzo Bianconi
2025-11-03 10:27 ` [PATCH net-next 1/2] net: airoha: Add the capability to consume " Lorenzo Bianconi
2025-11-03 23:32 ` Jacob Keller
2025-11-05 2:30 ` Jakub Kicinski
2025-11-05 8:18 ` Lorenzo Bianconi
2025-11-03 10:27 ` [PATCH net-next 2/2] net: airoha: Reorganize airoha_queue struct Lorenzo Bianconi
2025-11-03 23:36 ` Jacob Keller
2025-11-05 2:32 ` Jakub Kicinski
2025-11-05 7:53 ` Lorenzo Bianconi
2025-11-06 0:28 ` Jakub Kicinski [this message]
2025-11-06 8:27 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105162846.53acd791@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).