linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST
@ 2025-11-06  2:24 Rosen Penev
  2025-11-06  2:24 ` [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit Rosen Penev
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Rosen Penev @ 2025-11-06  2:24 UTC (permalink / raw)
  To: dmaengine
  Cc: Vinod Koul, Ludovic Desroches, open list,
	moderated list:MICROCHIP AT91 DMA DRIVERS

First commit fixes compilation under 64-bit and second actually enables
it.

Rosen Penev (2):
  dmaengine: at_hdmac: fix formats under 64-bit
  dmaengine: at_hdmac: add COMPILE_TEST support

 drivers/dma/Kconfig    | 2 +-
 drivers/dma/at_hdmac.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

--
2.51.2



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit
  2025-11-06  2:24 [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Rosen Penev
@ 2025-11-06  2:24 ` Rosen Penev
  2025-11-21  8:52   ` Eugen Hristev
  2025-11-06  2:24 ` [PATCH dmaengine 2/2] dmaengine: at_hdmac: add COMPILE_TEST support Rosen Penev
  2025-11-22  9:30 ` [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Vinod Koul
  2 siblings, 1 reply; 6+ messages in thread
From: Rosen Penev @ 2025-11-06  2:24 UTC (permalink / raw)
  To: dmaengine
  Cc: Vinod Koul, Ludovic Desroches, open list,
	moderated list:MICROCHIP AT91 DMA DRIVERS

size_t formats under 32-bit evaluate to the same thing and GCC does not
warn against it. Not the case with 64-bit.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/dma/at_hdmac.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 2d147712cbc6..7d226453961f 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -887,7 +887,7 @@ atc_prep_dma_interleaved(struct dma_chan *chan,
 	first = xt->sgl;
 
 	dev_info(chan2dev(chan),
-		 "%s: src=%pad, dest=%pad, numf=%d, frame_size=%d, flags=0x%lx\n",
+		 "%s: src=%pad, dest=%pad, numf=%zu, frame_size=%zu, flags=0x%lx\n",
 		__func__, &xt->src_start, &xt->dst_start, xt->numf,
 		xt->frame_size, flags);
 
@@ -1174,7 +1174,7 @@ atc_prep_dma_memset_sg(struct dma_chan *chan,
 	int			i;
 	int			ret;
 
-	dev_vdbg(chan2dev(chan), "%s: v0x%x l0x%zx f0x%lx\n", __func__,
+	dev_vdbg(chan2dev(chan), "%s: v0x%x l0x%x f0x%lx\n", __func__,
 		 value, sg_len, flags);
 
 	if (unlikely(!sgl || !sg_len)) {
@@ -1503,7 +1503,7 @@ atc_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len,
 	unsigned int		periods = buf_len / period_len;
 	unsigned int		i;
 
-	dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@%pad - %d (%d/%d)\n",
+	dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@%pad - %d (%zu/%zu)\n",
 			direction == DMA_MEM_TO_DEV ? "TO DEVICE" : "FROM DEVICE",
 			&buf_addr,
 			periods, buf_len, period_len);
-- 
2.51.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH dmaengine 2/2] dmaengine: at_hdmac: add COMPILE_TEST support
  2025-11-06  2:24 [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Rosen Penev
  2025-11-06  2:24 ` [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit Rosen Penev
@ 2025-11-06  2:24 ` Rosen Penev
  2025-11-21  8:52   ` Eugen Hristev
  2025-11-22  9:30 ` [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Vinod Koul
  2 siblings, 1 reply; 6+ messages in thread
From: Rosen Penev @ 2025-11-06  2:24 UTC (permalink / raw)
  To: dmaengine
  Cc: Vinod Koul, Ludovic Desroches, open list,
	moderated list:MICROCHIP AT91 DMA DRIVERS

Allows the buildbot to detect potential issues with the code on various
platforms.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 8cb36305be6d..243d3959ba79 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -102,7 +102,7 @@ config ARM_DMA350
 
 config AT_HDMAC
 	tristate "Atmel AHB DMA support"
-	depends on ARCH_AT91
+	depends on ARCH_AT91 || COMPILE_TEST
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-- 
2.51.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit
  2025-11-06  2:24 ` [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit Rosen Penev
@ 2025-11-21  8:52   ` Eugen Hristev
  0 siblings, 0 replies; 6+ messages in thread
From: Eugen Hristev @ 2025-11-21  8:52 UTC (permalink / raw)
  To: Rosen Penev, dmaengine
  Cc: Vinod Koul, Ludovic Desroches, open list,
	moderated list:MICROCHIP AT91 DMA DRIVERS



On 11/6/25 04:24, Rosen Penev wrote:
> size_t formats under 32-bit evaluate to the same thing and GCC does not
> warn against it. Not the case with 64-bit.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Eugen Hristev <eugen.hristev@linaro.org>

> ---
>  drivers/dma/at_hdmac.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 2d147712cbc6..7d226453961f 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -887,7 +887,7 @@ atc_prep_dma_interleaved(struct dma_chan *chan,
>  	first = xt->sgl;
>  
>  	dev_info(chan2dev(chan),
> -		 "%s: src=%pad, dest=%pad, numf=%d, frame_size=%d, flags=0x%lx\n",
> +		 "%s: src=%pad, dest=%pad, numf=%zu, frame_size=%zu, flags=0x%lx\n",
>  		__func__, &xt->src_start, &xt->dst_start, xt->numf,
>  		xt->frame_size, flags);
>  
> @@ -1174,7 +1174,7 @@ atc_prep_dma_memset_sg(struct dma_chan *chan,
>  	int			i;
>  	int			ret;
>  
> -	dev_vdbg(chan2dev(chan), "%s: v0x%x l0x%zx f0x%lx\n", __func__,
> +	dev_vdbg(chan2dev(chan), "%s: v0x%x l0x%x f0x%lx\n", __func__,
>  		 value, sg_len, flags);
>  
>  	if (unlikely(!sgl || !sg_len)) {
> @@ -1503,7 +1503,7 @@ atc_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len,
>  	unsigned int		periods = buf_len / period_len;
>  	unsigned int		i;
>  
> -	dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@%pad - %d (%d/%d)\n",
> +	dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@%pad - %d (%zu/%zu)\n",
>  			direction == DMA_MEM_TO_DEV ? "TO DEVICE" : "FROM DEVICE",
>  			&buf_addr,
>  			periods, buf_len, period_len);



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH dmaengine 2/2] dmaengine: at_hdmac: add COMPILE_TEST support
  2025-11-06  2:24 ` [PATCH dmaengine 2/2] dmaengine: at_hdmac: add COMPILE_TEST support Rosen Penev
@ 2025-11-21  8:52   ` Eugen Hristev
  0 siblings, 0 replies; 6+ messages in thread
From: Eugen Hristev @ 2025-11-21  8:52 UTC (permalink / raw)
  To: Rosen Penev, dmaengine
  Cc: Vinod Koul, Ludovic Desroches, open list,
	moderated list:MICROCHIP AT91 DMA DRIVERS



On 11/6/25 04:24, Rosen Penev wrote:
> Allows the buildbot to detect potential issues with the code on various
> platforms.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Eugen Hristev <eugen.hristev@linaro.org>

> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 8cb36305be6d..243d3959ba79 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -102,7 +102,7 @@ config ARM_DMA350
>  
>  config AT_HDMAC
>  	tristate "Atmel AHB DMA support"
> -	depends on ARCH_AT91
> +	depends on ARCH_AT91 || COMPILE_TEST
>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
>  	help



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST
  2025-11-06  2:24 [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Rosen Penev
  2025-11-06  2:24 ` [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit Rosen Penev
  2025-11-06  2:24 ` [PATCH dmaengine 2/2] dmaengine: at_hdmac: add COMPILE_TEST support Rosen Penev
@ 2025-11-22  9:30 ` Vinod Koul
  2 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2025-11-22  9:30 UTC (permalink / raw)
  To: dmaengine, Rosen Penev; +Cc: Ludovic Desroches, linux-kernel, linux-arm-kernel


On Wed, 05 Nov 2025 18:24:03 -0800, Rosen Penev wrote:
> First commit fixes compilation under 64-bit and second actually enables
> it.
> 
> Rosen Penev (2):
>   dmaengine: at_hdmac: fix formats under 64-bit
>   dmaengine: at_hdmac: add COMPILE_TEST support
> 
> [...]

Applied, thanks!

[1/2] dmaengine: at_hdmac: fix formats under 64-bit
      commit: 938eae912ac52f8e9e5f2463e2db30cfe6f895d5
[2/2] dmaengine: at_hdmac: add COMPILE_TEST support
      commit: 5d8c5bea0da97809813b5f702700019cfffb6085

Best regards,
-- 
~Vinod




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-11-22  9:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-06  2:24 [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Rosen Penev
2025-11-06  2:24 ` [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit Rosen Penev
2025-11-21  8:52   ` Eugen Hristev
2025-11-06  2:24 ` [PATCH dmaengine 2/2] dmaengine: at_hdmac: add COMPILE_TEST support Rosen Penev
2025-11-21  8:52   ` Eugen Hristev
2025-11-22  9:30 ` [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).