From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 941F9CCF9E3 for ; Mon, 10 Nov 2025 14:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QE6nJY8xw+e7wdi1yqVQH04Dj6slEaMZwmLP+N2iawc=; b=ffyapR8gViDarQ orN2LJ+x2LznaVQ2jDQS85qgFoaBmJSfRri5OqWkz2kx6QuJb5xpb9msILHqImI2HPgGvsuKSHcZd Gb1vvo8D0BFstC1ycXWkwQJ8wiS6zwCi+8iADr129MIhuAGykYthLrRDkcKlCLvUuiWufKPh43BKN OGmSdzPnsUYDCkWkT5k+dSsKkGBuVm/mj5ifeOWmhGs/+dYkPNTXaX/qk/dX2U66l+AuZAn7oWxHc 3kCG4v5CbS8F0/0IwxtWiFaLKkAcHBEaxKx4Uozvcus7fNayvdfgS/0EFmt3JL+6HUN6nbc2MuP0Z BSM2w0Lcxo5Le28v+DKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vISmJ-00000005ZOB-2nNU; Mon, 10 Nov 2025 14:21:55 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vISmH-00000005ZNR-03pg for linux-arm-kernel@lists.infradead.org; Mon, 10 Nov 2025 14:21:54 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-475ca9237c2so16634665e9.3 for ; Mon, 10 Nov 2025 06:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762784511; x=1763389311; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=QE6nJY8xw+e7wdi1yqVQH04Dj6slEaMZwmLP+N2iawc=; b=r/5f3HJvi7nZZK0/28o/Z06OP8DBR9W2ymVyIZkFwjlGI11vOMxqmgZhNpYk/gGYA0 qgTh/eqRAqyr79Kmlnn6xTBYuztPmLtsNqbZiThRHymQqMwEoqgBeUbYmVYVGBuNSfMf 1paVQ8pFcSpv5to93yFcO1ffzDw/aaJn2W6N2x4Qa/U6BBYLJtbU5bvaesms+R+VlvOv 59H3c57ETn/JYPnHU3lvQwAcwyYMML2aPcZaSFk6SLfJS/I+YoqFtywgjgZCFGSjlJr/ XuSWNKgelJIt4blKwZMe2+RpD8cytD+cKtA0bDvb/lgDrAICty5ZZL7oOUTuaRg3gHyI IjAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762784511; x=1763389311; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QE6nJY8xw+e7wdi1yqVQH04Dj6slEaMZwmLP+N2iawc=; b=He7aYHGt+p8RNuqA+EncLZ9h9fzHW9MeLYeppdbbOfPUvkLZpTfnNIgHms70gQk1Xh EIbTAsu6tUr7dkXbZK12ZxXr9YPRzIheaMdFLzlLUjYlUbZcXLM+P+ugIj9UvM9TR5L/ oEJxZMv+qMsHpqbHY2dRjyjrzQ5N9+SGC8aAXknxqEn7nMCeZwAMoFBCRL8tzLAjwpyt A17LVo3RzPd18nUmA4Kua+7Z9ABDeyYysMqL4aLPyl6iSs7Z3zNfi/7elDPtKjjvfp1V OLJBTFneUqccLJG+0wIy46TyPq9i5tyrglZiH4GzZODEAV8lEPqehF7wrpfy/AkHXN3A UQ8Q== X-Forwarded-Encrypted: i=1; AJvYcCV/+bNqXkqV53nkGuddCNKbox9awOp2tAfh6hvYqa/NeLGiHC8tGaGctKhSS7tjTjd4zD0E+ymzpvS+Lr1TLqNX@lists.infradead.org X-Gm-Message-State: AOJu0Yx3V2yc/dPMduMunNyqxjJobCYpinldvt+P15oxQMF3Xy0rDzgB Xr3/J2O2RT4cfZ04Nl0fRqd4kOgrVA93G5g46OhLAl0RT1cq4UkRkrhfd0vOJxOlMoM= X-Gm-Gg: ASbGncvQuPm2VQe3qfSJXQ8SGLt0H/pUkM2v8sL+eKCr06W5QCFOEk+BHqwVtLhYnwC NUnZ6AgojJTcQM+pO6YAhnNkc1gaOsOMc4SejjFkIaiQ9emGU5oTsA4Gz+El/YgDueCd5UWOwSD UGxRi5rPzc6FTenAEC+a/dBL9M+oJO0iPm41OI4kyLvcBXEhul0usva9hWhMBoIhfJ0cE84uRRt u+vg5Ajea9Zs/NDnsThqX/72lSs0AyHXeHighdmp41HY5pfiJ91O1KY8A4BNxqphDhVU6LwGcUt S2fH+TBlYKPpxJCePeSimu5PUYw8rZT48Tjs03n7aszxqMZy4IIPxmePekrP8rwtii8cjN4J8dz lvaMbdjCrpYUqIxRLTh4f+uXwnuV1l1bJGALkcBwJK9CHT+dFTOESimVeAGmOe87VK8uPzM0lTW PL76g91GG6lkijdSJVYQjOFdaHGLQ3mYp7Ubd1Eu8p X-Google-Smtp-Source: AGHT+IGfk9QMxpL095oW4l5k6kRJuvwmjzGuGYReI0aPwMTL0wEuahVhkwUYnhLSGwtqashoUergpQ== X-Received: by 2002:a05:600c:3ba0:b0:477:7c7d:d9b7 with SMTP id 5b1f17b1804b1-4777c7ddabdmr41626065e9.33.1762784511044; Mon, 10 Nov 2025 06:21:51 -0800 (PST) Received: from gpeter-l.roam.corp.google.com ([145.224.90.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4776a953414sm104369435e9.0.2025.11.10.06.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 06:21:49 -0800 (PST) From: Peter Griffin Subject: [PATCH v4 0/4] Implement hardware automatic clock gating (HWACG) for gs101 Date: Mon, 10 Nov 2025 14:21:39 +0000 Message-Id: <20251110-automatic-clocks-v4-0-8f46929f50b7@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAPT0EWkC/23NQQ6CMBCF4auQrq2ZThGLK+9hXNQyhUakpkWiI dzdYkzUyPJ/yXwzskjBUWS7bGSBBhed71Lkq4yZRnc1cVelZgi4EQCK61vvL7p3hpvWm3PkmJf 6VIAt0BBLZ9dA1t1f5OGYunGx9+Hx+jCIeX1jQv5jg+DAt6g2gghAAuxb1+ng1z7UbNYG/BKwX BAwCVZRVUmNlcLTnyA/QiIWBDkLVgBpS4Uw6keYpukJeWbW6jUBAAA= X-Change-ID: 20251008-automatic-clocks-249ab60f62ce To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , =?utf-8?q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Michael Turquette , Stephen Boyd , Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi Cc: Will McVicker , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, kernel-team@android.com, Peter Griffin , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=8439; i=peter.griffin@linaro.org; h=from:subject:message-id; bh=1QhIhqeBqQFJYxh6dF7YY7QSMlj8SKS5YCmCkuRGJLQ=; b=owEBbQKS/ZANAwAKAc7ouNYCNHK6AcsmYgBpEfT3FR66ljDUvk6K8V775A3mKTEytO6XuqxbU 8A8C5svrOOJAjMEAAEKAB0WIQQO/I5vVXh1DVa1SfzO6LjWAjRyugUCaRH09wAKCRDO6LjWAjRy ut8zD/9/sMa93EIgJIRBXunfQvBYFUn0ARq8Y2T7or0OJHTzkDv24QZQKThoiPT2sVRMiWxYg2L 6c9XYCYRDAKcEeIv4pdvYOSAZXSgpfFdiUdhgNNMljleAsB5qyf8HyrP111W/RxaMH3GUe8m6nK 34oohUWK7nVmfjuXzTfe5VQY4ETqdk5CmKfv+8EjVDxoOkUu6SaVMmNfhnHz/+T58Mw6fhRuBks yy9zfUXWhu+Zzq4eMnl6OlDA3Yd9sEX1i6D0MTpr8bC5hww4pQClv+fZW7Fif7nQJWmMgFYxGXk WxqGi4zfxxMAOvuN0OwBCu66IDIM8avY1V/vTkTUG5Q70CiSBbkO+bW8nnSJ7Pgwxl+6f+UG7K0 99FSltis+c+AUJWxd8wHDnUK1iEatIQ2VnP9yCRWUCThZzDsUWhP4C3TJOjP6wjUo8R728yP6QI HwLQqPsvzZkUIOV/vn4E13HTk928iL3dx6sNE30uBx84FKvUVyGlKRBVKkyfVNf3rtaHuiXvocZ VdKDI2CIW67iUr9oce4FFDw91/rmmSqoAmnKBbbqken88aDfgJk4SN+P+hjI/oRbioasucktie0 d+a22ZAlw9C7kFurZUISXmEVUAooJynkstVqQTSHP6MYvC1NO581o+MtbXwYAu2wlo3v/eOcqmM IgxDPFN2lJvMQQw== X-Developer-Key: i=peter.griffin@linaro.org; a=openpgp; fpr=0EFC8E6F5578750D56B549FCCEE8B8D6023472BA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251110_062153_125943_65ECF6D6 X-CRM114-Status: GOOD ( 32.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi folks, This series addresses an issue with Samsung Exynos based upstream clock driver whereby the upstream clock driver sets all the clock gates into "manual mode" (which uses a bit that is documented as reserved in the gate registers). Another issue with the current "manual clock gating" approach upstream is there are many bus/interconnect clocks whose relationships to the IPs are not well documented or defined in the specs. When adding a new CMU until now we have tried to label these clocks appropriately with CLK_IS_CRITICAL and CLK_IGNORE_UNUSED but doing so is both error prone and time consuming. If your lucky disabling a critical bus clock causes an immediate hang. Other clocks however aren't so obvious and show up through random instability some period of time later. Fortunately each CMU (at least on newer Exynos) provides a "hardware automatic clock gating" HWACG feature that is used by the downstream Samsung clock drivers. Hardware automatic clock gating uses a hardware interface between the CMU and IP to control all clocks required by the IP. This interface is called Q-channel, and is part of the Arm AMBA low power interface specification [1]. The advantage of using this Qchannel hardware interface for enabling/disabling the clocks is that it takes care of all clocks (including bus/interconnect) ones for the IP automatically thereby reducing the dynamic power. Whilst each clock component (GATE, MUX, DIV, QCH etc) has a HWACG enable bit there are also some "global enable override" bits for the entire CMU in the CMU_CONTROLLER_OPTION register. This series makes use of those "global enable" override bits to enable auto clock mode for the entire CMU and every component within it. Through experimentation we can see that setting the "manual mode" reserved gate bit on a particular gate register overides the global enable bits. So the code is updated accordingly not to do that. Auto clock mode has been implemented as a "opt in" by setting a new auto_clock_gate flag in the CMU static data. The intention is existing platforms in manual mode should not be effected by any of these changes. If auto_clock_mode flag is set and the option_offset field is specified then the global enable override bits will be written for the CMU (to avoid relying on any prior bootstage configuration). Again if auto mode is enabled the code no longer sets MANUAL and clears HWACG bits on each gate register. To ensure compatibility with older DTs (that specified an incorrect CMU size) the resource size is checked and the driver falls back to manual clock gate mode in such cases. As the CLK_IGNORE_UNUSED and CLK_IS_CRITICAL flags are required for manual clock gate mode, the patch removing these flags has been dropped from v2. I tested with an old DT and we successfully switch to manual clock gate mode and the system correctly boots. To have dynamic root clock gating (drcg) of bus components and memclk enabled, it is required to set the bus_component_drcg and memclk registers in the correspondingly named sysreg controller. If auto clock mode is enabled the clock driver will now attempt to get the sysreg syscon via the samsung,sysreg property (as used by other Exynos drivers upstream) and set the registers accordingly. The suspend/resume code paths are also updated to handle saving/restoring registers using a regmap. Note cmu_top is an exception and does not have a corresondingly named sysreg_top. As all clock gates are currently exposed in the gs101 drivers and DT, we continue to register all of these gates in auto clock mode, but with some new samsung_auto_clk_gate_ops. As clk enable and clk disable are now handled by Q-channel interface the .enable and .disable implementations are no-ops. However by using some CMU qchannel debug registers we can report the current clock status (enabled or disabled) of every clock gate in the system. This has the nice effect of still being able to dump the entire clock tree from /sys/kernel/debug/clk/clk_summary and see a live view of every auto clock in the system. With the infrastructure in place, all the CMUs registered in clk-gs101 are now updated to enable auto clock mode. From dumping /sys/kernel/debug/clk/clk_summary it is possible to see that after enabling auto clock mode approximately 305 clocks are enabled, and 299 are now disabled. This number goes up and down a bit by 3-5 clocks just on a idle system sat at a console. With auto clock mode enabled it is now also possible to boot without the clk_ignore_unused kernel command line property for the first time! For future CMUs in gs101 I propose we continue to expose all gates, but register the CMU in "auto mode". For new device drivers or updates to existing dt bindings related to clocks to support gs101 I suggest we only use the "obviously correct" clock(s). By "obviously correct" I mean a clock has the IP name in the clock register name, but not try to deduce other obsucurely named bus/interconnect clocks which will now all be handled automatically. Note it is still possible to test whether the "obviously correct" clock is indeed correct by putting the individual gate in manual mode and disabling the clock (e.g. by using devmem). Note: As everything here will go via one of Krzysztof's trees I've sent it as one series. regards, Peter [1] https://documentation-service.arm.com/static/5f915e69f86e16515cdc3b3e?token= Signed-off-by: Peter Griffin --- Changes in v4: - Update commit description with additional requested details (Krzysztof) - Remove unnecessary header of_address.h (Peter) - Link to v3: https://lore.kernel.org/r/20251102-automatic-clocks-v3-0-ff10eafe61c8@linaro.org Changes in v3: - Add missing 'np' func param to kerneldoc in samsung_cmu_register_clocks (0-DAY CI ) - Link to v2: https://lore.kernel.org/r/20251029-automatic-clocks-v2-0-f8edd3a2d82b@linaro.org Changes in v2: - Rebased onto next-20251024 - Fallback to manual clock gate mode for old DTs with incorrect CMU reg size (added samsung_is_auto_capable(). Tested with old DT and it works as expected. It does require keeping all the CLK_IS_CRITICAL CLK_IGNORE_UNUSED flags in clk-gs101 so patch removing those is dropped. (Krzysztof) - Rename OPT_UNKNOWN bit to OPT_EN_LAYER2_CTRL (Andre) - Rename OPT_EN_MEM_PM_GATING to OPT_EN_MEM_PWR_GATING (Peter) - Reverse Option bit definitions LSB -> MSB (Krzysztof) - Update kerneldoc init_clk_regs comment (Andre) - Fix space on various comments (Andre) - Fix regmap typo on samsung_clk_save/restore calls (Andre) - Include error code in pr_err message (Andre) - Add macros for dcrg and memclk (Andre) - Avoid confusing !IS_ERR_OR_NULL(ctx->sysreg) test (Krzysztof) - Update kerneldoc to mention drcg_offset & memclk_offset are in sysreg (Andre) - Update bindings commit description as to why the sysreg is required (Krzysztof) - Link to v1: https://lore.kernel.org/r/20251013-automatic-clocks-v1-0-72851ee00300@linaro.org --- Peter Griffin (4): dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required arm64: dts: exynos: gs101: add samsung,sysreg property to CMU nodes clk: samsung: Implement automatic clock gating mode for CMUs clk: samsung: gs101: Enable auto_clock_gate mode for each gs101 CMU .../bindings/clock/google,gs101-clock.yaml | 23 ++- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 6 + drivers/clk/samsung/clk-exynos-arm64.c | 62 ++++++- drivers/clk/samsung/clk-exynos4.c | 12 +- drivers/clk/samsung/clk-exynos4412-isp.c | 4 +- drivers/clk/samsung/clk-exynos5250.c | 2 +- drivers/clk/samsung/clk-exynos5420.c | 4 +- drivers/clk/samsung/clk-gs101.c | 55 ++++++ drivers/clk/samsung/clk-s3c64xx.c | 4 +- drivers/clk/samsung/clk-s5pv210.c | 2 +- drivers/clk/samsung/clk.c | 200 +++++++++++++++++++-- drivers/clk/samsung/clk.h | 55 +++++- 12 files changed, 385 insertions(+), 44 deletions(-) --- base-commit: 72fb0170ef1f45addf726319c52a0562b6913707 change-id: 20251008-automatic-clocks-249ab60f62ce Best regards, -- Peter Griffin