From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E1A3CCFA13 for ; Mon, 10 Nov 2025 16:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vMXv6zHy/5lpN/W3jflZ7Ubivn2WlDK18umb46ltG9A=; b=2vXb83pvGiUjs3J47AajG3zGq/ z+bhJ3jSaMIaaW105s9kJsCnEaLWsWitpBM+HEa4lHPtePqyER7mM3BADkrDgQD1g+Fj6uhz38jnl WoL7fRjfRxP96hKvXU84S7FtFqywRyNUWvWkY0U6H4652b+iax4uxYYBgcTWKOMYqNpQ/iG96Rjou DWEuzOr462xIFioFOcLwNQ5nRKgWV2phuxdXgfNXFyRab8Q2azf5hb/U69mInKTS9ZZrP4MOv1MzH vzBU4d28IfYVxpfGvQ6Vs1bXzybK2/UEH0VAFFuaHW0ARenMdl/jvmDeGkDnc0Gp2bSu9YgOAURZv TdUzRquA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIUU0-00000005lqx-1e5x; Mon, 10 Nov 2025 16:11:08 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIUTy-00000005lqY-0cCN for linux-arm-kernel@lists.infradead.org; Mon, 10 Nov 2025 16:11:07 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4d4vlY4rJ8zJ46Bd; Tue, 11 Nov 2025 00:10:33 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 27CB114033C; Tue, 11 Nov 2025 00:11:03 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Mon, 10 Nov 2025 16:11:01 +0000 Date: Mon, 10 Nov 2025 16:11:00 +0000 From: Jonathan Cameron To: Ben Horgan CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 08/33] ACPI: Define acpi_put_table cleanup handler and acpi_get_table_ret() helper Message-ID: <20251110161100.000039f3@huawei.com> In-Reply-To: <20251107123450.664001-9-ben.horgan@arm.com> References: <20251107123450.664001-1-ben.horgan@arm.com> <20251107123450.664001-9-ben.horgan@arm.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml100010.china.huawei.com (7.191.174.197) To dubpeml100005.china.huawei.com (7.214.146.113) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251110_081106_353911_18446006 X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 Nov 2025 12:34:25 +0000 Ben Horgan wrote: > Define a cleanup helper for use with __free to release the acpi table when > the pointer goes out of scope. Also, introduce the helper > acpi_get_table_ret() to simplify a commonly used pattern involving > acpi_get_table(). > > These are first used in a subsequent commit. > > Signed-off-by: Ben Horgan Seems useful enough to be to be worth having. Needs input from Rafael. Reviewed-by: Jonathan Cameron > --- > include/linux/acpi.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index a9dbacabdf89..1124b7dc79fd 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -8,6 +8,7 @@ > #ifndef _LINUX_ACPI_H > #define _LINUX_ACPI_H > > +#include > #include > #include /* for struct resource */ > #include > @@ -221,6 +222,17 @@ void acpi_reserve_initial_tables (void); > void acpi_table_init_complete (void); > int acpi_table_init (void); > > +static inline struct acpi_table_header *acpi_get_table_ret(char *signature, u32 instance) > +{ > + struct acpi_table_header *table; > + int status = acpi_get_table(signature, instance, &table); > + > + if (ACPI_FAILURE(status)) > + return ERR_PTR(-ENOENT); > + return table; > +} > +DEFINE_FREE(acpi_put_table, struct acpi_table_header *, if (!IS_ERR_OR_NULL(_T)) acpi_put_table(_T)) > + > int acpi_table_parse(char *id, acpi_tbl_table_handler handler); > int __init_or_acpilib acpi_table_parse_entries(char *id, > unsigned long table_size, int entry_id,