Re: [PATCH v7 8/9] arm64: dts: mediatek: update rtc properties for MT6359

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On Tue, Nov 11, 2025 at 02:59:22PM +0800, Jack Hsu wrote:
> Update properties of rtc for mt6359 PMIC
> 
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> 
> ---
> Changs in v7:
>  - remove mt635x-auadc.h
>  - remove fg nodes
> 
> ---
>  arch/arm64/boot/dts/mediatek/mt6359.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> index 467d8a4c2aa7..fe737254c091 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> @@ -302,6 +302,9 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
>  
>  		mt6359rtc: rtc {
>  			compatible = "mediatek,mt6358-rtc";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			status = "disabled";

Okay, this looks a lot better now. Still missing an explanation of why
it has been moved to disabled though, especially since you just go and
re-enable it (without adding child devices that use the address/size
cells).
pw-bot: changes-requested

>  		};
>  	};
>  };
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]