linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>,
	James Clark <james.clark@linaro.org>,
	Yeoreum Yun <yeoreum.yun@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Yabin Cui <yabinc@google.com>, Keita Morisaki <keyz@google.com>,
	Yuanfang Zhang <quic_yuanfang@quicinc.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 09/11] coresight: etm4x: Add flag to control single-shot restart
Date: Tue, 11 Nov 2025 10:18:05 +0000	[thread overview]
Message-ID: <20251111101805.GD281971@e132581.arm.com> (raw)
In-Reply-To: <a5ca5a65-8d5c-48b3-83f2-82d13c0b930d@arm.com>

On Tue, Nov 11, 2025 at 09:43:13AM +0000, Suzuki Kuruppassery Poulose wrote:

[...]

> >    if (!is_idle_task(current)) {
> >        if (config->ss_ctrl[i] || config->ss_pe_cmp[i])
> >            config->ss_status[i] &= ~TRCSSCSRn_STATUS;
> >    }
> 
> What happens when we do a system wide session and a CPU is running an
> idle task ?

For a system wide trace, the ETM device is enabled and disabled by
the perf when the session start and finish.

During the session:

- If CPU off states are not enabled, nothing will happen in idle
  threads, as no CPU PM notifier will be invoked.

- If CPU off states have been enabled, CPU PM notifier will save and
  restore ETM device context, and keep single-shot status.  This is
  same with current save/restore flow.

I don't see any issue for this.

Thanks,
Leo


  reply	other threads:[~2025-11-11 10:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 16:49 [PATCH v5 00/11] CoreSight: Refactor power management for ETMv3/4 Leo Yan
2025-11-03 16:49 ` [PATCH v5 01/11] coresight: Change device mode to atomic type Leo Yan
2025-11-03 16:49 ` [PATCH v5 02/11] coresight: etm4x: Always set tracer's device mode on target CPU Leo Yan
2025-11-03 16:49 ` [PATCH v5 03/11] coresight: etm3x: " Leo Yan
2025-11-03 16:49 ` [PATCH v5 04/11] coresight: etm4x: Correct polling IDLE bit Leo Yan
2025-11-03 16:49 ` [PATCH v5 05/11] coresight: etm4x: Add context synchronization before enabling trace Leo Yan
2025-11-03 16:49 ` [PATCH v5 06/11] coresight: etm4x: Properly control filter in CPU idle with FEAT_TRF Leo Yan
2025-11-03 16:49 ` [PATCH v5 07/11] coresight: etm4x: Remove the redundant DSB Leo Yan
2025-11-10 11:47   ` Yeoreum Yun
2025-11-03 16:49 ` [PATCH v5 08/11] coresight: etm4x: Remove the state_needs_restore flag Leo Yan
2025-11-03 16:49 ` [PATCH v5 09/11] coresight: etm4x: Add flag to control single-shot restart Leo Yan
2025-11-10 11:37   ` Suzuki K Poulose
2025-11-11  9:24     ` Leo Yan
2025-11-11  9:43       ` Suzuki K Poulose
2025-11-11 10:18         ` Leo Yan [this message]
2025-11-11 11:37           ` Suzuki K Poulose
2025-11-11 13:52             ` Leo Yan
2025-11-03 16:49 ` [PATCH v5 10/11] coresight: etm4x: Retain sequencer state Leo Yan
2025-11-03 16:49 ` [PATCH v5 11/11] coresight: etm4x: Reuse normal enable and disable logic in CPU idle Leo Yan
2025-11-10 11:44   ` Suzuki K Poulose
2025-11-11  9:25     ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111101805.GD281971@e132581.arm.com \
    --to=leo.yan@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.clark@linaro.org \
    --cc=keyz@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mike.leach@linaro.org \
    --cc=quic_yuanfang@quicinc.com \
    --cc=suzuki.poulose@arm.com \
    --cc=yabinc@google.com \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).